From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECAF6C77B74 for ; Mon, 10 Apr 2023 16:06:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B64128002E; Mon, 10 Apr 2023 12:06:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 465F428001E; Mon, 10 Apr 2023 12:06:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32D1C28002E; Mon, 10 Apr 2023 12:06:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 23B4128001E for ; Mon, 10 Apr 2023 12:06:26 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id ED4F9140333 for ; Mon, 10 Apr 2023 16:06:25 +0000 (UTC) X-FDA: 80665958730.03.BF91860 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id E8EA780013 for ; Mon, 10 Apr 2023 16:06:22 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uy9ZpuY0; spf=pass (imf30.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681142783; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KNqYd+1QnmqRLV5Ajn8FT5thAplwqJoHO3FJBlZCT9M=; b=5zhxobaQLsREDHU2GyoZscEULlgJSe/M6UDgMQKlwHb07nloCkm/1d0MmKcITyq/HiRrqa UVg2lbrT2DtzDh24nCzXneCz2KqBeWViJyG2yMKW9Mab5mYEQ2BNzTnyEbCymR9ZXb/B35 nGpADHL0NGUQysrv0Y9UdLdravQhfDo= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uy9ZpuY0; spf=pass (imf30.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681142783; a=rsa-sha256; cv=none; b=GXlFVMU63N7iAyf3x2Z3daRvwpzm16+hMmIUc9PW3RgwcTD73gz+ri7VHvV27vZRR8OkaM Brps0hNhfdV8hWjMwz6ol/UL6NpnWBr8CPqhivA//XvwXH75dpXg1/Wsy8Xqb9bdonfwgT 1hh5t/FmwAfpskpuSOhfGXU27Gj8400= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CBCF061AF6 for ; Mon, 10 Apr 2023 16:06:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1C44C433A7 for ; Mon, 10 Apr 2023 16:06:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681142780; bh=mwSxhzCg15RXyTCgR9LDyFgq4h2rR53nA455oB13C/U=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=uy9ZpuY0vy2vryhepr3pFQGMr8grlBUWulmlwmxtAdUIeGqBZT78A1zNPM7ZM7Pbg 80BlDSor2Q+NUbN+Em6MmVaioJUZUyf2LJAD9cZ+T2g6nhq70CYWjg4DeSKfM2PJin /yuIKz9GE3XW7WgHPpfoCGqc87it9FAk84og7eiHrYZR0nUcmeXUdYrcGpIz4A+5ID 7cVAEXwb0z7wdLObf180ptGHtrhmTtMJOYLSOjva3fYYT5jQZM0vZYSGo8dQq2ovp5 4G0gsxRWgyHIREk2+mwCWjD0hmYsYFutawlh5pd7JCr/rKeTfdXyrsI34BbeUW0wkr wbbmJTsRjleyA== Received: by mail-lj1-f176.google.com with SMTP id bx15so3722956ljb.7 for ; Mon, 10 Apr 2023 09:06:20 -0700 (PDT) X-Gm-Message-State: AAQBX9c0jx0uZccr7FQ6Tn1VWeOeSDAGiYO1oRFhN4Mz9DeTf4shB9Hr rwtvzncyQkzICvIdaUVtuOwyXoU0YiRf8QrBBLI= X-Google-Smtp-Source: AKy350ZYTf5+tNtIInJ56xYELpkw807n6pcDQqxLzwYNn5kC/wsk/lyy0ZRj6GpVdiG1eSqStA2SCDFU3pUWbh96/vU= X-Received: by 2002:a2e:b0e2:0:b0:2a5:fe8f:b314 with SMTP id h2-20020a2eb0e2000000b002a5fe8fb314mr2152243ljl.5.1681142778696; Mon, 10 Apr 2023 09:06:18 -0700 (PDT) MIME-Version: 1.0 References: <8b8a3bb2db8c5183ef36c1810f2ac776ac526327.1680172791.git.johannes.thumshirn@wdc.com> In-Reply-To: From: Song Liu Date: Mon, 10 Apr 2023 09:06:06 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 17/19] md: raid1: check if adding pages to resync bio fails To: Johannes Thumshirn Cc: Johannes Thumshirn , Jens Axboe , Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org, Damien Le Moal Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: E8EA780013 X-Stat-Signature: ux8tjdmgf1k64kb86t8mhkbhtjnn4jwu X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1681142782-667622 X-HE-Meta: U2FsdGVkX1+Jku4eHPm58Eqbde75w3aGXOFv6DlCFB+PhuPQQZc8zcexzCr6/XLr0/TosRL/sOrND+9W9JCPiAHj52IfWPdZrwmXJa0FIsKIFDs3YuuZibbAaYMthneldGUAbODitTKe2KSR89EMohg42cImMxFmC/l7xLEjcA/1Xsfel3DQb8/T4Mcb0g8IuDpx9ZfF+DFQHnEX1J9kNRdHA483laTuOTPkOGoXFdysLid2qbZJFNxTYfx7w9F8jl4c0vFPRr1JseI0kfIuJZ6zHpk/0xVAVfhz4fVFL+stoZv5MG+sTl5C8PpYXHoglcmsZ8PMWAPUIom4M/NUICvAwTD0tEsMxhUhmgutTXQBja0/tmPJg9HkBhn7pknSULCCtrgcKUbM0DzOaXCPxp7rpN/pkRNkIrthMsiKtErAj6nemQrIjh43exnk+B704u1bvc3knET1Z0ouMLTuk3x8XXp5FfTSZ+uB+ZV1b92ruRj/Tay1z1V79rpmCOar73DVj81o7mc/UnvWZTiAzQewUAQs9u7ABPz0p7pRGE0DNFIgq2V4SWg6+NqgNZAbRE4LNMytcGxPMWS+D7Wkjf5QqQyMNE2jpXv5ydXl5TrsSpxFRFf8q9yrBc/iZ7QOSbbdUryM/aY/DSEbC/eBPRNBlXFVFmi1aElPVGl5YK1kB28ZbruypMj+27wdANI/C0P7fPjkTT7VzdDY99NK15RCKvTisIrFXDy0HcFc2zDitb+sag+8an+M72idyqHza4P5lK1vdaGm1Sx1vnGpbKldN1+8wNVbL9k0D/0KY2BKRFDbNzQzHnvyAAKu5LVH2WbyoxJOkL+RhrGPReLP1+OLUuvVg51rPxmgwDJR1q00zlsKhLI+YsbuqZiU9sDYx1XOxJqbq3753PiT4VZ2ul/Z4G9OC8a7XoqHITaYP1KYX36wP36XV8uvMDx+O1GdPb+K9tvG1ESvJLpuSmj haVs4+uA igLNp9/x4aJgp0czfZ3N9KQLEYCHGqN+Syd3ly7WPZIOx/AUG4+vRqwM6tYyFbHTJ/lsX+sYilre9lDlBwjvrLNl9phG5C9Yfz4vg+FXUC1WzQW5/1+gYoWzzIfUnnA28FDemHMez0IFzbrU5eOYW8WamBoo08Kfj+CNlcn7BhI4cJYJuQopqX1uIIZ9KXXFxvSV71YZ3py9cgVjh0BOp3cnZDYWTsHeTKkhNg30kIU8r5zUA7+L7yJyIrVo0fvC1Awv6SQP/hLognFUM5lG5raezL1Q2QQB27TkVvhEZI0vMUyvK5lPwsKR2iFldQesOjuGDsHG9yOg2Zsj97lZmcvIA0SEfS27JpfpJC9pzn3w5zbuMklxQoGjOhhD/3r2tm0EJrGcdB3jyrCDHzl3SJjLwiuh26F+ykNk7cPUCUp5icz55JfXUHPzbSlSbXGNpbzVoakwcMi9ht8U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 4, 2023 at 1:26=E2=80=AFAM Johannes Thumshirn = wrote: > > On 31/03/2023 20:13, Song Liu wrote: > > On Thu, Mar 30, 2023 at 3:44=E2=80=AFAM Johannes Thumshirn > > wrote: > >> > >> Check if adding pages to resync bio fails and if bail out. > >> > >> As the comment above suggests this cannot happen, WARN if it actually > >> happens. > >> > >> This way we can mark bio_add_pages as __must_check. > >> > >> Signed-off-by: Johannes Thumshirn > >> Reviewed-by: Damien Le Moal > >> --- > >> drivers/md/raid1-10.c | 7 ++++++- > >> drivers/md/raid10.c | 12 ++++++++++-- > >> 2 files changed, 16 insertions(+), 3 deletions(-) > >> > >> diff --git a/drivers/md/raid1-10.c b/drivers/md/raid1-10.c > >> index e61f6cad4e08..c21b6c168751 100644 > >> --- a/drivers/md/raid1-10.c > >> +++ b/drivers/md/raid1-10.c > >> @@ -105,7 +105,12 @@ static void md_bio_reset_resync_pages(struct bio = *bio, struct resync_pages *rp, > >> * won't fail because the vec table is big > >> * enough to hold all these pages > >> */ > > > > We know these won't fail. Shall we just use __bio_add_page? > > We could yes, but I kind of like the assert() style warning. > But of cause ultimately your call. The assert() style warning is fine. In this case, please remove the "won't fail ..." comments. Thanks, Song