From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68231EB64D7 for ; Fri, 16 Jun 2023 18:14:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CDACF8E0003; Fri, 16 Jun 2023 14:14:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C64A78E0001; Fri, 16 Jun 2023 14:14:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADDAE8E0003; Fri, 16 Jun 2023 14:14:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9A46A8E0001 for ; Fri, 16 Jun 2023 14:14:50 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 76C1916068C for ; Fri, 16 Jun 2023 18:14:50 +0000 (UTC) X-FDA: 80909411940.28.240D3E4 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id 7CEB22000A for ; Fri, 16 Jun 2023 18:14:47 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MRdJy0Rg; spf=pass (imf13.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686939287; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9uOpXtjTJruYQiyrkmcTm61f3LiPVoKJ8SbvEOysloU=; b=7BUX2YhIMMzA7t5Pl7seyOMEk4tqY6gztZvEss1IeBVuV7MJK0AkI1kzm6Ce/j+TrV3wml B0/y3Gbeci/hrUAPbziTIHtEKAq8/yAEXKfP7qmGoekcoDCWFpf4VxzXLiOc3MjzjTsMU2 oFswvHyrxP/pMpwHCsK8/FaCoTxHiQA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686939287; a=rsa-sha256; cv=none; b=Z639GtJJLqwwMwnfNWIIWa4NjpVJGl8wJMkmFRBUCVcwayroQHTMASnrlB+tJ+TZpBsUgY y7Yo9dgh/YJsfbD2MvgxwmTcODIDg+hOqkJVhR3wHBSbjSTTxjtwCRj18rxAerk4LNFVT7 dH6OlrMlxWBtyetf/dcCYZIfSTbGbRs= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MRdJy0Rg; spf=pass (imf13.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5F45462A3B for ; Fri, 16 Jun 2023 18:14:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59A65C43397 for ; Fri, 16 Jun 2023 18:14:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686939285; bh=BGYZV1Km+8ZgDrE9neT/E0fU3u3ixvSh8AYCC3TbmE4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=MRdJy0RgrSJF59KF/EC7N3hN4NM7JkZeq3KagnV0DWy1PIpTqhhanwN+rGe8zgC2V MRnDgp8J0NexGL29v4Mucemw/3yZahpXPMUqiEhZDo6PLZ3uYpYsxd3ZL1fbGvwWwe p/R8vyd2pT+khqUskQVZmRQf+jE0REJ8n2qSSkUm6kasMtDdPJCEzuxpbIe8qI0/Ui gBxANtpHkUielBt2ehqqh3PqnGUAKKbbWba+orljx4X0xezuIPakLsTrSk3Gr6J6ZG 8yTxdvadfsX9qXvWVMaa8ZKkExpaD1sIFaCwY2WSngDPZW1skSPKVqWoP3yaiF1YJ9 Nln3oL3E93qMg== Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-4f7677a94d1so1439659e87.0 for ; Fri, 16 Jun 2023 11:14:45 -0700 (PDT) X-Gm-Message-State: AC+VfDwjZriEjG2eaijtBmg1FXUO9mqWj4cvZjCB7CJfsKiXaSydSek3 1SjGSyN7X/MJIejPEl0eqHfb+7F+i32e1H+6H88= X-Google-Smtp-Source: ACHHUZ76yiO622Uh9+9rKEsm8ImEC4jXzUaBUsNUHgrPnEQ5V1l0GL/PgIuvK/efbFnHaYtpj3eltn1zagg/5cT90Eo= X-Received: by 2002:a19:ab11:0:b0:4f3:bbfe:db4e with SMTP id u17-20020a19ab11000000b004f3bbfedb4emr1747329lfe.56.1686939283176; Fri, 16 Jun 2023 11:14:43 -0700 (PDT) MIME-Version: 1.0 References: <20230616085038.4121892-1-rppt@kernel.org> <20230616085038.4121892-2-rppt@kernel.org> In-Reply-To: <20230616085038.4121892-2-rppt@kernel.org> From: Song Liu Date: Fri, 16 Jun 2023 11:14:31 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 01/12] nios2: define virtual address space for modules To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, Andrew Morton , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Mark Rutland , Michael Ellerman , Nadav Amit , "Naveen N. Rao" , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 7CEB22000A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: e7f7f6yjzcbrdi3ecr6cm7qwksy8ke6i X-HE-Tag: 1686939287-313418 X-HE-Meta: U2FsdGVkX1/HddoRKLg9AMp+Pj7ZhXUYpUVDKP4OIBDwtIkVArZIbIMs/LXHfz4xnP9ZoKL4jdpB24hr0gkd6pXW8L0k/VG3HG7kEWhclW/4LFTLiLhQVVe03B21RkGRd9XiYBS/rTgdy1QBPh3QrfJYbV/7gkz1303TzEkfiz2x9ZIdHmf/Gsr0VoEH5DeiWX0KUlm8i3YRHAnjpa1e3YC8OKcp/LS6uK+IjueZd02v3oAmFzmT379K/EJ1n1PlE940DiRJfzjluCpebt3Cc+W3LA7317wmKavzDwaTutD9n9604DUBwvoE5i5aw+VFL7ambzX+4XnjAdLZIxswWE7xzNv9w06s3NpRAUvWN/lZAZhQBw2u8iPxuRdUDKtOTtIA0CQnPh18+P6Xgu3pE7qwAtxC/OFW8qAJKkcs5vYBQM3cqQ7T8stdP383zIVUHFSv/hERpfysW19rOT4oQO25kcFB7yv55Pq91r8Xt4cSvllzUUwJc2P61N7GAjB4H+v91sXYyl5XoFRUvBSjFzisTza820qnbQQQIPu5nyV90RHcgSOstR/PFSEJFBE7+88nel8ojOQKm4a45wm66OJNNeTA26LGJH/aUuvtldR0WY7OYeHP7AercuDVmWSoCqahHD1WIlh2M+2MfpArvn8Ohwsttwij2py0mbNu77g7ppFjt9t6ESRKn4a5EK+5r8hqoV7FdC+aUPlnIXmuLzGV3oKgFYz1bDVi6ciI3zE5a5lea8zijPfzU42IwE7dODDNcoQo6miW+AUoq5xKo32DON8xJiOThna2OJ/hlbXPxFyhDAEapHpLuqbPI4MjzV0huMfAWaaJ9i9ffQouPUPr+Fc1tKFvS4He3AYbWXoM/QAltXEchdqlEfcUiPmjYgadzQC4hcBP2SwJeQl4PHE5H7ttjwJX92CY/PRurVvcTYDyxB52kiKQzg9Y3JT2N9bbFgtj9HXK15tVW9n DFuwn0DA OWun6lYXfZJ7NkS/W/nWpCPonOrtfhjwao0HUcT2Ljuv3AoesX97K6qTaoQgn4dZH/KHxOA2PzlNF+TU/17gN9NrIaY/ujtguYLVKPERygtO/9gRMcUHBSMDd+TAQhgCZZ2DJH7E0suBUUbgXcz2yMHAaOkW82fKDU1dsJXScj8E+dOWibZg/IOWxhrJmXV3t/SeWTLHahlD6d+zPCR5tv1dWctMZBv9NYxYGkp+9ObB/s/Eh5LjLha3txvpoM3IOed3akKoiZ4gb64oGCCV1z1NHHvwW9MRZ5Rh9v/5Vefwo6/cFvdEG7zJv2ukKuTJKZWTl6eMeyU6juh+amc5v7twi1VqRJBEaxy/vJzxgCmJW9StCjqnKQM7SdTZ3oCv9IxvR2sARoOb34fA9EuIuN6rzCDy5gWHSSXFef8m2FEHQNEMgrPesLC6/DaZ/7ryP0lVCSeQ5eJmJenawFDbYm7GMbM7UY3Mx/MczTVBMJzsVRvU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 16, 2023 at 1:51=E2=80=AFAM Mike Rapoport wro= te: > > From: "Mike Rapoport (IBM)" > > nios2 uses kmalloc() to implement module_alloc() because CALL26/PCREL26 > cannot reach all of vmalloc address space. > > Define module space as 32MiB below the kernel base and switch nios2 to > use vmalloc for module allocations. > > Suggested-by: Thomas Gleixner > Signed-off-by: Mike Rapoport (IBM) > Acked-by: Dinh Nguyen Acked-by: Song Liu > --- > arch/nios2/include/asm/pgtable.h | 5 ++++- > arch/nios2/kernel/module.c | 19 ++++--------------- > 2 files changed, 8 insertions(+), 16 deletions(-) > > diff --git a/arch/nios2/include/asm/pgtable.h b/arch/nios2/include/asm/pg= table.h > index 0f5c2564e9f5..0073b289c6a4 100644 > --- a/arch/nios2/include/asm/pgtable.h > +++ b/arch/nios2/include/asm/pgtable.h > @@ -25,7 +25,10 @@ > #include > > #define VMALLOC_START CONFIG_NIOS2_KERNEL_MMU_REGION_BASE > -#define VMALLOC_END (CONFIG_NIOS2_KERNEL_REGION_BASE - 1) > +#define VMALLOC_END (CONFIG_NIOS2_KERNEL_REGION_BASE - SZ_32M= - 1) > + > +#define MODULES_VADDR (CONFIG_NIOS2_KERNEL_REGION_BASE - SZ_32M= ) > +#define MODULES_END (CONFIG_NIOS2_KERNEL_REGION_BASE - 1) > > struct mm_struct; > > diff --git a/arch/nios2/kernel/module.c b/arch/nios2/kernel/module.c > index 76e0a42d6e36..9c97b7513853 100644 > --- a/arch/nios2/kernel/module.c > +++ b/arch/nios2/kernel/module.c > @@ -21,23 +21,12 @@ > > #include > > -/* > - * Modules should NOT be allocated with kmalloc for (obvious) reasons. > - * But we do it for now to avoid relocation issues. CALL26/PCREL26 canno= t reach > - * from 0x80000000 (vmalloc area) to 0xc00000000 (kernel) (kmalloc retur= ns > - * addresses in 0xc0000000) > - */ > void *module_alloc(unsigned long size) > { > - if (size =3D=3D 0) > - return NULL; > - return kmalloc(size, GFP_KERNEL); > -} > - > -/* Free memory returned from module_alloc */ > -void module_memfree(void *module_region) > -{ > - kfree(module_region); > + return __vmalloc_node_range(size, 1, MODULES_VADDR, MODULES_END, > + GFP_KERNEL, PAGE_KERNEL_EXEC, > + VM_FLUSH_RESET_PERMS, NUMA_NO_NODE, > + __builtin_return_address(0)); > } > > int apply_relocate_add(Elf32_Shdr *sechdrs, const char *strtab, > -- > 2.35.1 >