From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40776C4332F for ; Tue, 15 Nov 2022 22:33:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B86346B0073; Tue, 15 Nov 2022 17:33:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B36626B0074; Tue, 15 Nov 2022 17:33:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FE3B8E0001; Tue, 15 Nov 2022 17:33:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 907446B0073 for ; Tue, 15 Nov 2022 17:33:05 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 66F364046D for ; Tue, 15 Nov 2022 22:33:05 +0000 (UTC) X-FDA: 80137128330.10.6FECB5D Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf01.hostedemail.com (Postfix) with ESMTP id 25DFF40005 for ; Tue, 15 Nov 2022 22:33:01 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0A98DB81A1C for ; Tue, 15 Nov 2022 22:33:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31694C433B5 for ; Tue, 15 Nov 2022 22:32:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668551578; bh=AkFiT/OCoW830kzddjiNwqOI+WNjgdwDG9nzrCLJXFo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ACdA922TAkKdIEjsll5lT04CRLuFn0MgAextSqEDs9P7SItqXpgjmk7fl2D7Vk4ZI BBTUQHm+N7v1CJvCI0hAhFg56jOQXn5IVqDswuLQspK6+j22/RqNwfkJJxV3t9UCWX KKyIyFLK30qnvY2xazf8lIHY8Xx5epgPnOdltdEoBLBAPD4Q4YawWXJZumesPAgP1l a3DZIuVcWjm3ZSLQcJzOk0N3WOeuG6TRO4OBoxES2VpEtNWhbSVN+sGu/RTxaqp1Gj gf0g4v/yHUsW44O4mSxlKacfSmugZ5/TDkS5hh5hvf7sIgdIHdqW3DSQWgX+v1FhMP rG9WEs7271A5w== Received: by mail-ej1-f52.google.com with SMTP id bj12so39718194ejb.13 for ; Tue, 15 Nov 2022 14:32:58 -0800 (PST) X-Gm-Message-State: ANoB5pkkEZgsT5y0JjrWkAFV4WSSZppGXpvwkTFVtUL2koyIHnfGq3Tp KPJqqS+XDZRBuqHAd1gno6DB6F/RWz/1vgag8c0= X-Google-Smtp-Source: AA0mqf7UaOz/LbZTdRJi0rcR1w/zTRJUIJyUUCN1a3JNq/Z2U5hZCJO1WhldHiA+tUTuKdalVa4rQnMIuFT3Hd7M31M= X-Received: by 2002:a17:906:ad98:b0:7a1:e4c2:fb0a with SMTP id la24-20020a170906ad9800b007a1e4c2fb0amr16070128ejb.101.1668551576384; Tue, 15 Nov 2022 14:32:56 -0800 (PST) MIME-Version: 1.0 References: <20221107223921.3451913-1-song@kernel.org> <4bf1a1377ea39f287a4fd438d81f314d261f7d7f.camel@intel.com> In-Reply-To: <4bf1a1377ea39f287a4fd438d81f314d261f7d7f.camel@intel.com> From: Song Liu Date: Tue, 15 Nov 2022 14:32:43 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH bpf-next v2 0/5] execmem_alloc for BPF programs To: "Edgecombe, Rick P" Cc: "peterz@infradead.org" , "rppt@kernel.org" , "bpf@vger.kernel.org" , "linux-mm@kvack.org" , "hch@lst.de" , "x86@kernel.org" , "akpm@linux-foundation.org" , "mcgrof@kernel.org" , "Lu, Aaron" Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668551582; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AkFiT/OCoW830kzddjiNwqOI+WNjgdwDG9nzrCLJXFo=; b=7pX9+dWhuZq/lKYz8exgwZiA8uSI+BuWduix507UN6f3XiT8VweZYoMijyfyhQTJcXo/jI YNiVt+8sdIXbTAg+Myy9wd2kjWh/vj1RE/Rk+gO0SJys4oSlgNRFsRXugEDjFK/xuhDDjr 6T3pdP6GKgDKaacT9LggFXgeuLU2WfQ= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ACdA922T; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of song@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668551582; a=rsa-sha256; cv=none; b=EkCD5L3bvUGt0euiQ4vHXByocYhzLUoQREON577rRyvlQKiYnye9OjxnhOe+YkxefLS+Xu L/UGiFGQKRvERAAXByC8Q7PSn+ox4EPINP9/OdL9HHrX73mSo3F+IK2uQqEfhoSj8ssI5r gBXc1JjyNRb7aBUcUJCzgkpmh5keRU0= X-Rspam-User: X-Stat-Signature: bgtqhwmebw4exetibc4x8eywwo7ux5r7 X-Rspamd-Queue-Id: 25DFF40005 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ACdA922T; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of song@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=song@kernel.org X-Rspamd-Server: rspam07 X-HE-Tag: 1668551581-762708 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 15, 2022 at 2:14 PM Edgecombe, Rick P wrote: > > On Tue, 2022-11-15 at 13:54 -0800, Song Liu wrote: > > On Tue, Nov 15, 2022 at 9:34 AM Edgecombe, Rick P > > wrote: > > > > > > On Mon, 2022-11-14 at 17:30 -0800, Song Liu wrote: > > > > Currently, I have got the following action items for v3: > > > > 1. Add unify API to allocate text memory to motivation; > > > > 2. Update Documentation/x86/x86_64/mm.rst; > > > > 3. Allow none PMD_SIZE allocation for powerpc. > > > > > > So what do we think about supporting the fallback mechanism for the > > > first version, like: > > > > > > > https://lore.kernel.org/all/9e59a4e8b6f071cf380b9843cdf1e9160f798255.camel@intel.com/ > > > > > > It helps the (1) story by actually being usable by non-text_poke() > > > architectures. > > > > I personally think this might be a good idea. We will need this when > > we use > > execmem_alloc for modules. But I haven't got a chance to look at > > module code in > > great detail. I was thinking of adding this logic with changes in > > module code. > > BPF used to have a generic allocator that just called module_alloc(). > If you had a fallback method could you unify all of BPF to use > execmem()? Yes, we can use execmem as the unified API for all BPF JIT engines. Song