From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6321C4332F for ; Tue, 22 Nov 2022 02:36:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 13F366B0071; Mon, 21 Nov 2022 21:36:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0EECA6B0073; Mon, 21 Nov 2022 21:36:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F20878E0001; Mon, 21 Nov 2022 21:36:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E2E716B0071 for ; Mon, 21 Nov 2022 21:36:38 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B820A80249 for ; Tue, 22 Nov 2022 02:36:38 +0000 (UTC) X-FDA: 80159514876.16.42510A9 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf18.hostedemail.com (Postfix) with ESMTP id 3D7F71C000B for ; Tue, 22 Nov 2022 02:36:38 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B5504B81601 for ; Tue, 22 Nov 2022 02:36:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53535C43470 for ; Tue, 22 Nov 2022 02:36:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669084595; bh=4HRkze2p1dS+fcP8t8HSF/4QK8O7VUQBHu+nh1jzLUE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=iRntpO6J+p2JwdqCr3cd/wbLuB9QKSCVQ1ZlGbfoi5GGyd2j2omaeIxXtcME729eR URBXOcxLCpC2GmBnx1JIy54UYmtQD9P+gmMYTw1wqgf+iBfQqzyb47lVCn08fHNO6+ o3NAPd07Wq18hYbtO+wA6FXBllPGFVaC07BAy0LEOINf436JJ7c5ulr4EgEqysbbZ1 PXC0QFa+hQvOzXvcBCwUNOxuimUYbqOdAqnnaOEcskMOi1euo2/OO8cY3AXBOxRGdt Iyf1+ihH8tYlbKaJC+8zIkeDhAAJooMzWsoFQ2U0sY3kvmZRrBZZUEkitT92IYG0v1 g4wQHBnAtlSrA== Received: by mail-ed1-f53.google.com with SMTP id x2so18817884edd.2 for ; Mon, 21 Nov 2022 18:36:35 -0800 (PST) X-Gm-Message-State: ANoB5pkrtD/uejGZrQrIKtLBTJOKSRBOyOLyEPxH42QTAdqBAdMZF6tK BvCS2JV5TZjVx6h3s+H19TLO1M3hXL+JaU9H49w= X-Google-Smtp-Source: AA0mqf5WsFPLU1rP7tNZ8kJ+tQtOPjEJmV5ye9QanQG+tpT/1VWYmaM1RFMIlKJ7VKQ+tjcGyBpXByzqfTCMSsveosE= X-Received: by 2002:aa7:cd91:0:b0:469:2f36:fd with SMTP id x17-20020aa7cd91000000b004692f3600fdmr4897293edv.385.1669084593490; Mon, 21 Nov 2022 18:36:33 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Song Liu Date: Mon, 21 Nov 2022 19:36:21 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH bpf-next v4 0/6] execmem_alloc for BPF programs To: Luis Chamberlain Cc: Linus Torvalds , bpf@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, x86@kernel.org, peterz@infradead.org, hch@lst.de, rick.p.edgecombe@intel.com, rppt@kernel.org, willy@infradead.org, dave@stgolabs.net, a.manzanares@samsung.com Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=iRntpO6J; spf=pass (imf18.hostedemail.com: domain of song@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=song@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669084598; a=rsa-sha256; cv=none; b=Ek1r6AzC1eWgL0J5C5CFYi4xULRMhcm8S1q+O+xFbmP8YbtgTVO5/t6X+NGrX7soHVe58Y G28q3/+7i8dmaEiiQK/J8Cygtd7kwYDf2A++4whdt6eWjBiEz0hz6mUxcr/uHogInybhH/ 3mdDbP6mHgnkmmu0vkuMCH0UWrDY6b0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669084598; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4HRkze2p1dS+fcP8t8HSF/4QK8O7VUQBHu+nh1jzLUE=; b=q4aOo/Lwu2GoAVgwBYw6GbURVyZeR1JSFuspChqjt46lkTcbaeTUzaOxX1bZ3Nc8aDGoVb p51jcq4eOByap5u97lM08q1utIHarhwp4YrMKIrjQvOq3YfY2Mq0enPCK20/M7fGKKU96X QjQ+Yg2tNeo+dJnBtqbmxYfwSUeBySo= X-Rspam-User: Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=iRntpO6J; spf=pass (imf18.hostedemail.com: domain of song@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=song@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Stat-Signature: t8ng4g3twpqmxdtr4uo3t7yrhhdo56wb X-Rspamd-Queue-Id: 3D7F71C000B X-Rspamd-Server: rspam09 X-HE-Tag: 1669084597-738018 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 21, 2022 at 1:20 PM Luis Chamberlain wrote: > > On Mon, Nov 21, 2022 at 12:12:49PM -0800, Luis Chamberlain wrote: > > On Thu, Nov 17, 2022 at 12:23:16PM -0800, Song Liu wrote: > > > Based on our experiments [5], we measured ~0.6% performance improvement > > > from bpf_prog_pack. This patchset further boosts the improvement to ~0.8%. > > > > I'd prefer we leave out arbitrary performance data, as it does not help much. > > I'd like to clarify what I mean by this, as Linus has suggested before, you are > missing the opportunity to present "actual numbers on real loads. (not > some artificial benchmark)" > > [0] https://lkml.kernel.org/r/CAHk-=wiF1KnM1_paB3jCONR9Mh1D_RCsnXKBau1K7XLG-mwwTQ@mail.gmail.com Unless I made some serious mistakes, Linus' concern with performance was addressed by the exact performance results above. [5] Thanks, Song [5] https://lore.kernel.org/bpf/20220707223546.4124919-1-song@kernel.org/