From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3C05CD4F41 for ; Fri, 22 Sep 2023 08:55:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2DB546B029E; Fri, 22 Sep 2023 04:55:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 28A7F6B029F; Fri, 22 Sep 2023 04:55:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17A576B02A0; Fri, 22 Sep 2023 04:55:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 090626B029E for ; Fri, 22 Sep 2023 04:55:48 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CCA438066D for ; Fri, 22 Sep 2023 08:55:47 +0000 (UTC) X-FDA: 81263625534.30.A3F7823 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id D7E59C0008 for ; Fri, 22 Sep 2023 08:55:45 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=V+Q+E5qj; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf28.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695372946; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cD7XUg298xVjGqeR1Ug2Ktt8gpiErOYhno/n1pb06F8=; b=jE7jmNNooovXS46fiVL8/eBnJRJaNAbc/KK2YDXb2FgKyBKejng7F51FklkRF6EoVNAuTK IuIrBQbJWOy7J2KEr+lmKvgIHy+W6ACD2WbhxYva1C+WH67vrDxHTOPUyLtwS83FnP7/dI j9Vv4dRVKtvNgwCvx85Y+N4XBEiCuLE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=V+Q+E5qj; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf28.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695372946; a=rsa-sha256; cv=none; b=m/41I2NIDiGQnfetvN0IlBqyfQ7EVTr+ScDH68YRbKqM9+RLuQXYBJosX2MnR98tBe0Fy3 WfKzkB/mAA35+arNJq0vS5zHEryadhAz+FKNCjClKnEH4anXvKfqkbMlfSrcMyquhhRrd1 ypTDzoi291UXVUJs0xiotKqBp3JRFmE= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E921F620F0 for ; Fri, 22 Sep 2023 08:55:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB242C433AB for ; Fri, 22 Sep 2023 08:55:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695372944; bh=8QkGhwghTGYPhExKboS3z0PsUiDKGGvXCleAsd5SH5o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=V+Q+E5qjNDNndg1QOHtMiKdV8gxc5YPd5vtFni/5Af07h5+KW/FuttOuLEz7XL89v 8vHHXggT71jOLcmwXxi7N6rv1FSSLnhzlwX01RijMPv607eO4NVjyjCHTdM/S1JxBE mmhZ436n7vXwrdLHfq67qQVihUSnknt9DBRTHSeqPRPYetytUSQfrFEhOVPitVfhcX MWySWbbqpJjvmhv7PhgQCCKAVAhRIet3+KYmhYpQ8FhDvNZpR+iKGKCf4MbhOMM6S6 DbNl4WSkKfu25jX++5VTzQYwGbDQg+WP8gwQWCTkgxyV4QhsnctYS/uJ/QD1ZBPkVN Xeoz/YJkoemfg== Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-50317080342so3221265e87.2 for ; Fri, 22 Sep 2023 01:55:43 -0700 (PDT) X-Gm-Message-State: AOJu0YwOD4aIpYgCruQBx+1AS4IzqdF7VRY5h65YbvLS/vcGIs21dc93 9s3JioGaZbp3DAPmwk2OWU0+8Vzb4LdO7W4bL30= X-Google-Smtp-Source: AGHT+IF8cgUepodrWyUy99Ge6z4o9GbKwpmdAjZ3R33ypUsIeilkKxYeO+uhK8l2iNZFEKGHs3hnsEm9jfUciGjro48= X-Received: by 2002:ac2:5bc5:0:b0:503:79e:fb7b with SMTP id u5-20020ac25bc5000000b00503079efb7bmr6817575lfn.68.1695372941964; Fri, 22 Sep 2023 01:55:41 -0700 (PDT) MIME-Version: 1.0 References: <20230918072955.2507221-1-rppt@kernel.org> <20230918072955.2507221-7-rppt@kernel.org> <9b73ad3d-cfda-bce5-2589-e8674a58c827@csgroup.eu> In-Reply-To: <9b73ad3d-cfda-bce5-2589-e8674a58c827@csgroup.eu> From: Song Liu Date: Fri, 22 Sep 2023 01:55:29 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 06/13] mm/execmem: introduce execmem_data_alloc() To: Christophe Leroy Cc: Mike Rapoport , "linux-kernel@vger.kernel.org" , Andrew Morton , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Catalin Marinas , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Mark Rutland , Michael Ellerman , Nadav Amit , "Naveen N. Rao" , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , "bpf@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mips@vger.kernel.org" , "linux-mm@kvack.org" , "linux-modules@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "linux-trace-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "loongarch@lists.linux.dev" , "netdev@vger.kernel.org" , "sparclinux@vger.kernel.org" , "x86@kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D7E59C0008 X-Stat-Signature: spwuik7isnpodtkcyw6s88phqnjmcu7m X-Rspam-User: X-HE-Tag: 1695372945-721887 X-HE-Meta: U2FsdGVkX189ZELA+NEWL4P1fzAueenaFi40bQMSZWvBPA7ZW3kjp4gEtxICavyYsXeaylDYUhhki0t8XnWLP3xqTqo7E1EHRJ4Jf1gN07/GSFRVlVRdC0FH1FfwG2f2xhJ1Ks1HpC6z5lNtZLPkFUu3Ae7gU2y3iU0b0kB1Tv8OUORBJ4kjXrIlFFuLF3cSpt1u9HFAcOvM/TpmwOFlhC26jvt7NV5bkrc6+PqSVyDlRiFR8Y34FWtscxIPPY8yRcORwufBH5CtPfFQOUFBvwTYzgSXciGdVGbTSL0Vfb1wzu8d44KGMMsUnsCoEMbNUk0UeiQAuV44pNDY25ss6udSnRiBWs3lNkhX3rp6o7yS279sl44mY1DDvRRhCzsSoGzxilRrOg2lFoWUx6tBkpLWMX8SoMNdJS+ULVFY+dt0Yq9J/T7285P4//5ct4izOvx0TBEBlj805Zyk1/8yP8o+Ce2pFgN8m3LRjDkm5wYNTCUuO++Stn6uYx61d+j0ScZnEUkC0R6ZsYAWj35963duLj1ffeYJYfh17ihmO5YyOrc7GyZww8x/Pc60JH+/SmH7Kj+utlMKNKjSe1EAJYdfnqt6yvhpPr3zlFE+n/l+J04H3r2+LYD64cFgDLZjysseegO3DIB9AQrWW/Z4dSp0t1DmhcTITrhvFU0aKretOKDeYiX6k+MaS/IiTUHlOcZA5V7bGyii89sqC6QlVz2Kb5Fb6KV8B6kPbmLeGQUfjRDnXoq3GmqCncbPdMMezYqgHuCuZRZVtVrWrjfNbcQc/1VUMTX9GP4QMObU9l7QGyIWUs75f2FRE3CpvtKeCi4dtnjUePngVRYPmZCM0MMxURL6Zf6N8tEEGK4vJ1ezcQ1jfUG9iJQXidwmJVbiWpOlOw+ljELeUaiF6Lc79yE+NpKlnar1g64ZI01OTfsRDZbfvpQKPBVsWAKSw9ipDYBBai/eniOcF2qbG7j IFLHBx02 Uojm78ocj/goaiMlPBG3xusdyirg6w6Yg1XUhj6gaZZs2X8aEqxco1tsx/odZX1KepzDzbsqp14SRa9gsTn/GfbaIwHm9id7fi1srdhb1bljGw8puhv7geT9UV+xI2tOelLpg+Tb9tgGAnXzzQ8k/HzwPufgpqhExsUJGPcmzcKQ1zd2KPXlk7Hr0csD8G9U4dEaFNFVMKOmZdI93WYXoQ2jurqK+uEBfOWqLE3raQBcTNHJ9Tl7wIcdlm6JIaC2T7zaK0YRYmE4MZV3GU31BPqQxypdz8Gge6AeQi8YLWiK6t3NMhqvMjD0etL5qBVs5ip4Z8+e3x5vX1kXRJkkQRciX/tZt5DUEeDA1GU9uSiX6RbH4ZnbZeO/VFFmJBC6Lw4rgRqq6cOfbSrXNAZlNDNzfNR3S2Cn2QSE7vmYbbrfzVEa3ASKhLGmMsqd1K/tOI4gqJAuKMh7KOVJOFzRpSKDXJOOYeZUFT1tW5rnK+YgpScEvW88JV/KJ+oPrdM+XY6cycD6+ktB2UCXq+6Z8x1d3pp2snqQbQctjIVtU5uVhzTEM+eZZrLyUAtR4NldNM6Y8LbFlGESgT80AH18FyTKIrw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 22, 2023 at 12:17=E2=80=AFAM Christophe Leroy wrote: > > > > Le 22/09/2023 =C3=A0 00:52, Song Liu a =C3=A9crit : > > On Mon, Sep 18, 2023 at 12:31=E2=80=AFAM Mike Rapoport wrote: > >> > > [...] > >> diff --git a/include/linux/execmem.h b/include/linux/execmem.h > >> index 519bdfdca595..09d45ac786e9 100644 > >> --- a/include/linux/execmem.h > >> +++ b/include/linux/execmem.h > >> @@ -29,6 +29,7 @@ > >> * @EXECMEM_KPROBES: parameters for kprobes > >> * @EXECMEM_FTRACE: parameters for ftrace > >> * @EXECMEM_BPF: parameters for BPF > >> + * @EXECMEM_MODULE_DATA: parameters for module data sections > >> * @EXECMEM_TYPE_MAX: > >> */ > >> enum execmem_type { > >> @@ -37,6 +38,7 @@ enum execmem_type { > >> EXECMEM_KPROBES, > >> EXECMEM_FTRACE, > > > > In longer term, I think we can improve the JITed code and merge > > kprobe/ftrace/bpf. to use the same ranges. Also, do we need special > > setting for FTRACE? If not, let's just remove it. > > How can we do that ? Some platforms like powerpc require executable > memory for BPF and non-exec mem for KPROBE so it can't be in the same > area/ranges. Hmm... non-exec mem for kprobes? if (strict_module_rwx_enabled()) execmem_params.ranges[EXECMEM_KPROBES].pgprot =3D PAGE_KERNE= L_ROX; else execmem_params.ranges[EXECMEM_KPROBES].pgprot =3D PAGE_KERNE= L_EXEC; Do you mean the latter case? Thanks, Song