From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A2ECC433FE for ; Thu, 30 Sep 2021 03:26:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E07F86138F for ; Thu, 30 Sep 2021 03:26:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E07F86138F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 5DE9E94007E; Wed, 29 Sep 2021 23:26:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 58ECF94003A; Wed, 29 Sep 2021 23:26:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47D4C94007E; Wed, 29 Sep 2021 23:26:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0254.hostedemail.com [216.40.44.254]) by kanga.kvack.org (Postfix) with ESMTP id 38E9694003A for ; Wed, 29 Sep 2021 23:26:56 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C61D93262C for ; Thu, 30 Sep 2021 03:26:55 +0000 (UTC) X-FDA: 78642803190.16.0E209C7 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf25.hostedemail.com (Postfix) with ESMTP id 6036DB00019A for ; Thu, 30 Sep 2021 03:26:55 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id D853A6138F for ; Thu, 30 Sep 2021 03:26:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632972412; bh=I4z0jgacNAuh06Bh+oxZt59cjKqg+PlYy5urAT22o0k=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=TeGZKIHAJNz3jgzVj/i0CltXQp1Bdrq3gWYhmJOGPlK9vNd1U+/Y/npeDL+NwW8+h BXFp4tv622+l/gCQWElEnDwM68WWnCvU2jP461sJkF8V85JLf9Ce3JqOAfYc3G8gfP ImX7uucyZB0Hgu1AOr9DSqXcsGKuFKk0tjZQ6+8KuK2Df8DphlXna+jsOzN39WNjRF +Ol8hjxIFSiW8oIUBGgwSkgPLjXyqS5MmEfoqad9POJrrOZhkMXXnwxKruj6NH0U9R 0RtKvQgzxuCR7ddEMBVTKFM2AyXQnRuASY0I5+RQjLtuy/Hiq4f/IsmiTYbYtiADZE ncHwt8Cqx4RhA== Received: by mail-lf1-f42.google.com with SMTP id i19so16333895lfu.0 for ; Wed, 29 Sep 2021 20:26:52 -0700 (PDT) X-Gm-Message-State: AOAM530ZGn4ae4aoCwP3j1Dg5xv5oMkqG5Gee8A9qEv8+GHNjKHNzKyb BO/mTzVNA9BHiXdmGHb7Nse1wbrY0xz0Jkk57Hs= X-Google-Smtp-Source: ABdhPJwpejn8FAR7vsvfC7SQQeqcVV1JyATYNrR+Sps8xAYid1zrY8yfD/YurR4bsK4tClFzJ73alIK+oQghBMme61Y= X-Received: by 2002:ac2:5182:: with SMTP id u2mr3286881lfi.676.1632972411232; Wed, 29 Sep 2021 20:26:51 -0700 (PDT) MIME-Version: 1.0 References: <20210922070645.47345-2-rongwei.wang@linux.alibaba.com> <20210923194343.ca0f29e1c4d361170343a6f2@linux-foundation.org> <9e41661d-9919-d556-8c49-610dae157553@linux.alibaba.com> <68737431-01d2-e6e3-5131-7d7c731e49ae@linux.alibaba.com> <67906bf5-4de9-8433-3d70-cc8fc5cc2347@linux.alibaba.com> In-Reply-To: <67906bf5-4de9-8433-3d70-cc8fc5cc2347@linux.alibaba.com> From: Song Liu Date: Wed, 29 Sep 2021 20:26:40 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/2] mm, thp: check page mapping when truncating page cache To: Rongwei Wang Cc: Matthew Wilcox , Andrew Morton , Linux MM , Linux Kernel Mailing List , William Kucharski , Hugh Dickins Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 6036DB00019A X-Stat-Signature: 3szkm4q1jtn4x8h43wxk43hmwu7de6ns Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TeGZKIHA; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of song@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=song@kernel.org X-HE-Tag: 1632972415-901645 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 29, 2021 at 6:54 PM Rongwei Wang wrote: > > > > On 9/30/21 7:41 AM, Song Liu wrote: > > On Wed, Sep 29, 2021 at 10:56 AM Matthew Wilcox wrote: > >> > > [...] > >>> Now, I am able to crash the system on > >>> find_lock_entries () { > >>> ... > >>> VM_BUG_ON_PAGE(page->index != xas.xa_index, page); > >>> } > >>> I guess it is related. I will test more. > >> > >> That's a bogus VM_BUG_ON. I have a patch in my tree to delete it. > >> Andrew has it too, but for some reason, he hasn't sent it on to Linus. > >> > >> +++ b/mm/filemap.c > >> @@ -2093,7 +2093,6 @@ unsigned find_lock_entries(struct address_space *mapping, pgoff_t start, > >> if (!xa_is_value(page)) { > >> if (page->index < start) > >> goto put; > >> - VM_BUG_ON_PAGE(page->index != xas.xa_index, page); > >> if (page->index + thp_nr_pages(page) - 1 > end) > >> goto put; > >> if (!trylock_page(page)) > > > > Yes, after removing this line, I am able to see the same bug. > > > > Here is my finding so far: > > > > The issue is NOT caused by concurrent khugepaged:collapse_file() and > > truncate_pagecache(inode, 0). With some printks, we can see a clear > > time gap (>2 second ) between collapse_file() finishes, and > > truncate_pagecache() (which crashes soon). Therefore, my earlier > > suggestion that adds deny_write_access() to collapse_file() does NOT > > work. > > > > The crash is actually caused by concurrent truncate_pagecache(inode, 0). > > If I change the number of write thread in stress_madvise_dso.c to one, > > (IOW, one thread_read and one thread_write), I cannot reproduce the > > crash anymore. > Whether CONFIG_DEBUG_VM is enabled in your vm? > > I think the second possibility mentioned above will been found if you > enable CONFIG_DEBUG_VM: > > 1) multiple writers truncate the same page cache concurrently; > 2) collapse_file rolls back when writer truncates the page cache; > > The following log will be print after enable CONFIG_DEBUG_VM: > > [22216.789904] do_idle+0xb4/0x104 > [22216.789906] cpu_startup_entry+0x34/0x9c > [22216.790144] Hardware name: Alibaba Cloud Alibaba Cloud ECS, BIOS > 0.0.0 02/06/2015 > [22216.790553] secondary_start_kernel+0x104/0x180 > [22216.790778] Call trace: > [22216.791300] Code: d4210000 b0006161 910d4021 94013b45 (d4210000) > [22216.791662] dump_backtrace+0x0/0x1ec > [22216.791664] show_stack+0x24/0x30 > [22216.791956] ---[ end trace dc769a61c1af087b ]--- > [22216.792295] dump_stack+0xd0/0x128 > [22216.792299] bad_page+0xe4/0x110 > [22216.792579] Kernel panic - not syncing: Oops - BUG: Fatal exception > in interrupt > [22216.792937] check_free_page_bad+0x84/0x90 > [22216.792940] free_pcp_prepare+0x1fc/0x21c > [22216.793253] SMP: stopping secondary CPUs > [22216.793525] free_unref_page+0x2c/0xec > [22216.805537] __put_page+0x60/0x70 > [22216.805931] collapse_file+0xdc8/0x12f0 > [22216.806385] khugepaged_scan_file+0x2dc/0x37c > [22216.806900] khugepaged_scan_mm_slot+0x2e0/0x380 > [22216.807450] khugepaged_do_scan+0x2dc/0x2fc > [22216.807946] khugepaged+0x38/0x100 > [22216.808342] kthread+0x11c/0x120 > [22216.808735] Kernel Offset: disabled > [22216.809153] CPU features: 0x0040002,62208238 > [22216.809681] Memory Limit: none > [22216.813477] Starting crashdump kernel... > > So I think the race also exists between collapse_file and > truncate_pagecache. I do have CONFIG_DEBUG_VM, but I haven't hit this issue yet. Thanks, Song