From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCB59C54798 for ; Thu, 7 Mar 2024 23:00:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10FC76B02D7; Thu, 7 Mar 2024 18:00:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 04A5D6B02D8; Thu, 7 Mar 2024 18:00:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2C7B6B02D9; Thu, 7 Mar 2024 18:00:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C58366B02D7 for ; Thu, 7 Mar 2024 18:00:49 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7BBD61C08A6 for ; Thu, 7 Mar 2024 23:00:49 +0000 (UTC) X-FDA: 81871764618.09.01F7431 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id B05BB10001B for ; Thu, 7 Mar 2024 23:00:47 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tXeuew1Y; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709852447; a=rsa-sha256; cv=none; b=htqlSNXFZ7qlcZ6dK5p/+S8+7fEQQYJ+wYOcmfV9FuBgPI5y59DyCbAJy+w+0LWAITqrs4 QJ2HzhXReBMnlrbFneIOJCKO7pRlerLyKHMev9ABiC7EnGMPwqvJpa4T4vLeKlspHrc4UC pjHPBSmKmq3gFIXJYk2ZtXnwDX+QCEk= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tXeuew1Y; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709852447; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OqyY5r4e3MHgjs6fEw/5nTLOQylYO8Mxuqtge/IuOM4=; b=1H5SjSvidVkLE2nZYKjGbIdkCcUcFidkXYBeEi/Ou5R+o7qPFVWzpkZDoSZLqUphkCndAF YWW9KRfYNo3fc4aLLvifuAfTykf3cJ/wXXPqANq1X6ccnQLZqvVgfBSR9Faf9z6Geo9rk+ 2sRWOBKdYFqPj5ILfA7ht2navd6l1o4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8EE2361D51 for ; Thu, 7 Mar 2024 23:00:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECEA0C433A6 for ; Thu, 7 Mar 2024 23:00:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709852446; bh=0BNRnFKrPmqb8JaQMgFhNaR+/YfUrRcBITV+UhUg3ek=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=tXeuew1YyJIEz+oDjmSV0cwsFcBuHVY23U1kIUAqIZhkGDqLAQ0oxrLIR+iItj9SW yW78XbjssAiVqZ1/WCvzByCaa531nWXw9ZZz/dXHX1FuPvQCM636NnLT4ancOxU+9q zlJQU3JV5YUccyXPDosO1BR/S6606xjMIoiNZzG+KGaifOFoPWFPojN1UbPVn9AuXU vmJmrr/hjbutmQGTFFlUuCfpV+fzZ/LOOL3bsxA5gJSLMO71mGxb6Slr1CGm2oHkI7 q8zRGDgCtu5uJwjVr+i9IAmd6CL667ZbC2yl2I6byx7E9XeAdk0D2AdoMt0o3WjMuD D2Inyft1wyrew== Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2d3fb16f1a9so26036781fa.0 for ; Thu, 07 Mar 2024 15:00:45 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWEJchfhXGHizjca5Km1Cni5ZBqDq8Zgxtsr7VZPoioapAvyNwUx17LNTvTdHFDHn5ly2EMFXKCPuwf0+J3sQ1ZPTA= X-Gm-Message-State: AOJu0Yyy9Ko0LunAt2zzlk8G07UTklFnn+32c5ysvs5ZrkuuqhyzFkR4 8BVRA/aLDa/pNladiaoUGjuTshF6mH4l4rc4AeuTFq/gA6CoGtLNwtScUEGY5qJEte2Ay+B9FQz xsoA5Kx9ZyEdquv+RS6dISz53vpA= X-Google-Smtp-Source: AGHT+IHIvKBLMm2DYDZH0mQVeIadMl7yshOMcUdRiFEkU3IcF/jRIDNEu423eBEh/eV/YsvR3ATkeFr1xweFEoLngSE= X-Received: by 2002:a05:6512:616:b0:513:2508:d2f with SMTP id b22-20020a056512061600b0051325080d2fmr1107647lfe.12.1709852443920; Thu, 07 Mar 2024 15:00:43 -0800 (PST) MIME-Version: 1.0 References: <65e9e748.a70a0220.606f7.53c0@mx.google.com> <7e216c88-77ee-47b8-becc-a0f780868d3c@sirena.org.uk> <4ce67bde-3bd4-4a59-bce7-4a2764445783@sirena.org.uk> In-Reply-To: From: Song Liu Date: Thu, 7 Mar 2024 15:00:32 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: next/master bisection: baseline.login on qemu_arm64-virt-gicv3-uefi To: Puranjay Mohan Cc: Mark Brown , Catalin Marinas , Alexei Starovoitov , Will Deacon , kernelci-results@groups.io, bot@kernelci.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, bpf@vger.kernel.org, linux-next@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B05BB10001B X-Stat-Signature: 3kixygjkxisb1s8mw514zzqa7mgzxdcr X-HE-Tag: 1709852447-953556 X-HE-Meta: U2FsdGVkX1823xKC096duhnw2tCdeu1OKBtAj+o/njO5hx3Wp/tbUWRTkI58VpuvcZuOVvq+jqaUe9+EHQE0Km8HSEsZVVVLrMlawU9B9BAIFvmJk8/VAgio2UPKgilskeK8naK9XMx0YW4RYhRLP0vKoi2occWeURH0SI441q64rADL+OnNOWKqeBEwIsOIPfTx8gcSQZNJxbZr66b47mn8+4KAGxQpp5LDSqVHvSukqrEfJqvp3+puOkgfp6MvYVAWz3ATImSwjcz9RjPkFhQN+5XUW7BLHvV13HMwBorbOZOolzzOOHAxVGVTJcVyb0VN3jRfZjcVQOS79U6O/E5dhMOWh75LMmqfvJjI3bWuiBAi1EwVx7YP2Q6SlFZ8rTF5bWTePJdpltKrYGHv6VSE7gJFdNHtw9M7RHKeKQD0aiYA4mCmVSDRnKJTZ3yDvv40UQqEZiPwQSIJmoIiwb5EWCJXoyPPj1NQ6RIhriKKj8Qpqo/Dc5ppqDBxp1qtN+zOzwtuNLq26ayTzkWRuuWD9vnJuzz+rv5q2N83NilThUs91fekPnnNqNY0dvgAtwTeHpr0PvNG29z0Tj3oGvi6y1xaCYG768dktT9iBYkpQjzZS3Kpd/jx/ZW/Ju9Txyh4mhWnnzNK7qE1I3sldQeMd8aUyi6/StkUe9dlsjsWULvJdCej4qMwsErBhU1lbk/ELBGLHfumM1zc/1TrzV+gvH6VNSb6wV+EXR4KbLrraVxqUfcDy6EVnXYSyjvnmliDsi1QYKD4pbluuoHW/BS66sIgaSjg5gajk8dD2yY6dxP9FrD1b8JBKuoywh2/mC5vrf1F0sKdKbkalmUXOWxg/Pxlx33/3zg4OzUsLaTT9pnTQ9KGAWh5//05K0xrD3rYbhy13hTFKjCPxeXLgrpdeYyNZDR7cKXWTwzDckDvrdqJ+emo4ABexwtaXaFPZJaLn6sSLcj9hQc9jCF 7Fg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 7, 2024 at 11:02=E2=80=AFAM Puranjay Mohan wrote: > > On Thu, Mar 7, 2024 at 7:34=E2=80=AFPM Mark Brown wr= ote: > > > > On Thu, Mar 07, 2024 at 10:16:21AM -0800, Song Liu wrote: > > > On Thu, Mar 7, 2024 at 8:36=E2=80=AFAM Mark Brown wrote: > > > > > > The KernelCI bisection bot found a boot regression n today's -next = on > > > > qemu arm64 UEFI platforms with 64K pages which was bisected to comm= it > > > > 1dad391daef1 ("bpf, arm64: use bpf_prog_pack for memory management"= ). > > > > We OOM quite early in boot: > > > > > IIUC, 64kB pages means 512MB PMD. I think that's indeed too big. We > > > will need some logic to limit such cases. > > As far as I understand, we need the prog pack to be PMD sized so it is > allocated as a huge page > and if we limit this then vmalloc() will not allocate a huge page and > the performance benefit will be lost. bpf_prog_pack gives benefits without using PMD pages. For arm64 with 64kB page, even bpf_prog_pack of 64kB can fit multiple bpf programs in it. OTOH, 512MB is really big. How about we do something like the following? Thanks, Song diff --git i/kernel/bpf/core.c w/kernel/bpf/core.c index 9ee4536d0a09..1fe05c280e31 100644 --- i/kernel/bpf/core.c +++ w/kernel/bpf/core.c @@ -888,7 +888,15 @@ static LIST_HEAD(pack_list); * CONFIG_MMU=3Dn. Use PAGE_SIZE in these cases. */ #ifdef PMD_SIZE -#define BPF_PROG_PACK_SIZE (PMD_SIZE * num_possible_nodes()) + /* PMD_SIZE is really big for some archs. It doesn't make sense to + * reserve too much memory in one allocation. Cap BPF_PROG_PACK_SIZE to + * 2MiB * num_possible_nodes(). + */ + #if PMD_SIZE <=3D (1 << 21) + #define BPF_PROG_PACK_SIZE (PMD_SIZE * num_possible_nodes()) + #else + #define BPF_PROG_PACK_SIZE ((1 << 21) * num_possible_nodes()) + #endif #else #define BPF_PROG_PACK_SIZE PAGE_SIZE #endif