From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E020C71153 for ; Thu, 24 Aug 2023 03:56:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8250D680006; Wed, 23 Aug 2023 23:56:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D51B8E0011; Wed, 23 Aug 2023 23:56:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69CEF680006; Wed, 23 Aug 2023 23:56:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 599A58E0011 for ; Wed, 23 Aug 2023 23:56:02 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1C7601401B9 for ; Thu, 24 Aug 2023 03:56:02 +0000 (UTC) X-FDA: 81157634964.09.67B57B3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 40FA1100003 for ; Thu, 24 Aug 2023 03:56:00 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kCLPKRO3; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692849360; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f2MaMPDKau4stYbi7cF7voUFa5rnept8FYUDhQEpDjk=; b=fuef9LmOvyJeVCSv2bbInu6LDa5xIiv8J/bylOgFsXeeaZWtp2WCoX8fFxjJIL4Mzw0UP2 7w8CP12iHoBMHI1zhG6moOlS6JwIApNxdbr2RWIxOL7gJA8g56RUmumLZ0OF6iNZijCEVl 6e4EVx8NLSSF8EamWBs2MbgfCEJxGuw= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kCLPKRO3; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692849360; a=rsa-sha256; cv=none; b=EpjFQU0XsEs0RTQmpDj1273IOPxTAGpPdDyArGBn/l1OSdSoEr25AMHy36Ev4v576RRlhr cL7nWXG9BwbmC0EAKZ6J4qw/t4MPcSlF2MKAyC4jy6+hFqk+Lly7nFRsGLiczig/EkJJpi zjqspCSSIR+lrkdC9hMg+klgyiXLQOY= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F0C5863B91 for ; Thu, 24 Aug 2023 03:55:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5C48C433B7 for ; Thu, 24 Aug 2023 03:55:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692849357; bh=f2MaMPDKau4stYbi7cF7voUFa5rnept8FYUDhQEpDjk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=kCLPKRO3vG/kuskcO78aF4I2B+ZHsVDyhx4pglVcybTlSRpTye+rjGFamSLTzVRYO EPncaOZmEd0Fwju5Ltvpf9oUa3MrVhaqAq03GY4G6tSyPn/0iomgWmU4zn8Bp6ronS /EltsMz8pT0bvxVqHXHcZC2sawSeu7lDQoAn3puyt7NhGolHvAvrqvXmxtlJYeqQqG Rsy+jwbp0W8VfEE3cp06B0X1Cwm5eb4WY8kq0RlCXi4EkUqVexiuRvM/VJWkDPxOlL 7RfD7OL6eB3hsl8vMlrrxDFDQh8+PXnfRrNOrIhEhHm6hMpk515ADUwbSfjI0vw0jw M8ZoETD2Et57g== Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-4ff9abf18f9so9700514e87.2 for ; Wed, 23 Aug 2023 20:55:57 -0700 (PDT) X-Gm-Message-State: AOJu0Yws5aHxDjP67HMoGjDTZ5mAj41eOyb3i1gHwaGuW+2+6JnN0eqX c9IGw3JKGl3LmqwNMCgDAAsMD79HEVX5HhYcjEw= X-Google-Smtp-Source: AGHT+IHuPZ7LQJYjDMh9tonSINdmDBfMCDY6LWrqBjg7Q97XRVSQa1B8RpocHaT6h5lvN+tGGshVdDO1BJNhwZf8398= X-Received: by 2002:a05:6512:3241:b0:4fe:25bc:71f5 with SMTP id c1-20020a056512324100b004fe25bc71f5mr8521870lfr.11.1692849355644; Wed, 23 Aug 2023 20:55:55 -0700 (PDT) MIME-Version: 1.0 References: <20230824034304.37411-1-zhengqi.arch@bytedance.com> <20230824034304.37411-26-zhengqi.arch@bytedance.com> In-Reply-To: <20230824034304.37411-26-zhengqi.arch@bytedance.com> From: Song Liu Date: Wed, 23 Aug 2023 20:55:42 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 25/45] md/raid5: dynamically allocate the md-raid5 shrinker To: Qi Zheng Cc: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Muchun Song , linux-raid@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: ykmerifjb9okjzw3xtjytag49c4ucdy6 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 40FA1100003 X-HE-Tag: 1692849360-227517 X-HE-Meta: U2FsdGVkX195hSRuWZzv91b14+iKHSvgjnNbXBKXOuThw2m+d9UtScUdpXCmV2Y2okFl4k8c4txSJIGgaUf5NI11IJ8Ek4yS9DgnSs8PWcJMXp2gwThTXuXuxnqmlC7OaAL9qJjzAsKOIA/h2s+ctab/bHF8k+vkRUfpLp6y8Z2GTT+TH0pWjsw33NR6lgnn1zUisq7PhUSz9u5tXZ8kxfcQmaT/wQTSePN8Q+1y8Rx4wCZdS6nraDKgblfbFloP0tonOSELRYq92wLdcA0EnWhnf7pZSSV5fEiWBF1UsmBRuJEZA4HYN1wFx0nEUVCli0gom8KHKcKF7w5Zn/nVLkqB2E4a2woPDUI+mbxCilzYDXJ721KdDF9gxUzAn1oaMvbPvj32nKwjsbFxp1MiGVRVY8Bqa00p6QF/8ocQ5Y+lgZaNtQP0/pd6ltT67iKPjG7mnzy9YN9MlDtpOIUQPcT653BtU6wa3/4rBkNkniZpa10r6gLcEV6pdfYVVBjkQ3Ioaa5vTUCdmtQduAqyCO/fK2T3COwFzEngqnagwfiNHobxchqJgz/X5JqIUKM9dRodNFbRLkylj/8y5Rchso4A98F75X7v4JRPFmiTv15JJKER8W7pIzBm/hbIxlWpbsWLusnvrRhKqR9ErVQVLd9Lo6ASlODDPg7LsEdYnn9zqBH8f9C17VOdPVZWYD6AhgxU2G3OuAMehhJhqtFLMwV6lNQPiqq+H8p6+ukF/HnJya8rN2A4VTMxsoY6DXoSPFDKd9Myc995hXV22AIBNM7/LwjXd7uV9TBfrtih0UyL55LtmveON5ewp8hYuSN6om6CM9TLcQBwYNG+o8bIjtdbPd2KT/pidqEqhfQjsO2tO4QY4H6H7jddZbgelLajGeDQN7GPgbnHaTmUBMx0AhMr4ZeaRNkIrredEyy36SDRUMgu78W2hqhNvRgd4Q542ZMmoF/Ecu9ljxoNDka 1bZ1D2wk EAOgcs9Y195bmhYHVxON2YGWc0++3m5yC2PkOtgcmbRA2J1ocUlUabLpIwEkh/z34dBH35V8l4h3QAkEbEqmTn0Uiwt3IwTCJGR3t+piNhRAUQ446ZC3c6CmS1rB5A8ZBsN3hSaYzCxsPjtWyB6JRp6iALQHnCSeRJZf29lw0v+frstdPT9Pldnyff8kkAVxMQIu/NNaaF9Spnu/7DtascVjmkk2aeZ8uUP3Qg+nWMKlsuQy19dQe7u3UzfIEL+/z4WktWHmnPMyUcZgSFq7pMxuhDwSjkqftCwzSWzaY7s6ulUZOdTVZkf2Q/XLi9JkB+X1PniAExX3OGVxsdxWffIjMZ3h15+fXtOKTLskbkbbRD80hxqh3epHpMA7tRf160JRiQZNvoGvIRXVX1la00lny6SKY7w87qCn0Bmdlj6shzy58MWRzyqdWnw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 23, 2023 at 8:47=E2=80=AFPM Qi Zheng wrote: > > In preparation for implementing lockless slab shrink, use new APIs to > dynamically allocate the md-raid5 shrinker, so that it can be freed > asynchronously via RCU. Then it doesn't need to wait for RCU read-side > critical section when releasing the struct r5conf. > > Signed-off-by: Qi Zheng > Reviewed-by: Muchun Song > CC: Song Liu > CC: linux-raid@vger.kernel.org LGTM! Reviewed-by: Song Liu