From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32C27C0015E for ; Fri, 16 Jun 2023 20:18:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C85E68E0003; Fri, 16 Jun 2023 16:18:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C0F458E0001; Fri, 16 Jun 2023 16:18:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD8F08E0003; Fri, 16 Jun 2023 16:18:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 97C7F8E0001 for ; Fri, 16 Jun 2023 16:18:16 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6F127408FF for ; Fri, 16 Jun 2023 20:18:16 +0000 (UTC) X-FDA: 80909722992.04.A060904 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id 798AC180006 for ; Fri, 16 Jun 2023 20:18:14 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LmBJJScQ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686946694; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0syXvWVOMzE+crBjP45b/R3JjKKHEKyG53RAN5TCwtg=; b=12pGOSENUuyOsEOfEwekbPcVjMrXVQU/gZ2TE7ybZuVGL8qS4txVzTW50+h+1MXRM7uY7z 3GZ4BEjsYD2IDqvZfpK5KQkVivKHru8j8vdJO4RWDJYi40dqTlfy8/mxzxMvTySQLOTMVC JN/ZFpBP2VfRLomWqm4oxp1nW2MRKCE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LmBJJScQ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686946694; a=rsa-sha256; cv=none; b=gwy1+1a6WHRfLSmwfmu9BIUWvYa+QGcyMwm8jvijB8jfL3BebaNzS3XmNkyzBPEWQymUAn 7zqtlSDt6AfGco4Anww47ZCaK3h9jYgdUkQ0wgELzSu8UwphA1xAhtoilRfKJkz9R1xbWK uSUbeWuMEqPlipyl/VC+/cFEDx923WA= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7A1F663F18 for ; Fri, 16 Jun 2023 20:18:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DA48C433A9 for ; Fri, 16 Jun 2023 20:18:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686946692; bh=U5Tl9qs4B0TBI/rIx4ZZgTkRwFm5uyKz4CPReQtXH/U=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=LmBJJScQlLvxsT8+Ta1tCpM4WXI6TR8l8c5jV/lF5ZOrowqAfZjtpNM41tcPHiArX +YH5I9st348UgQHncZvkjv1I8uf6/B9VIYKB/ZX5ShONmWppK4Z28CmWLldHUX++Co tQHCqBzRDW0rngL+0918l5A/LKDXSOHiSUfIz3m/CZC9iQ5hn0r0gJTm/FmWwj/qLn mAG9TY9iKVAQprNcopRBSELs+aKCJHBbKHSrnFdxygoqMhe72Gcymvj1seoYl1ETYg kF9uj767lw3HcyBO4F7SRQUsfNpsVMh+rYJU6mMVRBqQdXG9XPM9gyQIez8ST13ZvP VGJY2Pv9kdJTA== Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2b4146fbadeso16187461fa.0 for ; Fri, 16 Jun 2023 13:18:12 -0700 (PDT) X-Gm-Message-State: AC+VfDxLXuwSJYNfUsuKBr53HVfgv5fKeQuoqxkKFnz7pj8ylCgwWuuC DMgj6mLdX1NunMVqhq1cTBoY8zVjJq7NHjm49ag= X-Google-Smtp-Source: ACHHUZ4zX0CYOJSSN4FGWX93J1VUIgZYXEOYsrGR9cSML7AlHx0h0qQhMxp9jkMOVU4u0KdCA43Yux1f/ue71yfnFUk= X-Received: by 2002:a05:651c:225:b0:2b3:4fb7:8991 with SMTP id z5-20020a05651c022500b002b34fb78991mr2815162ljn.43.1686946690319; Fri, 16 Jun 2023 13:18:10 -0700 (PDT) MIME-Version: 1.0 References: <20230616085038.4121892-1-rppt@kernel.org> <20230616085038.4121892-11-rppt@kernel.org> In-Reply-To: <20230616085038.4121892-11-rppt@kernel.org> From: Song Liu Date: Fri, 16 Jun 2023 13:17:57 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 10/12] arch: make execmem setup available regardless of CONFIG_MODULES To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, Andrew Morton , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Mark Rutland , Michael Ellerman , Nadav Amit , "Naveen N. Rao" , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 798AC180006 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: qk75dtfy7krsc8rhfwz8fbtizrwnp9ac X-HE-Tag: 1686946694-444093 X-HE-Meta: U2FsdGVkX189/5PuQNTNI4F5w/JL1dQNNeaWtqIzvFkUV3XrTvYhRewP5wYupWiU7vUiqxTamy21bACA2djmepnDhoes9eQNsaJeoztOqtIer0+UaHCN+QcbUwiDn2OPwlsK+P+UyanNKtfFJALamr+aJh5ChdeRXlRpzlE4JXnYSNUlrQstmC/5ubKY09drn07GNcEfe95vQIYfDrjdFg45lzvrjlSQRvoeXEMqnpy1BSBPLvacteKO9jHynTHmauP99lAbCIv9Xkp9ufa+Un2HYdGeMBGniIaqr+VVdQO5ELFRZw8Q06I3MfAu0hcBfrDwvNUrWFwKBMs0N5YBWjj0BgtqlXN4bUaFdWBGLWT5uBPWpYXwBybW6Yblr19g+30aDzfMC1XW08mCqISGfF2x/fZXlKNtu0B1UG8dIL8TLYPQ943PxH5X95LKY/f5y3VN3THz1faNm/z4jlPb17h+h6YsSWcht9iYvt46cDnhqPhPRQ6GzMpcCpySkiMEozBgRp4yzsItel4/6ZsqEozVIxvwhxGH1MSF3K/gcv38qSqrUwYTGbR44NF5Za1J9hDGqyTV0TixDk6/kwYrJFLGMmjOhxYfswkoA26+KFGq4lC5EkHclD6dDfFzxgGvlWAdD/gen9bY/ysnMpr9cSn9j+OL1r75FitTjyRzWfVERuOxTRF3atOJVfnzrMuEjHxhskXxOIJkIgbywf2qjFe0jL5v7Ew/YAijsMF3HNpNVgZW3hhqUY8RIVpE8b6hT7MnThBSHJkioFj0HmMJuiolrewVzf29Tp6U/dXc7bYbru72a5OtJR9x09iN02Wy7KeLOMb6xSXk8zp5ftbNlHFohZgEI3nQrDVA505jN6MdzC1XcMwqNGQMWv48tivRfh2eF8WY5FGv4vG/nN0kVNk7i1fUUmeWeGz/c09JO4YuAzcdnsVmh//T3Fdb3/sdl60O25E+QcyfI534qP+ 8dVp4ltc k3smDm5onfnOL3oia0JVT3bd0llrr7v3ilDfppivaJn7TfNIJtEOTBXAXGSSMJ84ZmGKSaChTYhcY1YIU1O1NWJSyUo4TfyonT0ut9rcnZ5+bTk6KLtYQWQZioxZn9f6eI0dfiOyab91u8vCpZLXV3sdVDTMYX6TqO0F+9B51dwiuB4FojOlk6fgFUeVnE4pZJ4GrRkmqzt/hQfym5kaGIMoGH4EN13Oujs0RsPGnOXxOoJCo18EDBWNi9PIF9m3Z+oqfMZE9VKt3ZBilUbmTfAO73jvzKraf9QOJxXFSEY42BjvJtitBGCgQQLXFD7LPM5dUKgmZfYJ8P+KCNUvEEeaZ5PG33EU3opY5waWQWQF8BZzlNoIgNF+lfOP40caOBXbJol3d3zHIPNWKF/PjFaEC1BmCWh/VMXVaCBRWlX0jHhbluXZ+v2Ula9aQLFA7raBIgIrx5UI6oCGD10tVZaJL1DVbx13juTnHW5IME3fz1onJhAW/CFiPuQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 16, 2023 at 1:52=E2=80=AFAM Mike Rapoport wro= te: > > From: "Mike Rapoport (IBM)" > > execmem does not depend on modules, on the contrary modules use > execmem. > > To make execmem available when CONFIG_MODULES=3Dn, for instance for > kprobes, split execmem_params initialization out from > arch/kernel/module.c and compile it when CONFIG_EXECMEM=3Dy > > Signed-off-by: Mike Rapoport (IBM) > --- [...] > + > +struct execmem_params __init *execmem_arch_params(void) > +{ > + u64 module_alloc_end; > + > + kaslr_init(); Aha, this addresses my comment on the earlier patch. Thanks! Acked-by: Song Liu > + > + module_alloc_end =3D module_alloc_base + MODULES_VSIZE; > + > + execmem_params.modules.text.pgprot =3D PAGE_KERNEL; > + execmem_params.modules.text.start =3D module_alloc_base; > + execmem_params.modules.text.end =3D module_alloc_end; > + > + execmem_params.jit.text.pgprot =3D PAGE_KERNEL_ROX; [...]