From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC0E6C4332F for ; Thu, 17 Nov 2022 06:41:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FC8A6B0075; Thu, 17 Nov 2022 01:41:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2AC618E0003; Thu, 17 Nov 2022 01:41:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19B158E0002; Thu, 17 Nov 2022 01:41:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0B8A06B0075 for ; Thu, 17 Nov 2022 01:41:55 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D99831A09FF for ; Thu, 17 Nov 2022 06:41:54 +0000 (UTC) X-FDA: 80141988948.22.C2B1A36 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id 60CB616000A for ; Thu, 17 Nov 2022 06:41:54 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7E339620C3 for ; Thu, 17 Nov 2022 06:41:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCB83C43140 for ; Thu, 17 Nov 2022 06:41:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668667312; bh=SnM1FtaUeYJRRujlQeq7IpO09wMHia8NIW6nScFy+Yk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=lR2uSQSLMbkLlDIdci5fHU2CqkE26dSgsm53aDbD6ZSbeOtrue123LXuBXxywnpc6 306ifrECApgVXR37NGfiJEwbSjk1ZVja+hMoE46LdSDjyH+ZknYaCG0deIDh+d59hm FMXbIz+uDcshbuqKqNr4gP1Zar05W62lkVooSnYdUi1ZeTcSg5s6WNtJJBqWPX/g2J 8DVtOoCGsr9grXAEBeO+7lxRJC0lbdHqLkvmT7JS1k1ce4Eink4c0ofypAzbyRCHnS Q+rV/PL8VdMRPD+7gLhh/XiX3/ZRvLNZEX6iyA26i+e8Yd+qHaz09MQXRIgJRcFAzp MvwIN7cSQrvxw== Received: by mail-ej1-f49.google.com with SMTP id n20so2866760ejh.0 for ; Wed, 16 Nov 2022 22:41:52 -0800 (PST) X-Gm-Message-State: ANoB5pm8Yr3/B2750FWpSyz9/Z/awbYs+D5b5fBtN9zYxomlHS8yJc3Y n8w8koW7AZnDp5F6dHQ+/cdQ8myL98VJMEj5PBg= X-Google-Smtp-Source: AA0mqf4bYESblYKqNvg1KhBn6PnowkzN8+8DYXrdRYkkDaK7WC+mrWvXPaKn/zyhLM+LsjdcuzoQ2HrORRyBF/zrMQk= X-Received: by 2002:a17:906:348b:b0:78d:9e04:d8c2 with SMTP id g11-20020a170906348b00b0078d9e04d8c2mr928422ejb.614.1668667311120; Wed, 16 Nov 2022 22:41:51 -0800 (PST) MIME-Version: 1.0 References: <20221117010621.1891711-1-song@kernel.org> <20221117010621.1891711-4-song@kernel.org> In-Reply-To: From: Song Liu Date: Wed, 16 Nov 2022 22:41:39 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH bpf-next v3 3/6] selftests/vm: extend test_vmalloc to test execmem_* APIs To: Luis Chamberlain Cc: bpf@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, x86@kernel.org, peterz@infradead.org, hch@lst.de, rick.p.edgecombe@intel.com, aaron.lu@intel.com, rppt@kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668667314; a=rsa-sha256; cv=none; b=L9i3Rel9Iw9NX31qPy+22U+HwqFr3aOI8qiDZ/8f+zTtR5yosOp2Y1OWxiMDHOLdp97CIW /q3qlOc2CLqTq4te9PpG5zskJ/MNt/GzX9evux01S4pVs8uQ85Lb65DaU9qyBOhM638NJN wyUx91+mAuz9UtzKPTpDn+FTKGPv4us= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lR2uSQSL; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668667314; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=isHpshxc3wI6TSIqLHOSbWkCIbITIcSdUTcdkpDrPdk=; b=IyLCSnuj92i+gDpTf48ACY9REvxVYglB7CENOE4+taQ87BrG3XlQT25euNQ/C310ibedN+ D2RCPsZ086fUIHLyFFg5dYwg9DyfCzLSx+vjKIvtIpdeBeiwnUW+ceBoPpkcKknzkZA7rU RzSTSiDPgAZJn+Eh510Qja3MT6+tgjA= X-Stat-Signature: o9f3swwbpshexjc1f71538nqi8do66d6 X-Rspamd-Queue-Id: 60CB616000A X-Rspam-User: Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lR2uSQSL; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org X-Rspamd-Server: rspam09 X-HE-Tag: 1668667314-550413 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 16, 2022 at 5:49 PM Luis Chamberlain wrote: > > On Wed, Nov 16, 2022 at 05:06:18PM -0800, Song Liu wrote: > > Add logic to test execmem_[alloc|fill|free] in test_vmalloc.c. > > No need to change tools/testing/selftests/vm/test_vmalloc.sh. > > > > Signed-off-by: Song Liu > > --- > > lib/test_vmalloc.c | 30 ++++++++++++++++++++++++++++++ > > 1 file changed, 30 insertions(+) > > > > diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c > > index cf7780572f5b..6591c4932c3c 100644 > > --- a/lib/test_vmalloc.c > > +++ b/lib/test_vmalloc.c > > @@ -50,6 +50,7 @@ __param(int, run_test_mask, INT_MAX, > > "\t\tid: 128, name: pcpu_alloc_test\n" > > "\t\tid: 256, name: kvfree_rcu_1_arg_vmalloc_test\n" > > "\t\tid: 512, name: kvfree_rcu_2_arg_vmalloc_test\n" > > + "\t\tid: 1024, name: execmem_alloc_test\n" > > /* Add a new test case description here. */ > > ); > > > > @@ -352,6 +353,34 @@ kvfree_rcu_2_arg_vmalloc_test(void) > > return 0; > > } > > > > +static int > > +execmem_alloc_test(void) > > +{ > > + void *p, *tmp; > > + int i; > > + > > + for (i = 0; i < test_loop_count; i++) { > > + /* allocate variable size, up to 64kB */ > > + size_t size = (i % 1024 + 1) * 64; > > + > > + p = execmem_alloc(size, 64); > > + if (!p) > > + return -1; > > + > > + tmp = execmem_fill(p, "a", 1); > > + if (tmp != p) > > + return -1; > > + > > + tmp = execmem_fill(p + size - 1, "b", 1); > > + if (tmp != p + size - 1) > > + return -1; > > + > > + execmem_free(p); > > + } > > + > > + return 0; > > +} > > + > > This is a basic test and it is useful. > > But given all those WARN_ON() and WARN_ON_ONCE() I think the real value > test here would be to race 1000 threads doing this at the same time. test_vmalloc supports parallel tests. We can do something like tools/testing/selftests/vm/test_vmalloc.sh nr_threads=XXX run_test_mask=1024 Thanks, Song