From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 721E3C433EF for ; Thu, 14 Apr 2022 21:03:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F8EB6B0071; Thu, 14 Apr 2022 17:03:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A80C6B0073; Thu, 14 Apr 2022 17:03:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 897846B0074; Thu, 14 Apr 2022 17:03:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0153.hostedemail.com [216.40.44.153]) by kanga.kvack.org (Postfix) with ESMTP id 7C4A06B0071 for ; Thu, 14 Apr 2022 17:03:34 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 25BC2183CB1FD for ; Thu, 14 Apr 2022 21:03:34 +0000 (UTC) X-FDA: 79356710748.31.83E7245 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 7E2524000E for ; Thu, 14 Apr 2022 21:03:33 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BB12061FCA for ; Thu, 14 Apr 2022 21:03:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A34E5C385AF for ; Thu, 14 Apr 2022 21:03:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649970211; bh=UkMQ4UMV4zIIjkvwR6WA9j7hHfaJIvKpNRMLcx2C8EQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=m94A1dx0IP+EPc09O6usSPeuJVq+pXXLjnEfitt2q/KFXYI/hO/8d0eMZ1Lx8FSRK bs0YdH+jPjyX+vv5OqVG3IvuJCz7OxnRIQrsW30ZtumUL26J4Ad2E0/eGDxtsPBWvx RG78EDk0NOS6W3In0lQW5yE8t3qpz8f9i91VC2zhtKJCGutyshmekmemMg91q5ruyM OTwPg7tbB7o6TuLnFNnorq71dtfuvc8i86JpCPveAcNkOb7xuj9SrkZJhXZ3rov6rv sgGDYMFacmlsH05qRCeNm7VVArmpfN+FcGx2V72nCTI1uNdJU9l0eihS0tfK7oV3yc VweQTvwBhSk9A== Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-2eba37104a2so68518707b3.0 for ; Thu, 14 Apr 2022 14:03:31 -0700 (PDT) X-Gm-Message-State: AOAM530fMobI2dhpnt9sSpVvNNZG/1uIvPwl0CCdcsV7yKlc9wB1iL1w LmllYX65uSrF0QzJwEOlmKfic3ui95VUw7t+/AA= X-Google-Smtp-Source: ABdhPJzWj+86yGa1OXSzZVano7JEjnkCaOvqXeqGXSAQzAwOci0XM45nfY5+5dzQ/w3y1uC8uuJDMNPGXalm5AAcHMg= X-Received: by 2002:a81:14c8:0:b0:2eb:eb91:d88f with SMTP id 191-20020a8114c8000000b002ebeb91d88fmr3746888ywu.148.1649970210616; Thu, 14 Apr 2022 14:03:30 -0700 (PDT) MIME-Version: 1.0 References: <20220414195914.1648345-1-song@kernel.org> <20220414195914.1648345-4-song@kernel.org> In-Reply-To: From: Song Liu Date: Thu, 14 Apr 2022 14:03:17 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 bpf RESEND 3/4] module: introduce module_alloc_huge To: Luis Chamberlain Cc: bpf , Linux-MM , open list , Alexei Starovoitov , Daniel Borkmann , Kernel Team , Andrew Morton , "Edgecombe, Rick P" , Christoph Hellwig , imbrenda@linux.ibm.com Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=m94A1dx0; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7E2524000E X-Stat-Signature: ku7pa5dnzewrot57m1t68s6niis4hpka X-HE-Tag: 1649970213-260610 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Luis, On Thu, Apr 14, 2022 at 1:34 PM Luis Chamberlain wrote: > > On Thu, Apr 14, 2022 at 12:59:13PM -0700, Song Liu wrote: > > Introduce module_alloc_huge, which allocates huge page backed memory in > > module memory space. The primary user of this memory is bpf_prog_pack > > (multiple BPF programs sharing a huge page). > > > > Signed-off-by: Song Liu > > See modules-next [0], as modules.c has been chopped up as of late. > So if you want this to go throug modules this will need to rebased > on that tree. fortunately the amount of code in question does not > seem like much. > > [0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=modules-next We are hoping to ship this with to 5.18, as the set addresses some issue with huge page backed vmalloc. I guess we cannot ship it via modules-next branch. How about we ship module_alloc_huge() to 5.18 in module.c for now, and once we update modules-next branch, I will send another patch to clean it up? Thanks, Song