From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7259C433F5 for ; Wed, 24 Nov 2021 22:31:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D0F46B0075; Wed, 24 Nov 2021 17:31:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2811E6B0078; Wed, 24 Nov 2021 17:31:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 149EC6B007B; Wed, 24 Nov 2021 17:31:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0030.hostedemail.com [216.40.44.30]) by kanga.kvack.org (Postfix) with ESMTP id 071AD6B0075 for ; Wed, 24 Nov 2021 17:31:19 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C0D9982319B3 for ; Wed, 24 Nov 2021 22:31:08 +0000 (UTC) X-FDA: 78845270658.26.FE341D6 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf09.hostedemail.com (Postfix) with ESMTP id 724793000880 for ; Wed, 24 Nov 2021 22:31:04 +0000 (UTC) Received: by mail-pj1-f45.google.com with SMTP id x7so3673226pjn.0 for ; Wed, 24 Nov 2021 14:31:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZTluUY3cfxjR9J/ibD8Q7eAgh7RLXinSzFroRqU4Dps=; b=DStKIl3D31dPx51zr5q99irRZoe+Yhr00PsrXQdnlBwTNGrPhkVxm323fyvH8fWTPY uCy2yJnFf871/QbrZ2TFRrrJ+kiQkR9uuevtlIhU0dSnpwSSARXBTd71IBUpZqifxm4L tn2fWH/hhn97cwmhGP/WZlf9wBdK8sdSE/N7Z+ofNfAkvpBp6xYiGxGukSTR/roCiIhm /uLuFlwkTc1ia5TxHKufnvnLEveTbJYV6m8zINtLhp7KFWHlmNYLtJ6GeeIgCQV//ZPX eBvk6/gV84acVoPnFCLaQMx5NBHtkHg70Z0OwLbXhB1XEA81KsUCve+EQpT/ejypy5mz MYXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZTluUY3cfxjR9J/ibD8Q7eAgh7RLXinSzFroRqU4Dps=; b=c0x0Fs1eHfeJY4aN/AB7Teo+hZoLPdGtvvx+5IEFaSrgk5pxgOuOVVlzP3StRNwZcy 6CueBJpcuav3sjLjyi/w6/pyBiX4xFEw/Pig/xsth9cscW5JRTw6R6L5EcKOiHAhEgGg XCt1/WoS4gh7tSZ4HhO1QYZIp3vYNkw6/HODiKr8nYAFCAnYP3GWUmWZUsZ5fzh8HINb ai4q1GX6HRdNUbRoeOEmAxvwVCckcrQN+TwEIUKlGOzrcUUeN0t1fE3D2n0k4on2YDGi BtiHomwKGULfshZkjBWnEcNrfhb0jr8CsVND/pqruSXxGPO1atensVuXEbu9uj/w4Mta MKVQ== X-Gm-Message-State: AOAM530JIR4SS0BnRg6KIPOEFk8Xf8ut1FjK1wLZbkOXySpwwQ3hHITJ 1kmfe7Pgz8OEXjJSItu3UrW/qpAXJ1u8NWdLqkuyFA== X-Google-Smtp-Source: ABdhPJz1ZxxqX/IeS4j0FkYYNfR0YubhWSALTSmVmxUQdkgfzkBeZXTVYWzt7kBsoct/2dA7OHXQoUJmBkF/iTIKLa0= X-Received: by 2002:a17:90b:1e49:: with SMTP id pi9mr689531pjb.220.1637793066752; Wed, 24 Nov 2021 14:31:06 -0800 (PST) MIME-Version: 1.0 References: <20211124191005.20783-1-joao.m.martins@oracle.com> In-Reply-To: <20211124191005.20783-1-joao.m.martins@oracle.com> From: Dan Williams Date: Wed, 24 Nov 2021 14:30:56 -0800 Message-ID: Subject: Re: [PATCH v6 00/10] mm, device-dax: Introduce compound pages in devmap To: Joao Martins Cc: Linux MM , Vishal Verma , Dave Jiang , Naoya Horiguchi , Matthew Wilcox , Jason Gunthorpe , John Hubbard , Jane Chu , Muchun Song , Mike Kravetz , Andrew Morton , Jonathan Corbet , Christoph Hellwig , Linux NVDIMM , Linux Doc Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 724793000880 X-Stat-Signature: 3fnkie6fbayux9og7z39z96excqzfe79 Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=intel-com.20210112.gappssmtp.com header.s=20210112 header.b=DStKIl3D; spf=none (imf09.hostedemail.com: domain of dan.j.williams@intel.com has no SPF policy when checking 209.85.216.45) smtp.mailfrom=dan.j.williams@intel.com; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=intel.com (policy=none) X-HE-Tag: 1637793064-225251 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 24, 2021 at 11:10 AM Joao Martins wrote: > > Changes since v5[9]: > > * Keep @dev on the previous line to improve readability on > patch 5 (Christoph Hellwig) > * Document is_static() function to clarify what are static and > dynamic dax regions in patch 7 (Christoph Hellwig) > * Deduce @f_mapping and @pgmap from vmf->vma->vm_file to reduce > the number of arguments of set_{page,compound}_mapping() in last > patch (Christoph Hellwig) > * Factor out @mapping initialization to a separate helper ([new] patch 8) > and rename set_page_mapping() to dax_set_mapping() in the process. > * Remove set_compound_mapping() and instead adjust dax_set_mapping() > to handle @vmemmap_shift case on the last patch. This greatly > simplifies the last patch, and addresses a similar comment by Christoph > on having an earlier return. No functional change on the changes > to dax_set_mapping compared to its earlier version so I retained > Dan's Rb on last patch. > * Initialize the mapping prior to inserting the PTE/PMD/PUD as opposed > to after the fact. ([new] patch 9, Jason Gunthorpe) > Looks good Joao, I was about to ping Christoph and Jason to make sure their review comments are fully addressed before pulling this into my dax tree, but I see Andrew has already picked this up. I'm ok for this to go through -mm. It might end up colliding with some of the DAX cleanups that are brewing, but if that happens I might apply them to resolve conflicts and ask Andrew to drop them out of -mm. We can cross that bridge later. Thanks for all the effort on this Joao, it's a welcome improvement.