From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9D55C433EF for ; Tue, 8 Feb 2022 23:53:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EFE246B0073; Tue, 8 Feb 2022 18:53:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EAD4D6B0075; Tue, 8 Feb 2022 18:53:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9CEE6B0078; Tue, 8 Feb 2022 18:53:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id C9D866B0073 for ; Tue, 8 Feb 2022 18:53:27 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8970E22A51 for ; Tue, 8 Feb 2022 23:53:27 +0000 (UTC) X-FDA: 79121266854.02.CA5067A Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by imf02.hostedemail.com (Postfix) with ESMTP id 22A2180005 for ; Tue, 8 Feb 2022 23:53:26 +0000 (UTC) Received: by mail-pf1-f181.google.com with SMTP id x65so1163774pfx.12 for ; Tue, 08 Feb 2022 15:53:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=9yllLJXxvJNbb7TJ6F8GXcTe3gXNYnW6vmBXP6xHdmQ=; b=1TP2oV0hvpTVvUc38sU25Nq8P8dLloqnVrR1dLnL0k00RIz6cxvWF4JovZ1JHdh+Iq QjJ5AHaidFx9YmqNTrZ5h5qyJPKM/tziAB9DhO4YFzjPd5bpNTRb+YsjUwlfA7jtVsFK U7OdrJqAvGZ07hdSarMyxYyjKgkfa4xWh2cbsWw1St7pAb9nNM89cLwW6fNieqLKy8A0 lEy6S237O1zyS6B6nOobWB1RoW/2FsR/vn8FET1ptCNsh08iwgcstMONTlv3sghEwQq4 uOxijQbfhnxc35FRPR6EYrfjLYHOlXzLa9Vs6xBYs94IsyLrdPrgdUt8qrZhQDjGtN/K zJ5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9yllLJXxvJNbb7TJ6F8GXcTe3gXNYnW6vmBXP6xHdmQ=; b=iX6kmLjpOB8Nhu1q5PZGXHBVffDRyZlryFO5X1JgRo10WVeAOyhlKbLF4qptuStNSN U8YFPb9HhemJUXUJ6bwQBXWGK1LNSZ9ws4UO7gEwobH89nn/TfrnoTyDxNyEceFcx2bI O0EzR8X7eftUUwlIRPlSq1FXT4AdYTQojW+8Zx6a0DUt2mAw3g1LOMCZjDWrmmX8iUGW talF6g6GfpRzw1UAuQxJz+wvzFBCMfbx5EVtYfLZPKlFj5FL26HaLtbXSZ/QhlAsdfis zKjs6JCWDFV3SwHPSRKmpb0Byc5MAY2kwBDcX2Y25MiUjJoLEgr/V7kZmqDHVb9Re6zO HXDQ== X-Gm-Message-State: AOAM532aJEjCrm+k0WuWmrzwKkpAmjhB/vAA1hCTv7XgqXJAyNlfaFOP 7rBQl2NeZHrgvkT6GSCdhu6fnPAxbNBFMYJ1qdYajw== X-Google-Smtp-Source: ABdhPJxeYY0PWIjCV0oL3qSXzPE/CqXZVnxQ/6hAd62TUxvblfYAlcQYEDEiHEyZHUJKW9dSv16xGL4Nt/VbJK9Vxe0= X-Received: by 2002:a63:8849:: with SMTP id l70mr2640980pgd.437.1644364405842; Tue, 08 Feb 2022 15:53:25 -0800 (PST) MIME-Version: 1.0 References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-7-hch@lst.de> In-Reply-To: From: Dan Williams Date: Tue, 8 Feb 2022 15:53:14 -0800 Message-ID: Subject: Re: [PATCH 6/8] mm: don't include in To: Christoph Hellwig Cc: Andrew Morton , Felix Kuehling , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , Ben Skeggs , Karol Herbst , Lyude Paul , Jason Gunthorpe , Alistair Popple , Logan Gunthorpe , Ralph Campbell , Linux Kernel Mailing List , amd-gfx list , Maling list - DRI developers , nouveau@lists.freedesktop.org, Linux NVDIMM , Linux MM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 22A2180005 X-Stat-Signature: i6qi1ttp7ttew9urqe9cnrkm784isjxz Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=intel-com.20210112.gappssmtp.com header.s=20210112 header.b=1TP2oV0h; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=none (imf02.hostedemail.com: domain of dan.j.williams@intel.com has no SPF policy when checking 209.85.210.181) smtp.mailfrom=dan.j.williams@intel.com X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1644364406-129043 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 7, 2022 at 3:49 PM Dan Williams wrot= e: > > On Sun, Feb 6, 2022 at 10:33 PM Christoph Hellwig wrote: > > > > Move the check for the actual pgmap types that need the free at refcoun= t > > one behavior into the out of line helper, and thus avoid the need to > > pull memremap.h into mm.h. > > Looks good to me assuming the compile bots agree. > > Reviewed-by: Dan Williams Yeah, same as Logan: mm/memcontrol.c: In function =E2=80=98get_mctgt_type=E2=80=99: mm/memcontrol.c:5724:29: error: implicit declaration of function =E2=80=98is_device_private_page=E2=80=99; did you mean =E2=80=98is_device_private_entry=E2=80=99? [-Werror=3Dimplicit-function-dec= laration] 5724 | if (is_device_private_page(page)) | ^~~~~~~~~~~~~~~~~~~~~~ | is_device_private_entry ...needs: diff --git a/mm/memcontrol.c b/mm/memcontrol.c index d1e97a54ae53..0ac7515c85f9 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -62,6 +62,7 @@ #include #include #include +#include #include "internal.h" #include #include