From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by kanga.kvack.org (Postfix) with ESMTP id 805696B0253 for ; Mon, 12 Oct 2015 12:16:57 -0400 (EDT) Received: by wicge5 with SMTP id ge5so156930075wic.0 for ; Mon, 12 Oct 2015 09:16:57 -0700 (PDT) Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com. [209.85.212.181]) by mx.google.com with ESMTPS id xm14si15783799wib.33.2015.10.12.09.16.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Oct 2015 09:16:56 -0700 (PDT) Received: by wijq8 with SMTP id q8so65364370wij.0 for ; Mon, 12 Oct 2015 09:16:56 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <561BACB8.7020405@redhat.com> References: <20151010005522.17221.87557.stgit@dwillia2-desk3.jf.intel.com> <20151010005622.17221.44373.stgit@dwillia2-desk3.jf.intel.com> <561976AC.6000003@redhat.com> <561BACB8.7020405@redhat.com> Date: Mon, 12 Oct 2015 09:16:55 -0700 Message-ID: Subject: Re: [PATCH v2 11/20] kvm: rename pfn_t to kvm_pfn_t From: Dan Williams Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Paolo Bonzini Cc: "linux-nvdimm@lists.01.org" , Dave Hansen , Russell King , Linux MM , Gleb Natapov , Catalin Marinas , Will Deacon , "linux-kernel@vger.kernel.org" , Ralf Baechle , Marc Zyngier , Paul Mackerras , Christoffer Dall , Benjamin Herrenschmidt , Ross Zwisler , Christoph Hellwig , Alexander Graf , KVM list On Mon, Oct 12, 2015 at 5:51 AM, Paolo Bonzini wrote: > > > On 10/10/2015 22:57, Dan Williams wrote: >> On Sat, Oct 10, 2015 at 1:35 PM, Paolo Bonzini wrote: >>> On 10/10/2015 02:56, Dan Williams wrote: >>>> The core has developed a need for a "pfn_t" type [1]. Move the existing >>>> pfn_t in KVM to kvm_pfn_t [2]. >>>> >>>> [1]: https://lists.01.org/pipermail/linux-nvdimm/2015-September/002199.html >>>> [2]: https://lists.01.org/pipermail/linux-nvdimm/2015-September/002218.html >>> >>> Can you please change also the other types in include/linux/kvm_types.h? >> >> Hmm, all those seem kvm specific already. I'd only prefix them with >> kvm_ if they collided with a "core" type. > > But they are all related and the code becomes uglier if you only prefix > one of them. If you don't convert all of them, I will do it anyway as > soon as this patch get in. Ok. > Since it touches a lot of KVM files, we should synchronize in order to > avoid conflicts and gnashing of teeth. What tree is this patch going > in? You could provide me a commit SHA1 for this patch (well, its > definitive version) based on Linus's tree (so that I can merge it in my > tree as well), or I could commit it and provide the SHA1 to the > maintainer of said tree. The kvm_pfn_t conversion is only needed if the new pfn_t infrastructure moves forward, and at this point it still needs some review feedback. How about this, care to send conversion patches for the rest? ...based on: https://git.kernel.org/cgit/linux/kernel/git/djbw/nvdimm.git/log/?h=libnvdimm-pending When/if the new pfn_t bits move forward I'll carry them in the same pull request through the nvdimm.git tree. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org