From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5833C433EF for ; Tue, 15 Feb 2022 22:12:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 410F86B0075; Tue, 15 Feb 2022 17:12:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 399F46B0078; Tue, 15 Feb 2022 17:12:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1EC4A6B007D; Tue, 15 Feb 2022 17:12:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0199.hostedemail.com [216.40.44.199]) by kanga.kvack.org (Postfix) with ESMTP id 0B2C86B0075 for ; Tue, 15 Feb 2022 17:12:13 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id BD29692746 for ; Tue, 15 Feb 2022 22:12:12 +0000 (UTC) X-FDA: 79146413304.08.EC0721D Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf26.hostedemail.com (Postfix) with ESMTP id 92C06140002 for ; Tue, 15 Feb 2022 22:11:49 +0000 (UTC) Received: by mail-pj1-f47.google.com with SMTP id n19-20020a17090ade9300b001b9892a7bf9so4496765pjv.5 for ; Tue, 15 Feb 2022 14:11:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dg8Bbqo8xrTURRSZr1gbJA1kXH+dR6Cfw/CPc1vh5OA=; b=JWDZBiIvBXJ+xyw/ssMlbLaY+HL0dGj6fRKKopQM/zAdOrPiEpBBbN0hIHBWPjTwv7 phWt006J1z/OGnlE0pZ1IAr4MBG61MAESVtMLCJJLdN03Qgw5ph3ybjNDcm5KLD4H/Bn dWXl2k4tg6j6b6r3iLke/JjQOqtAWGhWjmz+5X/AmIsbrRbdPwocCDW6gnbjWLV+8CGP 6XBgMZj2Vbtv7WovHLG8U9O+XTiFW1Esdpsq5PDNf7YwiqhlubKB9tjZcJrQw+cD3SxG 3OYRHWmQVG+2jcAaW9y66JUIwQHgJwy+IQgpES3zBB50Hn7Ps4/BtqJ1QikahSxmXMbV ZLTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dg8Bbqo8xrTURRSZr1gbJA1kXH+dR6Cfw/CPc1vh5OA=; b=g1Ss3dj/1P7ElHqJ/EZsaILze7srmvoqmIov83Wf1gFIqtiVD0UTUs0ECK8ThDC/Kp /OrGxJFvx4tAQrjsF54WDndebBiFzLFNfz0jtO476uNWdFli+RssQnj6XRAiu3WfYSky LoxAj6GrRaGEUNIfJQe6Q3pdD1VUSW6q3eJsgJF3FJEgIVqwOQJOT1zEBB41wp83sCdh RULoI8qUTcrLEM9wmPLNBzE/T2rpEyAECLLtYSbnG5HEkGa7A4X8x2zSsoCEC5S68ADx 7ukkhOvgiLMUHKOXOdgvu82JE9N7nUdWogNQQXJrMdSwYsi3lII2pgfCl6m66mj/wvx2 7Xrw== X-Gm-Message-State: AOAM530WOIlVQG9IgzQIqfpPOyxjRqdTlG8GCGSkQR2Taq8VovD86jLV lAS4hJyiMWgeVmDoFsatWmMwYDII2p0G6JKD887sVg== X-Google-Smtp-Source: ABdhPJyiswDhX6qkwwQts1SFepTHj/P5w6WGlYQlgTjrpG3xns33VOfe9EvdjD9DCBoIscPBLRLRybo05bZTeUzOoys= X-Received: by 2002:a17:90a:e7cb:: with SMTP id kb11mr1046139pjb.220.1644963108677; Tue, 15 Feb 2022 14:11:48 -0800 (PST) MIME-Version: 1.0 References: <20220127124058.1172422-1-ruansy.fnst@fujitsu.com> <20220127124058.1172422-3-ruansy.fnst@fujitsu.com> In-Reply-To: <20220127124058.1172422-3-ruansy.fnst@fujitsu.com> From: Dan Williams Date: Tue, 15 Feb 2022 14:11:42 -0800 Message-ID: Subject: Re: [PATCH v10 2/9] mm: factor helpers for memory_failure_dev_pagemap To: Shiyang Ruan Cc: Linux Kernel Mailing List , linux-xfs , Linux NVDIMM , Linux MM , linux-fsdevel , "Darrick J. Wong" , david , Christoph Hellwig , Jane Chu , Christoph Hellwig Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 92C06140002 X-Stat-Signature: gwrq7gqqm5mimrnj15ops65tjpmcd9tw X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=intel-com.20210112.gappssmtp.com header.s=20210112 header.b=JWDZBiIv; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=none (imf26.hostedemail.com: domain of dan.j.williams@intel.com has no SPF policy when checking 209.85.216.47) smtp.mailfrom=dan.j.williams@intel.com X-HE-Tag: 1644963109-495006 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 27, 2022 at 4:41 AM Shiyang Ruan wrote: > > memory_failure_dev_pagemap code is a bit complex before introduce RMAP > feature for fsdax. So it is needed to factor some helper functions to > simplify these code. > > Signed-off-by: Shiyang Ruan > Reviewed-by: Darrick J. Wong > Reviewed-by: Christoph Hellwig Looks good, Reviewed-by: Dan Williams