From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4009C33CA2 for ; Wed, 8 Jan 2020 19:13:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 895FC20705 for ; Wed, 8 Jan 2020 19:13:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="aXBKpkre" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 895FC20705 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 25E0F8E0006; Wed, 8 Jan 2020 14:13:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 20E898E0001; Wed, 8 Jan 2020 14:13:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1245E8E0006; Wed, 8 Jan 2020 14:13:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0117.hostedemail.com [216.40.44.117]) by kanga.kvack.org (Postfix) with ESMTP id F19758E0001 for ; Wed, 8 Jan 2020 14:13:45 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 734324995EE for ; Wed, 8 Jan 2020 19:13:45 +0000 (UTC) X-FDA: 76355416410.24.pie59_780be7caccc17 X-HE-Tag: pie59_780be7caccc17 X-Filterd-Recvd-Size: 4886 Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Wed, 8 Jan 2020 19:13:44 +0000 (UTC) Received: by mail-ot1-f68.google.com with SMTP id d7so4676100otf.5 for ; Wed, 08 Jan 2020 11:13:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=nwzT+0Ljs8ayMxiId4ILWJbQFwhi5ruplGd3VdIX3RM=; b=aXBKpkre4lcb7sMUk8RY7fqYF6hOlQVFhJATgnLjVCY7K15QLYyf7hixiIBa3HZVMC ExlCfpewfRpBKMlrL2bkTmYPm4CaGYlyL7tRjpgwgPPKYXDXxvC/+KRYGg7RVNI+Zch3 OJDriIxWyOMcD19jmlVDHU8kJyYPULCFXFwxijHaC7h6OhkrZpOvqpN/E+KTL4l7U/4j xMaDx7uVFsBEhMyQ6lG95oYF9HfECFKNHuarmwK5/8nBEJr63/BKQtroqLrTIogIYeYL rpBX2fz3/DPf9u8qNUR4UvRqVBL+6fbPeQn8qT6bzEnk6MNhhgAhhL1sSxjlwCfUWh9O nRaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=nwzT+0Ljs8ayMxiId4ILWJbQFwhi5ruplGd3VdIX3RM=; b=ZnCGkbb/4YfVNcxjDk/k+xEKCueJnlts/gloPXWDk5OSWLS3Fs5juOV/TmCcFF5SOL y3DXfAZV4F9lBravVM4d7sVWjRHn1lmKM/Xc8oMfYb75JBZyzIKfU9TyORTqIRjUdeEf ro4ux9T/uDrh9tcoPV42koPeNiHOQY5uLBLF9dKy6m2dbAbNOPV6k8x3z/aEYFnNdICw Q/Vfqx5g5uX4zhEuii0HDq84eVKZOUESp3djfb8U2vx6/gTJavPZcmqDtdJbbYRo+ZSM z4UKVfpwpPDh6m+tkzRO9hfpUyZg4KFEXnS89zUOjX02hyrxg2kD76Fw65tE1hLrbyTD IWug== X-Gm-Message-State: APjAAAX2PxPJHDSgRz3cNMDWR8p7jVlq8v/dUyukRgOYNmqO5wTshs4g BSrxefX+cAzOQrehs5b2IlZxgQbP2IUDBZu2cVdi2Q== X-Google-Smtp-Source: APXvYqyvspS0KBUPu+LfGCtgbi8xLvL1j8+dWGl+2876Wfu60VTn5s+jGWcdaAy33x3gyVzhze0VmNrhk5SnuXfeXQA= X-Received: by 2002:a9d:68d3:: with SMTP id i19mr4986153oto.71.1578510824036; Wed, 08 Jan 2020 11:13:44 -0800 (PST) MIME-Version: 1.0 References: <5D5ED235-EB67-4072-8CCA-C046B7EC031C@redhat.com> In-Reply-To: <5D5ED235-EB67-4072-8CCA-C046B7EC031C@redhat.com> From: Dan Williams Date: Wed, 8 Jan 2020 11:13:33 -0800 Message-ID: Subject: Re: [PATCH v2 2/8] mm/memory_hotplug: Rename mhp_restrictions to mhp_modifiers To: David Hildenbrand Cc: Logan Gunthorpe , Linux Kernel Mailing List , Linux ARM , linux-ia64@vger.kernel.org, linuxppc-dev , linux-s390 , Linux-sh , platform-driver-x86@vger.kernel.org, Linux MM , Michal Hocko , Andrew Morton , Christoph Hellwig , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Eric Badger Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 8, 2020 at 11:08 AM David Hildenbrand wrote: > > > > > Am 08.01.2020 um 20:00 schrieb Dan Williams : > > > > =EF=BB=BFOn Wed, Jan 8, 2020 at 9:17 AM Logan Gunthorpe wrote: > >> > >> > >> > >>> On 2020-01-08 5:28 a.m., David Hildenbrand wrote: > >>> On 07.01.20 21:59, Logan Gunthorpe wrote: > >>>> The mhp_restrictions struct really doesn't specify anything resembli= ng > >>>> a restriction anymore so rename it to be mhp_modifiers. > >>> > >>> I wonder if something like "mhp_params" would be even better. It's > >>> essentially just a way to avoid changing call chains rough-out all ar= chs > >>> whenever we want to add a new parameter. > >> > >> Sure, that does sound a bit nicer to me. I can change it for v3. > > > > Oh, I was just about to chime in to support "modifiers" because I > > would expect all parameters to folded into a "params" struct. The > > modifiers seem to be limited to the set of items that are only > > considered in a non-default / expert memory hotplug use cases. > > > > It=E2=80=98s a set of extended parameters I=E2=80=98d say. Sure, we can call them "mhp_params" and just clarify that they are optional / extended in the kernel-doc. >