From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADF96C4363A for ; Wed, 21 Oct 2020 18:21:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C21142245B for ; Wed, 21 Oct 2020 18:21:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="aI4DCgQQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C21142245B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CBDBD6B005D; Wed, 21 Oct 2020 14:21:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C6D726B0062; Wed, 21 Oct 2020 14:21:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5CE26B0068; Wed, 21 Oct 2020 14:21:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0165.hostedemail.com [216.40.44.165]) by kanga.kvack.org (Postfix) with ESMTP id 8787E6B005D for ; Wed, 21 Oct 2020 14:21:30 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2F9EC3631 for ; Wed, 21 Oct 2020 18:21:30 +0000 (UTC) X-FDA: 77396750340.24.key79_4b05df12724a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 141A91A4A0 for ; Wed, 21 Oct 2020 18:21:30 +0000 (UTC) X-HE-Tag: key79_4b05df12724a X-Filterd-Recvd-Size: 4437 Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Wed, 21 Oct 2020 18:21:29 +0000 (UTC) Received: by mail-ej1-f67.google.com with SMTP id dt13so4579871ejb.12 for ; Wed, 21 Oct 2020 11:21:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=lBYBT2trM0zWLuScJPu/8MEsMxH22DaNGgcD4PxkzgM=; b=aI4DCgQQ2pNgP8FJefkPAHWyeYDZ6gBOdUW5ASwTjCdJPt6/F0D5IUw+ryIpjQNXm7 gK4+rVdRij2UezhsYNKjky15pbLyx71SXm/fZWi7e8Q4m+RVncNlw0/EQHwWG71kG1jW swatZpkYTu5yAZOXhuMbyP3n0EJyZ6Tj4Y/cuYa29u3olktUJdc4M4TJ2rd4I+0DOH8g zGBna8sz6bZsljPuc9avDUo1nfa6ddJFnaen4gYQFZ8z/YYqPo9kDiLM1CATyUVyGmG8 pnWq4b5N/m5mvr9ZCnxufY7oD2D56MpGg2WZMNT6wzDAol9vlUAst1BSJiogsIkNya2g yS+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=lBYBT2trM0zWLuScJPu/8MEsMxH22DaNGgcD4PxkzgM=; b=kNGb7JkVOzQdPFzfnyOAQs/Ely7JlF7avRNoZwRJRMjo7prRsIbZbeK+nqWnLW17Oz 2XK8bE5eYgYBp3crr+P/eQUsMN0tY453ZSuFbb3dEeueQRrCq4Ksdsjjnu/2MQCDhsSw kr3m6bSpSE73UaotGlHQdey+BLZrj2tFLKDF8wNTsEaTIdjvvUqEouAn3gaIBjQNYRE8 kQmTLKz/lb8whBUrgmWLSia4mJ/PNDzKA/qykMyZbE1Vo75z/tNZMPZL8hPXTmGV1P/6 Fab9ycVkzecxBXTuXC/IX5hN7RpTUWiBT6+ilrHsGUDJrnVAASSECEsHH42bKUk6QQJ9 lg+w== X-Gm-Message-State: AOAM531LCLOluC6gQSUdipR3A3Ru+A+y6IbJpglAfaz5FVEe9y9FJVSA oZM3Y19oxUbyjEuI8k31HuoKzUDHNfVZrPcn7B+IyQ== X-Google-Smtp-Source: ABdhPJzA1jSls/Kx/Mwjc1+1+EpDhh/HoRUDuIKQ8K0ggJGziicPcEE6tEKertKBv/kwHwmxQELgJDflTG3MPc+CL3w= X-Received: by 2002:a17:906:c20f:: with SMTP id d15mr4627011ejz.341.1603304487981; Wed, 21 Oct 2020 11:21:27 -0700 (PDT) MIME-Version: 1.0 References: <20201021085655.1192025-1-daniel.vetter@ffwll.ch> <20201021085655.1192025-14-daniel.vetter@ffwll.ch> In-Reply-To: <20201021085655.1192025-14-daniel.vetter@ffwll.ch> From: Dan Williams Date: Wed, 21 Oct 2020 11:21:17 -0700 Message-ID: Subject: Re: [PATCH v3 13/16] /dev/mem: Only set filp->f_mapping To: Daniel Vetter Cc: DRI Development , LKML , KVM list , Linux MM , Linux ARM , linux-samsung-soc , "Linux-media@vger.kernel.org" , linux-s390 , Daniel Vetter , Jason Gunthorpe , Kees Cook , Andrew Morton , John Hubbard , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jan Kara , Daniel Vetter Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 21, 2020 at 1:57 AM Daniel Vetter wrot= e: > > When we care about pagecache maintenance, we need to make sure that > both f_mapping and i_mapping point at the right mapping. > > But for iomem mappings we only care about the virtual/pte side of > things, so f_mapping is enough. Also setting inode->i_mapping was > confusing me as a driver maintainer, since in e.g. drivers/gpu we > don't do that. Per Dan this seems to be copypasta from places which do > care about pagecache consistency, but not needed. Hence remove it for > slightly less confusion. > > Signed-off-by: Daniel Vetter > Cc: Jason Gunthorpe > Cc: Kees Cook > Cc: Dan Williams > Cc: Andrew Morton > Cc: John Hubbard > Cc: J=C3=A9r=C3=B4me Glisse > Cc: Jan Kara > Cc: Dan Williams Reviewed-by: Dan Williams