linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Michal Hocko <mhocko@suse.com>
Cc: David Hildenbrand <david@redhat.com>,
	Linux MM <linux-mm@kvack.org>,
	 LKML <linux-kernel@vger.kernel.org>,
	Oscar Salvador <osalvador@suse.de>
Subject: Re: uninitialized pmem struct pages
Date: Mon, 4 Jan 2021 21:33:06 -0800	[thread overview]
Message-ID: <CAPcyv4jGhvfDeFkY=R9+2QB3vZvRfJ=6s9o29U7msVemGhJjzw@mail.gmail.com> (raw)
In-Reply-To: <20210104155931.GN13207@dhcp22.suse.cz>

On Mon, Jan 4, 2021 at 7:59 AM Michal Hocko <mhocko@suse.com> wrote:
>
> On Mon 04-01-21 16:43:49, David Hildenbrand wrote:
> > On 04.01.21 16:33, Michal Hocko wrote:
> > > On Mon 04-01-21 16:15:23, David Hildenbrand wrote:
> > >> On 04.01.21 16:10, Michal Hocko wrote:
> > > [...]
> > >> Do the physical addresses you see fall into the same section as boot
> > >> memory? Or what's around these addresses?
> > >
> > > Yes I am getting a garbage for the first struct page belonging to the
> > > pmem section [1]
> > > [    0.020161] ACPI: SRAT: Node 0 PXM 0 [mem 0x100000000-0x603fffffff]
> > > [    0.020163] ACPI: SRAT: Node 4 PXM 4 [mem 0x6060000000-0x11d5fffffff] non-volatile
> > >
> > > The pfn without the initialized struct page is 0x6060000. This is a
> > > first pfn in a section.
> >
> > Okay, so we're not dealing with the "early section" mess I described,
> > different story.
> >
> > Due to [1], is_mem_section_removable() called
> > pfn_to_page(PHYS_PFN(0x6060000)). page_zone(page) made it crash, as not
> > initialized.
>
> Exactly!
>
> > Let's assume this is indeed a reserved pfn in the altmap. What's the
> > actual address of the memmap?
>
> Not sure what exactly you are asking for but crash says
> crash> kmem -p 6060000
>       PAGE          PHYSICAL      MAPPING       INDEX CNT FLAGS
> fffff8c600181800     6060000                0        0  0 fffffc0000000
>
> > I do wonder what hosts pfn_to_page(PHYS_PFN(0x6060000)) - is it actually
> > part of the actual altmap (i.e. > 0x6060000) or maybe even self-hosted?
>
> I am not really familiar with the pmem so I would need more assistance
> here. I've tried this (shot into the dark):
> crash> struct page.pgmap fffff8c600181800
>       pgmap = 0xfffff8c600181808

Does /proc/iomem show an active namespace in the range? You should be
able to skip ahead to the first pfn in that namespace to find the
first dev_pagemap. I would have expected pfn_to_online_page() to have
saved you here. This address range is section aligned.


  parent reply	other threads:[~2021-01-05  5:33 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-04 10:03 Michal Hocko
2021-01-04 10:45 ` David Hildenbrand
2021-01-04 14:26   ` Michal Hocko
2021-01-04 14:51     ` David Hildenbrand
2021-01-04 15:10       ` Michal Hocko
2021-01-04 15:15         ` David Hildenbrand
2021-01-04 15:33           ` Michal Hocko
2021-01-04 15:43             ` David Hildenbrand
2021-01-04 15:44               ` David Hildenbrand
2021-01-05  8:00                 ` Michal Hocko
2021-01-05  8:16                   ` Michal Hocko
2021-01-05  8:27                     ` Dan Williams
2021-01-05  8:42                       ` Michal Hocko
2021-01-05  8:57                         ` Dan Williams
2021-01-05  9:05                           ` Michal Hocko
2021-01-05  9:13                             ` David Hildenbrand
2021-01-05  9:25                               ` Michal Hocko
2021-01-05  9:27                                 ` David Hildenbrand
2021-01-04 15:59               ` Michal Hocko
2021-01-04 16:30                 ` David Hildenbrand
2021-01-05  7:44                   ` Michal Hocko
2021-01-05  9:56                     ` David Hildenbrand
2021-01-05  5:33                 ` Dan Williams [this message]
2021-01-05  7:40                   ` Michal Hocko
2021-01-05  5:17   ` Dan Williams
2021-01-05  7:50     ` Michal Hocko
2021-01-05  9:16       ` David Hildenbrand
2021-01-05  9:25     ` David Hildenbrand
2021-01-05  9:33       ` Dan Williams
2021-01-05  9:37         ` David Hildenbrand
2021-01-05  9:56           ` Dan Williams
2021-01-05  9:58             ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPcyv4jGhvfDeFkY=R9+2QB3vZvRfJ=6s9o29U7msVemGhJjzw@mail.gmail.com' \
    --to=dan.j.williams@intel.com \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=osalvador@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox