From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58E21C433DB for ; Sun, 17 Jan 2021 22:35:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B6A702075B for ; Sun, 17 Jan 2021 22:35:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6A702075B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B21056B02DD; Sun, 17 Jan 2021 17:35:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AD1DE6B02DE; Sun, 17 Jan 2021 17:35:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E79A6B02DF; Sun, 17 Jan 2021 17:35:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0210.hostedemail.com [216.40.44.210]) by kanga.kvack.org (Postfix) with ESMTP id 830736B02DD for ; Sun, 17 Jan 2021 17:35:48 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3DBD58249980 for ; Sun, 17 Jan 2021 22:35:48 +0000 (UTC) X-FDA: 77716725576.22.nest88_321656127544 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 234D618038E89 for ; Sun, 17 Jan 2021 22:35:48 +0000 (UTC) X-HE-Tag: nest88_321656127544 X-Filterd-Recvd-Size: 4353 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Sun, 17 Jan 2021 22:35:47 +0000 (UTC) Received: by mail-ej1-f41.google.com with SMTP id g12so21094854ejf.8 for ; Sun, 17 Jan 2021 14:35:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ulnCSQ44YUhN9X9MAQEMcAc8eh88jI5ZhULk5yuUjlY=; b=nH6qQH3CSPydxTALD0skXPT4yCLrsSN7lTRp33mztLs5kVypDJKD4NNP92U3YRluSZ V+hoAv2K5mVRcBQ5S3eeqQDll9xwE7NEfJAmv4WqMBrWXiERvLx0mWx4l+AXB3Q/2dMg Zr7Hg6UBkpaPU34GaYIwFVG+jxpiO9LoUhfmMD5oKP6EkYO1wTjH/J6DDvTMJfMcO/f8 NnsawZSVh+dT1z7sADQMkyeF3waZCMRoP6LGK4ken2P/hV2gykYfNU9OdBI6XPXsB2tF QObiY285JpBicH0RDp2SUsdQ8Y584b9e1XuwY7V44Nfpdc7t8FZ+1MqczgTeDNmHQFwI sA7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ulnCSQ44YUhN9X9MAQEMcAc8eh88jI5ZhULk5yuUjlY=; b=eyKEiZx4wEhO6vpX9bm/sVPx4Junn6WHddXvt3MUyi68+JhyBGu9ghTso6gl7ZVyTv gzR13lPuvfVeuwf6KyXVUKOWOdC8DCRrxbrN3gbsk9EqZL3ttZo1f9upqGMGiWAcvIhM qmHe0nGkYYmcLZAuxBlsQV1e3saxYvZHLupwaRLiyR5QOfH8q8CaLuTal2O8bOx3nONr n4uUL/aiZO7SV8hYLmn5V4XSMIDp0ZUPIcZtu80qk4PemA8G1tHrPc/Ji+C+vk/Y8S8H iOe6ttx9NOC2rWLZJ64G+GjEBuAqTJ9pTK7gyGzX1ycN9uGhNqAtII6Eyn43UnWHJ8SV yW/g== X-Gm-Message-State: AOAM532dtsocogHPeeS/dicXEf5ZMWx8qLdo6V2lEJ/jpP30g4FKWRt4 ug8xYH9KVxcjnJojxFBNY8GFA61J0iT5kagWIo5wTA== X-Google-Smtp-Source: ABdhPJykQ4aN9XzIZG+k5ieNSCq/ExStxGPgoeTqRdHv4EkpXsssxJrXDWF2Ue2urWeIOyT9kmFppL4L52qSdP+zDxY= X-Received: by 2002:a17:906:e085:: with SMTP id gh5mr951255ejb.418.1610922945887; Sun, 17 Jan 2021 14:35:45 -0800 (PST) MIME-Version: 1.0 References: <161058499000.1840162.702316708443239771.stgit@dwillia2-desk3.amr.corp.intel.com> <161058501210.1840162.8108917599181157327.stgit@dwillia2-desk3.amr.corp.intel.com> <20210117140142.ab91797266e0bef6b7dba9f9@linux-foundation.org> In-Reply-To: <20210117140142.ab91797266e0bef6b7dba9f9@linux-foundation.org> From: Dan Williams Date: Sun, 17 Jan 2021 14:35:36 -0800 Message-ID: Subject: Re: [PATCH v4 4/5] mm: Fix page reference leak in soft_offline_page() To: Andrew Morton Cc: Naoya Horiguchi , Michal Hocko , David Hildenbrand , Oscar Salvador , stable , Linux MM , linux-nvdimm , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jan 17, 2021 at 2:01 PM Andrew Morton wrote: > > On Wed, 13 Jan 2021 16:43:32 -0800 Dan Williams wrote: > > > The conversion to move pfn_to_online_page() internal to > > soft_offline_page() missed that the get_user_pages() reference taken by > > the madvise() path needs to be dropped when pfn_to_online_page() fails. > > Note the direct sysfs-path to soft_offline_page() does not perform a > > get_user_pages() lookup. > > > > When soft_offline_page() is handed a pfn_valid() && > > !pfn_to_online_page() pfn the kernel hangs at dax-device shutdown due to > > a leaked reference. > > > > Fixes: feec24a6139d ("mm, soft-offline: convert parameter to pfn") > > Cc: Andrew Morton > > Cc: Naoya Horiguchi > > Cc: Michal Hocko > > Reviewed-by: David Hildenbrand > > Reviewed-by: Oscar Salvador > > Cc: > > Signed-off-by: Dan Williams > > A cc:stable patch in the middle is awkward. I'll make this a > standalone patch for merging into mainline soon (for 5.11) and shall > turn the rest into a 4-patch series, OK? Sounds good to me.