From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A556EC33CA3 for ; Fri, 10 Jan 2020 21:30:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 618A72082E for ; Fri, 10 Jan 2020 21:30:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="dCEwU9oc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 618A72082E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 014FF8E0005; Fri, 10 Jan 2020 16:30:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F07618E0001; Fri, 10 Jan 2020 16:30:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1CE48E0005; Fri, 10 Jan 2020 16:30:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0185.hostedemail.com [216.40.44.185]) by kanga.kvack.org (Postfix) with ESMTP id CD54D8E0001 for ; Fri, 10 Jan 2020 16:30:00 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 788475DC1 for ; Fri, 10 Jan 2020 21:30:00 +0000 (UTC) X-FDA: 76363017360.23.cook82_74544334af361 X-HE-Tag: cook82_74544334af361 X-Filterd-Recvd-Size: 3795 Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Fri, 10 Jan 2020 21:29:59 +0000 (UTC) Received: by mail-oi1-f196.google.com with SMTP id l136so3186133oig.1 for ; Fri, 10 Jan 2020 13:29:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=n2mxxlKQ3z5GTVr0sFZ/UO3UPo2+qy5+H2Pzt1Zkygo=; b=dCEwU9ocO7qaLRqzQSLmYs/X59vGdpavT680mPOTiWdjYqJpoXuFoEB85fEAbl/R3p /y3AKOYu3spzlXqH/C61jCHa9TIHmuFBmGDnoA5qtqUaZmeSgyxy3V1zTF0Elay4sM09 u0Ul91Reo0p8yrhytuqg9BsiOFdgxiv50nTGAt9IOy3SYbLoOoyFhWgvWsZVN6lPg6VG IFp7ItvVS2lWbifAFtj5ruAuABfk1/GLKmZ7tTkhRQxlrzDPIJFrv8+QoU3gi4HLluQO 0kns4yL3aTNMjHPY/3bhjJxF58/xBa22EVXeeDBGQUCDPEQCTpMi86FzgDz1gulGpc8E n5Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n2mxxlKQ3z5GTVr0sFZ/UO3UPo2+qy5+H2Pzt1Zkygo=; b=DORcuDsRn/ev/M7IP8vdz3wvMzf78VDcJgtdq2Wz5C0ge3adf4YtWhajKUNr8ptRDl +BxRG9Y7m2URs2bVTJyiAL4xyYTZF+gvRhm50kOmM60XwOKJiysEu9MeCmQIE2iuOGEK S4zPN+XXIfqRIRQox9IqMGw4asDN3q5saQmdI4VdTkRTLlfAPbcf6wUtk4YUk3ne7ALU nzCbYPFGbjAZnMJKzP2kvQYQFIM+xSTetzHaez0GXohZX/z0Ku8CXi6g/YJumo6slvhG YBHhnz9KxOHKYRK63XGk+Rg7lDDXuu+kN5fLD0mnKP/xChQXyBDwxavu+xYFZZcTVB1i 19rg== X-Gm-Message-State: APjAAAXiTi+8y1yXxzWmJyLJAGZ1Qt5/RAWi0Dt77iVEOPXmfSFWj01b caBVEQSuXzD146O+OEyjhGMXsEU4eTnIHgXsfOIYyg== X-Google-Smtp-Source: APXvYqwxQz8fxi8L1VftblbeLJlRU9OyUs7b4BgCeeRqP9aOQVdGF6FRWI3UMAhHXqhXuMwGJ1X7oILHYEfQbi0fDDE= X-Received: by 2002:aca:3f54:: with SMTP id m81mr3657692oia.73.1578691798574; Fri, 10 Jan 2020 13:29:58 -0800 (PST) MIME-Version: 1.0 References: <157868988882.2387473.11703138480034171351.stgit@dwillia2-desk3.amr.corp.intel.com> In-Reply-To: <157868988882.2387473.11703138480034171351.stgit@dwillia2-desk3.amr.corp.intel.com> From: Dan Williams Date: Fri, 10 Jan 2020 13:29:47 -0800 Message-ID: Subject: Re: [PATCH v3] mm/memory_hotplug: Fix remove_memory() lockdep splat To: Andrew Morton Cc: stable , Vishal Verma , David Hildenbrand , Pavel Tatashin , Michal Hocko , Dave Hansen , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 10, 2020 at 1:16 PM Dan Williams wrote: [..] > Changes since v2 [1]: > - Apologies I overlooked that I had local changes in my tree to fix a > compiler error (misspelled assert_held_device_hotplug()). Now fixed > up. > [..] > diff --git a/include/linux/device.h b/include/linux/device.h > index 96ff76731e93..e042da3b1953 100644 > --- a/include/linux/device.h > +++ b/include/linux/device.h > @@ -1553,6 +1553,7 @@ static inline bool device_supports_offline(struct device *dev) > extern void lock_device_hotplug(void); > extern void unlock_device_hotplug(void); > extern int lock_device_hotplug_sysfs(void); > +extern void assert_held_device_hotlpug(void); Argh, did it again. I definitely need to fix stg mail to not send patches while there are local changes pending in the tree.