From: Dan Williams <dan.j.williams@intel.com>
To: Muchun Song <songmuchun@bytedance.com>
Cc: Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>,
Al Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Alistair Popple <apopple@nvidia.com>,
Yang Shi <shy828301@gmail.com>,
Ralph Campbell <rcampbell@nvidia.com>,
Hugh Dickins <hughd@google.com>,
xiyuyang19@fudan.edu.cn,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Ross Zwisler <zwisler@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux NVDIMM <nvdimm@lists.linux.dev>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
duanxiongchun@bytedance.com, Muchun Song <smuchun@gmail.com>
Subject: Re: [PATCH v4 2/6] dax: fix cache flush on PMD-mapped pages
Date: Wed, 9 Mar 2022 16:06:05 -0800 [thread overview]
Message-ID: <CAPcyv4j7rn8OzWKydcCJNXdrhXm6h6Vq5n7uLzP5BSMJ_qSZgg@mail.gmail.com> (raw)
In-Reply-To: <20220302082718.32268-3-songmuchun@bytedance.com>
On Wed, Mar 2, 2022 at 12:29 AM Muchun Song <songmuchun@bytedance.com> wrote:
>
> The flush_cache_page() only remove a PAGE_SIZE sized range from the cache.
> However, it does not cover the full pages in a THP except a head page.
> Replace it with flush_cache_range() to fix this issue.
This needs to clarify that this is just a documentation issue with the
respect to properly documenting the expected usage of cache flushing
before modifying the pmd. However, in practice this is not a problem
due to the fact that DAX is not available on architectures with
virtually indexed caches per:
d92576f1167c dax: does not work correctly with virtual aliasing caches
Otherwise, you can add:
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
next prev parent reply other threads:[~2022-03-10 0:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 8:27 [PATCH v4 0/6] Fix some bugs related to ramp and dax Muchun Song
2022-03-02 8:27 ` [PATCH v4 1/6] mm: rmap: fix cache flush on THP pages Muchun Song
2022-03-10 0:01 ` Dan Williams
2022-03-02 8:27 ` [PATCH v4 2/6] dax: fix cache flush on PMD-mapped pages Muchun Song
2022-03-10 0:06 ` Dan Williams [this message]
2022-03-10 13:48 ` Muchun Song
2022-03-02 8:27 ` [PATCH v4 3/6] mm: rmap: introduce pfn_mkclean_range() to cleans PTEs Muchun Song
2022-03-10 0:26 ` Dan Williams
2022-03-10 0:40 ` Dan Williams
2022-03-02 8:27 ` [PATCH v4 4/6] mm: pvmw: add support for walking devmap pages Muchun Song
2022-03-02 8:27 ` [PATCH v4 5/6] dax: fix missing writeprotect the pte entry Muchun Song
2022-03-10 0:59 ` Dan Williams
2022-03-11 9:04 ` Muchun Song
2022-03-14 20:50 ` Dan Williams
2022-03-15 7:51 ` Muchun Song
2022-03-02 8:27 ` [PATCH v4 6/6] mm: remove range parameter from follow_invalidate_pte() Muchun Song
2022-03-10 1:02 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4j7rn8OzWKydcCJNXdrhXm6h6Vq5n7uLzP5BSMJ_qSZgg@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=duanxiongchun@bytedance.com \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nvdimm@lists.linux.dev \
--cc=rcampbell@nvidia.com \
--cc=shy828301@gmail.com \
--cc=smuchun@gmail.com \
--cc=songmuchun@bytedance.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=xiyuyang19@fudan.edu.cn \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox