From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9B34C433EF for ; Thu, 10 Mar 2022 00:01:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89D538D0005; Wed, 9 Mar 2022 19:01:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 84D168D0001; Wed, 9 Mar 2022 19:01:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73C288D0005; Wed, 9 Mar 2022 19:01:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0210.hostedemail.com [216.40.44.210]) by kanga.kvack.org (Postfix) with ESMTP id 656868D0001 for ; Wed, 9 Mar 2022 19:01:57 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1296B8248D52 for ; Thu, 10 Mar 2022 00:01:57 +0000 (UTC) X-FDA: 79226523474.24.0E9EB50 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by imf24.hostedemail.com (Postfix) with ESMTP id 23A2D180014 for ; Thu, 10 Mar 2022 00:01:55 +0000 (UTC) Received: by mail-pg1-f181.google.com with SMTP id e6so3300757pgn.2 for ; Wed, 09 Mar 2022 16:01:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PUB8geEpJ+XtoTHFW5CyzSR89RxzbZocHBgXZDsT0q4=; b=otdsgu05707Lk9KMy9Xl5aGoGpb6RqPU5UPULqEDsN/2l0x6ZW4fwG3smZmmXYgccr uSOZID4KxBtbRYlE+5DzLmbTAZ+0UWldA4oJxDpKPrEnop8Fo9ENjzluPuJpHAt/f0Ph JWHz1tJmUUKYOA51azuWN3u/HBuHP6xKdAEKkTinas859+sluZ5V6iIwToVN0w545JZ0 3MztadxrOxyAdk25++05k8H4fZKxTQ71SQh5zMwp9yN8iMhkMaVGQTUzYKS4c55c7s98 4/Uv6gYvdgNlFaNfigcT3+pjUGlyDppfCnmg8Tgo1wa+NEPrmpAzqwTGnItaDus8dWJS vbZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PUB8geEpJ+XtoTHFW5CyzSR89RxzbZocHBgXZDsT0q4=; b=Nys+Yk1OpufBb5VC5i7oERF0tLb2VpDtGRK1mhNeHEILvRCOH7KFM1D9doqh/hh82S QmIfJFSXBpvhPHzZahv5rSHn18BCe+D+WLX8tC1Z8VC+5Fnx9uczBm5RhH+k10/0I8rk HqbxAxlXcYu6H5GQJPNHZDyiT/CZ5hxzHI/WFCPnuZVp9B7uA14b9dwN/t/A0BbTy8QZ 4POjkn6dptR+KQDtNCesDCZrLMxSzFLwGMxk3GBp/G8q45Gfvit/wZk9cJbsJokQp8uC 8K6DZZhVnYz1NrpilPWgSgXxI1M9BVkPR4jzUeOoxxKlcXsvCtJyAyWM93ikGpLDhuep Cecg== X-Gm-Message-State: AOAM533DUqISHQ021zhhxBQCWFCjJFNuFCfXON+5MpUJQT2bMklldTtS 6CZOzjKh6NN/KSA9icrehmGcpZXFbdwM5u+JLfsZYg== X-Google-Smtp-Source: ABdhPJxMwIgsbbMlOTDNiL7M3O6I5DfVtqlrxkmc58HdiEKBYmj4+VrHYnD7h5nPhaUJdRIDGvR7mrBpMKdCiPBYlTI= X-Received: by 2002:a05:6a02:283:b0:342:703e:1434 with SMTP id bk3-20020a056a02028300b00342703e1434mr1821136pgb.74.1646870515046; Wed, 09 Mar 2022 16:01:55 -0800 (PST) MIME-Version: 1.0 References: <20220302082718.32268-1-songmuchun@bytedance.com> <20220302082718.32268-2-songmuchun@bytedance.com> In-Reply-To: <20220302082718.32268-2-songmuchun@bytedance.com> From: Dan Williams Date: Wed, 9 Mar 2022 16:01:44 -0800 Message-ID: Subject: Re: [PATCH v4 1/6] mm: rmap: fix cache flush on THP pages To: Muchun Song Cc: Matthew Wilcox , Jan Kara , Al Viro , Andrew Morton , Alistair Popple , Yang Shi , Ralph Campbell , Hugh Dickins , xiyuyang19@fudan.edu.cn, "Kirill A. Shutemov" , Ross Zwisler , Christoph Hellwig , linux-fsdevel , Linux NVDIMM , Linux Kernel Mailing List , Linux MM , duanxiongchun@bytedance.com, Muchun Song Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 23A2D180014 X-Stat-Signature: jxdgu8tckm4oqthxonxgd9yguo5waj43 Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel-com.20210112.gappssmtp.com header.s=20210112 header.b=otdsgu05; spf=none (imf24.hostedemail.com: domain of dan.j.williams@intel.com has no SPF policy when checking 209.85.215.181) smtp.mailfrom=dan.j.williams@intel.com; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=intel.com (policy=none) X-HE-Tag: 1646870515-320316 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 2, 2022 at 12:29 AM Muchun Song wrote: > > The flush_cache_page() only remove a PAGE_SIZE sized range from the cache. > However, it does not cover the full pages in a THP except a head page. > Replace it with flush_cache_range() to fix this issue. At least, no > problems were found due to this. Maybe because the architectures that > have virtual indexed caches is less. > > Fixes: f27176cfc363 ("mm: convert page_mkclean_one() to use page_vma_mapped_walk()") > Signed-off-by: Muchun Song > Reviewed-by: Yang Shi Reviewed-by: Dan Williams