From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5571C433B4 for ; Tue, 20 Apr 2021 00:33:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2216861363 for ; Tue, 20 Apr 2021 00:33:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2216861363 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8C00E6B0036; Mon, 19 Apr 2021 20:33:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8714E6B006E; Mon, 19 Apr 2021 20:33:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 710B76B0070; Mon, 19 Apr 2021 20:33:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0081.hostedemail.com [216.40.44.81]) by kanga.kvack.org (Postfix) with ESMTP id 571A46B0036 for ; Mon, 19 Apr 2021 20:33:22 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1B3C18249980 for ; Tue, 20 Apr 2021 00:33:22 +0000 (UTC) X-FDA: 78050871444.01.AE314E5 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by imf29.hostedemail.com (Postfix) with ESMTP id D8958132 for ; Tue, 20 Apr 2021 00:33:18 +0000 (UTC) Received: by mail-ed1-f51.google.com with SMTP id h8so2754768edb.2 for ; Mon, 19 Apr 2021 17:33:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Pz/zpqrNsXBLRBdAANHO3s6ykIZgjKdFVra10NB441U=; b=GWIugcBbcAEFKrQ7DDpWfxxRc3DQvHV5d/FzDpNeto/wqSVixA7QawBw2XoAQRgG3g vWVZPSG8itZARpLSizOZgsuHdTeLOK1QzPIzF+ThWtfcpeyK9QSyGkP7H9rCatjG96MY 2lXHJufdm4v+ezEQ3fr1BoXCbvSajStrFMVkqw+40YkhkBDLJ9FJJld2MG40iFjwogQ+ 2y18utHnsKAnGM9foiaIiY6ANkq0mk2cyfruHK6/A++jE+MY6vRoq9bkob9/MxOgTqJb mBLSSRkQ0PtDYSoW4pLZmjzF1l/zGfLc6i24RWD1RUQxYfbw4KzdQHWa2U4grsPnf4KF q2FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Pz/zpqrNsXBLRBdAANHO3s6ykIZgjKdFVra10NB441U=; b=Fdinyftl4TSmFsBiwRimGlKAF+D1EjLshxeVO+FLWPxteV3YLFZ2KlLMMHdJfV88lC qdRUcU3v69jC2bqFJOOvPMAPYdtrBf4c4burhWBV1sNsI6Rp5jZMBBy9XS3fP43NI6Fj uUss0P+tM8ZLufXrGDg6r+o/RtPeWBu4CoJeaBgMBBQKRd0ia7DZsAbYEwlzwj4L5Kow D9M9ZAvkcV6I6CuwI3e9OVen91yQkCpYKTGUE+G0ikYOos8STYOA8sXS7n1jYKeSi5Gx cLkEd1Mpz7mSqFHUHHQ8ei58kaRKvD+z/tAqbFZk94csYytA1xtE00rjvgjAHTlwS+oX Gl5g== X-Gm-Message-State: AOAM532JF0KqVlypcuxyfYgqRvFFDd/qdSO2I1EJbbY5W19jh1welXEd qkGyWwEYWoOACFypYgxIhRbN9UZRbXl1eumknXcENg== X-Google-Smtp-Source: ABdhPJyJxDW+nX58cu0dv51Y5mvuJVcqennaSe9Wn9IA4DG203YPUfU/I8YqJLRMN94aW2jdMp0mvm7HVwx4XH4XmmA= X-Received: by 2002:a05:6402:35c8:: with SMTP id z8mr4181007edc.210.1618878799838; Mon, 19 Apr 2021 17:33:19 -0700 (PDT) MIME-Version: 1.0 References: <20210420002821.2749748-1-jane.chu@oracle.com> In-Reply-To: <20210420002821.2749748-1-jane.chu@oracle.com> From: Dan Williams Date: Mon, 19 Apr 2021 17:33:10 -0700 Message-ID: Subject: Re: [PATCH] mm/memory-failure: unecessary amount of unmapping To: Jane Chu Cc: Naoya Horiguchi , Dave Jiang , Andrew Morton , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D8958132 X-Stat-Signature: e9oe9m3np891757635w49eyohoqi9gj8 Received-SPF: none (intel.com>: No applicable sender policy available) receiver=imf29; identity=mailfrom; envelope-from=""; helo=mail-ed1-f51.google.com; client-ip=209.85.208.51 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618878798-134008 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000052, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 19, 2021 at 5:28 PM Jane Chu wrote: > > It appears that unmap_mapping_range() actually takes a 'size' as its > third argument rather than a location, Indeed. > the current calling fashion > causes unecessary amount of unmapping to occur. s/unecessary/unnecessary/ > > Fixes: 6100e34b2526e ("mm, memory_failure: Teach memory_failure() about dev_pagemap pages") > Signed-off-by: Jane Chu Other than changelog fixup, looks good. Reviewed-by: Dan Williams > --- > mm/memory-failure.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index f7ed9559d494..85ad98c00fd9 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -1368,7 +1368,7 @@ static int memory_failure_dev_pagemap(unsigned long pfn, int flags, > * communicated in siginfo, see kill_proc() > */ > start = (page->index << PAGE_SHIFT) & ~(size - 1); > - unmap_mapping_range(page->mapping, start, start + size, 0); > + unmap_mapping_range(page->mapping, start, size, 0); > } > kill_procs(&tokill, flags & MF_MUST_KILL, !unmap_success, pfn, flags); > rc = 0; > -- > 2.18.4 >