From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23D3FC433EF for ; Sat, 30 Oct 2021 01:45:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 920A6610D0 for ; Sat, 30 Oct 2021 01:45:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 920A6610D0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B9FB1940008; Fri, 29 Oct 2021 21:45:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B4FC8940007; Fri, 29 Oct 2021 21:45:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9EF8D940008; Fri, 29 Oct 2021 21:45:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0169.hostedemail.com [216.40.44.169]) by kanga.kvack.org (Postfix) with ESMTP id 75327940007 for ; Fri, 29 Oct 2021 21:45:00 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D8C538249980 for ; Sat, 30 Oct 2021 01:44:59 +0000 (UTC) X-FDA: 78751410318.23.89685A3 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by imf26.hostedemail.com (Postfix) with ESMTP id 0BDAE20019C0 for ; Sat, 30 Oct 2021 01:44:59 +0000 (UTC) Received: by mail-pg1-f176.google.com with SMTP id x5so1693792pgk.11 for ; Fri, 29 Oct 2021 18:44:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZKTw3bz9bxgBBAoCCzkjGx+o8K0N/KdabvDcNy3fVRM=; b=u08qxRJATUG7LTmmZF39rZHz0BSUlFRnDdaOp/cdJWtUoPJsIzug9rkcp+xiLOw5vu ajIppaB0A2iI3j/uQ13t6VuTfDGdvC3Gz8/SA/3ycf+eSsHP02uwaNtfI67n0g/ECi0u T047O2AaNu6qLF+GT16jjZCbnAd0ruj8f7tKmc1d6JLXBki8FprZ4LU3gNRBC0uCiosq DTs/ZB7UjIX1MJuf8o2X0u3RII1uHRbJonbI4AJF4TiQJsiYdmCrjKAi3LRxa5lfFWXw 2JjyJx73m9zz7Zi/WdyVGbCrIrrXQ9HQiO7BB4e/fdcfjoP3f8oPLsmA5/HEiPiR/aPw nTgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZKTw3bz9bxgBBAoCCzkjGx+o8K0N/KdabvDcNy3fVRM=; b=yiLLN9+Oyc5iD2xBWxv77NyDRnz28GYaN0ijCMdLm0XONhrYBQ+PG8XMTCoHLcPNls 6VQQZ6LAunHmhcVvjqxfSOAyz57fhRMI2iKefFLlRBuRsl93n3fhJc1TQwQz6Suynv5l 1F3jC43bIw2u9olc2kN4BACH+rqWndqmJ45wjayedLGq6WM2hNixDrYoDGiWYmQkKLFP FS07Kqc5/YuLu4EpRa8ucXEQlYx5P7d9Fe8pKFqFlFZQAX6rrqagDkehVw/BCS0z1AMw xYhukY0VzI0wKYSpiipDfoaqcvXR+E+jXWIb3uYMBjcn7ubyw7vZQyvWb2fvuAgV5IHZ sfoA== X-Gm-Message-State: AOAM532+xGHtDiDZXFnDQAR0mZaZk5++xqWNyxHuZNPhYQ4mzmt0cGtr 1QZ4PdeUEgX9ejIJuHonQamBJrBMSnh3HiG1IvDrlA== X-Google-Smtp-Source: ABdhPJyPeYadoFfvpDR8yMdDrQVQwbm98jsSV/axBDYgDY32qbHU1LM0JZktTDnAN6vHey7+r8ZZo2vb4sjam6zknQs= X-Received: by 2002:aa7:8019:0:b0:44d:d761:6f79 with SMTP id j25-20020aa78019000000b0044dd7616f79mr14625339pfi.3.1635558297759; Fri, 29 Oct 2021 18:44:57 -0700 (PDT) MIME-Version: 1.0 References: <163543595723.2281838.11942022992765100714.stgit@dwillia2-desk3.amr.corp.intel.com> <53eaa74c-0cfb-a333-4e57-8f59949b91e9@oracle.com> In-Reply-To: <53eaa74c-0cfb-a333-4e57-8f59949b91e9@oracle.com> From: Dan Williams Date: Fri, 29 Oct 2021 18:44:46 -0700 Message-ID: Subject: Re: [PATCH] dax: Kill DEV_DAX_PMEM_COMPAT To: Jane Chu Cc: "nvdimm@lists.linux.dev" , Ira Weiny , Dave Jiang , Dave Hansen , Vishal Verma , "linux-mm@kvack.org" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0BDAE20019C0 X-Stat-Signature: 8ga7dcdpwk1515yicx5wzugj4f7tdh3r Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=intel-com.20210112.gappssmtp.com header.s=20210112 header.b=u08qxRJA; spf=none (imf26.hostedemail.com: domain of dan.j.williams@intel.com has no SPF policy when checking 209.85.215.176) smtp.mailfrom=dan.j.williams@intel.com; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=intel.com (policy=none) X-HE-Tag: 1635558299-357886 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 29, 2021 at 5:19 PM Jane Chu wrote: > > Hi, Dan, > > I think we're still using _COMPAT, but likely don't need to. Ugh, really? I hope not, that would be unfortunate. Perhaps are you using libndctl / libdaxctl rather than going to /sys/class/dax directly? Those have shipped backwards compatibility for a while now, so applications using those libraries should not notice the switch to the /sys/bus/dax ABI. The only other open source application I could find that had /sys/class/dax dependencies was fio, but I fixed that up years ago as well. > What is your patch based on? This is based on a branch I have with Christoph's recent dax reworks. I have a test merge of that pushed out on my libnvdimm-pending branch if you want to give it a try. https://git.kernel.org/pub/scm/linux/kernel/git/djbw/nvdimm.git/log/?h=libnvdimm-pending