From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B100C00A89 for ; Sat, 31 Oct 2020 01:54:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EDCA320731 for ; Sat, 31 Oct 2020 01:54:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="xMgBvat1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EDCA320731 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 006886B0036; Fri, 30 Oct 2020 21:54:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF8AD6B005C; Fri, 30 Oct 2020 21:54:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0DF96B005D; Fri, 30 Oct 2020 21:54:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0120.hostedemail.com [216.40.44.120]) by kanga.kvack.org (Postfix) with ESMTP id B1D166B0036 for ; Fri, 30 Oct 2020 21:54:52 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 5BB543625 for ; Sat, 31 Oct 2020 01:54:52 +0000 (UTC) X-FDA: 77430552024.28.aunt83_20184b32729a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 441046D74 for ; Sat, 31 Oct 2020 01:54:52 +0000 (UTC) X-HE-Tag: aunt83_20184b32729a X-Filterd-Recvd-Size: 4764 Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Sat, 31 Oct 2020 01:54:51 +0000 (UTC) Received: by mail-ej1-f67.google.com with SMTP id dk16so10516618ejb.12 for ; Fri, 30 Oct 2020 18:54:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vpps4QHXRxAMWPFAR6czMYTEeayKSB9a8gYwfl7iFEI=; b=xMgBvat1GLEvW0fGY01bhphopLs3WOKfAtrbUsY+cIPkQa45srH0eqnAFGv+z08azC kLefbpLW4GHeuhi4n9L8s0a7Hp1yRDuYfCE5eqONmCQYvqOZNspfKmeYiNuqLRRx/U2/ ai0YXm9lzf6GW4Z0HeXsoMYwnli+NS/cskD5riX/1B5U75T/v4TJmHSaTn0nN+trNjpo GtZbPEuUCosr3tosa7RcWprdV0O/9YYkSMYac0jc00VaI0E2OGVqIeokbrJJCHgb8xPe lH0V2nUPonZ5QoXAxaOC263dFHbuAz81zEhNMK+h9JQGygXyPtMBvipltnVwIj+qCkDt 8yBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vpps4QHXRxAMWPFAR6czMYTEeayKSB9a8gYwfl7iFEI=; b=eJ4MmTwegfSnXV7ELV3uSbdk/OSjTOc6P2F+tRUqA0YketSazkbptDlMUY5iDIrGxE Hu823dk1fvtXs7fAvzlzQGsD5sdyDRpe+OwQt1Do0WP0U2hCD5+U5SLH9HoG3ZieaJTV WH2zHUT4nYuQABPZfilCrBFj8YnYsTIA3RERpDIUqEsPN6R1l7Dq8/cYp8Nga1wh0Qe0 JGONlfbYrgb4OGE2pOVV301yU8XiEOl9xcAOA5ZKAJsYHvuy/P0nBKNCzGC6dnbKfb3I +VzNc7Fyya/XDyQ9qqSdSjx56+AKZmqpLXPv0b2Jzm6AEnAb8EhLLeZKQ3ivL1YjKhLw GQ/Q== X-Gm-Message-State: AOAM532oGGb7pFFJDuDQopbTuae8gTQvv1tPYwPDQ8l2RAfmJ6Yejgt7 n2RK0+dAGQKMByfXGTV4VVtEOA5BJPvpiK/z4WG9Qw== X-Google-Smtp-Source: ABdhPJwE7ZPoBTwgrT+kma8o/mNUUfsoxmBQwgeIO/t7I9Hk1RYtvCMijglyFYF+OEPZDKqXOEuytkR6bSX2Ogh4528= X-Received: by 2002:a17:906:d92c:: with SMTP id rn12mr2910812ejb.472.1604109290015; Fri, 30 Oct 2020 18:54:50 -0700 (PDT) MIME-Version: 1.0 References: <160402498564.4173389.2743697400148832021.stgit@dwillia2-desk3.amr.corp.intel.com> In-Reply-To: <160402498564.4173389.2743697400148832021.stgit@dwillia2-desk3.amr.corp.intel.com> From: Dan Williams Date: Fri, 30 Oct 2020 18:54:35 -0700 Message-ID: Subject: Re: [PATCH] x86/mm: Fix phys_to_target_node() export To: Andrew Morton Cc: Randy Dunlap , Thomas Gleixner , kernel test robot , Joao Martins , X86 ML , Vishal Verma , Linux MM , linux-nvdimm Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 29, 2020 at 7:29 PM Dan Williams wrote: > > The core-mm has a default __weak implementation of phys_to_target_node() > when the architecture does not override it. That symbol is exported > for modules. However, while the export in mm/memory_hotplug.c exported > the symbol in the configuration cases of: > > CONFIG_NUMA_KEEP_MEMINFO=y > CONFIG_MEMORY_HOTPLUG=y > > ...and: > > CONFIG_NUMA_KEEP_MEMINFO=n > CONFIG_MEMORY_HOTPLUG=y > > ...it failed to export the symbol in the case of: > > CONFIG_NUMA_KEEP_MEMINFO=y > CONFIG_MEMORY_HOTPLUG=n > > Always export the symbol from the CONFIG_NUMA_KEEP_MEMINFO section of > arch/x86/mm/numa.c, and teach mm/memory_hotplug.c to optionally export > in case arch/x86/mm/numa.c has already performed the export. > > The dependency on NUMA_KEEP_MEMINFO for DEV_DAX_HMEM_DEVICES is invalid > now that the symbol is properly exported in all combinations of > CONFIG_NUMA_KEEP_MEMINFO and CONFIG_MEMORY_HOTPLUG. Note that in the > CONFIG_NUMA=n case no export is needed since their is a dummy static > inline implementation of phys_to_target_node() in that case. > > Reported-by: Randy Dunlap > Reported-by: Thomas Gleixner > Reported-by: kernel test robot > Fixes: a035b6bf863e ("mm/memory_hotplug: introduce default phys_to_target_node() implementation") > Cc: Joao Martins > Cc: Andrew Morton > Cc: x86@kernel.org > Cc: Vishal Verma > Signed-off-by: Dan Williams Thomas, do you want to ack this so Andrew can pick it up, or I can take it through as a device-dax update, but either way the diffstat warrants x86 + mm acks.