From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D97E4C433E0 for ; Tue, 16 Jun 2020 16:59:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9F39F20B1F for ; Tue, 16 Jun 2020 16:59:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="P6F/6Li0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F39F20B1F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2B3588D0021; Tue, 16 Jun 2020 12:59:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2648A8D0006; Tue, 16 Jun 2020 12:59:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12C928D0021; Tue, 16 Jun 2020 12:59:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0098.hostedemail.com [216.40.44.98]) by kanga.kvack.org (Postfix) with ESMTP id ECDAE8D0006 for ; Tue, 16 Jun 2020 12:59:54 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6CA5118528503 for ; Tue, 16 Jun 2020 16:59:54 +0000 (UTC) X-FDA: 76935687108.22.iron62_59008c526e00 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 44721181BD370 for ; Tue, 16 Jun 2020 16:59:54 +0000 (UTC) X-HE-Tag: iron62_59008c526e00 X-Filterd-Recvd-Size: 5455 Received: from mail-ej1-f66.google.com (mail-ej1-f66.google.com [209.85.218.66]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Tue, 16 Jun 2020 16:59:53 +0000 (UTC) Received: by mail-ej1-f66.google.com with SMTP id y13so22338930eju.2 for ; Tue, 16 Jun 2020 09:59:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9c3XpUNRuxc8tvHN/G/s1TeMtn7R53E47RIpJ3K1Kjo=; b=P6F/6Li0cNofNpVQGyh790TSj0hnEC9itlHPgIsadxqJsMTv2HLDoSobSlbltEfUh2 vsx03Q2EGLSEX7+lQl/MFwECf5bdmgM/HEP7HOpYfqkTdczVCH17cPrTGFDJe3AEkS5o pf8zQoNctOFIsW4Qb46xAtZ3QA+nKYUdOu7KlruHzayUM/3u36JTjcwVVu7dI78fRVEu i5HYmeba9xv0+8lhJ3e7NcOji7wdwUegQuxlSH8ohKTtEU1xlc/1cFLccXTVL3AHSEnC 6VvaV4Nh34wT3F3OsOOF5xnel9B2+wAVGlu2+qDsFzs4oEACd3ex/bFB2/yaZmCvdUPy 0rOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9c3XpUNRuxc8tvHN/G/s1TeMtn7R53E47RIpJ3K1Kjo=; b=ooliqNUcd97os4lia22KF5VQwlfzs1ai0Ui3QJrqoFyR54P5HKYxQ4guUqIpuattuP DmI4Impp1maYb7Ec2610GMMUbHf2CBPRYFiGUHceEOMVtb74zuYCBsFHBqmmCzdBiDS0 oP1bcCHCuFt4bf4plDuT/XZ+fmWXaJC98TSJkiSqv7NWeQCSE0ImgAxMm1V4cNOSRJ0T bJ+EsEw8KA+ikj3XDO/Trwd6btrppj1jILcdS2s9kremml+PiZocgc3nadKLv5q88KUq Syt7fKjt81JxYpKeGAV89JR/PxuEW+aD2bz/DUg0EZtktGc/BKmUqQbDw1YU3yHarnCn pNpA== X-Gm-Message-State: AOAM532jj07lQPCs6Ml8O38ySv1HFHMuzrFL/xjrmEqswmsPD3RsHp5/ XUTJUUFC4m/8Iva4m7TuxXZw+an1vYR/i1eSCwWO+A== X-Google-Smtp-Source: ABdhPJxUcerRmdzyFUvLtbWcqtliDcNlbqG0p6OLPpFJjZwLdfD/UvIdP+kEnW0mIo2vb6TxUppF8iaiEBWW8qw+7w8= X-Received: by 2002:a17:906:22d0:: with SMTP id q16mr3584102eja.455.1592326791128; Tue, 16 Jun 2020 09:59:51 -0700 (PDT) MIME-Version: 1.0 References: <20200616115213.13109-1-david@redhat.com> <20200616115213.13109-4-david@redhat.com> <20200616124120.GF9499@dhcp22.suse.cz> <30c35cd2-8167-d402-2c7e-94f5fcce0274@redhat.com> In-Reply-To: <30c35cd2-8167-d402-2c7e-94f5fcce0274@redhat.com> From: Dan Williams Date: Tue, 16 Jun 2020 09:59:40 -0700 Message-ID: Subject: Re: [PATCH v1 3/3] mm/shuffle: remove dynamic reconfiguration To: David Hildenbrand Cc: Michal Hocko , Linux Kernel Mailing List , Linux MM , Andrew Morton , Johannes Weiner , Minchan Kim , Huang Ying , Wei Yang , Keith Busch , Mel Gorman Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 44721181BD370 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 16, 2020 at 6:45 AM David Hildenbrand wrote: > > On 16.06.20 14:41, Michal Hocko wrote: > > [Add Dan] > > Whops, dropped by mistake. Thanks for adding. > > > > > On Tue 16-06-20 13:52:13, David Hildenbrand wrote: > >> Commit e900a918b098 ("mm: shuffle initial free memory to improve > >> memory-side-cache utilization") promised "autodetection of a > >> memory-side-cache (to be added in a follow-on patch)" over a year ago. > >> > >> The original series included patches [1], however, they were dropped > >> during review [2] to be followed-up later. > >> > >> Let's simplify for now and re-add when really (ever?) needed. > >> > >> [1] https://lkml.kernel.org/r/154510700291.1941238.817190985966612531.stgit@dwillia2-desk3.amr.corp.intel.com/ > >> [2] https://lkml.kernel.org/r/154690326478.676627.103843791978176914.stgit@dwillia2-desk3.amr.corp.intel.com/ > >> > >> Cc: Andrew Morton > >> Cc: Johannes Weiner > >> Cc: Michal Hocko > >> Cc: Minchan Kim > >> Cc: Huang Ying > >> Cc: Wei Yang > >> Cc: Keith Busch > >> Cc: Mel Gorman > >> Signed-off-by: David Hildenbrand > > > > While I am not against removing this unused code I am really curious > > what is the future of the auto detection. Has this just fall through > > cracks or there are some more serious problem to make detection > > possible/reliable? > > From the bouncing mails I assume Keith - author of the original patches > in [1] - is no longer working at Intel (or I messed up :) "#5.1.0 > Address rejected"). Maybe Dan can clarify what the future of this is. People are actively using this via the command line option. In fact it has saved some people that have deployed platforms with mistmatched DIMM populations where no HMAT autodetection would be possible. It's also been useful for mitigating other memory interleaving performance problems that are sensitive to a given address line. The reason this is still manual is the dearth of platforms that publish an HMAT, but again the command line option is actively mitigating performance issues or otherwise allowing for testing a "pre-aged" memory allocator free list.