From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20AFBC388F3 for ; Fri, 27 Sep 2019 19:33:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B060E21655 for ; Fri, 27 Sep 2019 19:33:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="qDzk9fny" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B060E21655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1AC978E0005; Fri, 27 Sep 2019 15:33:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 15B5F8E0001; Fri, 27 Sep 2019 15:33:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04BBC8E0005; Fri, 27 Sep 2019 15:33:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0147.hostedemail.com [216.40.44.147]) by kanga.kvack.org (Postfix) with ESMTP id DB84A8E0001 for ; Fri, 27 Sep 2019 15:33:07 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 717866D8A for ; Fri, 27 Sep 2019 19:33:07 +0000 (UTC) X-FDA: 75981698814.05.rub23_727fb9c699b1b X-HE-Tag: rub23_727fb9c699b1b X-Filterd-Recvd-Size: 3886 Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Fri, 27 Sep 2019 19:33:06 +0000 (UTC) Received: by mail-oi1-f196.google.com with SMTP id x3so6199551oig.2 for ; Fri, 27 Sep 2019 12:33:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=isDPGCReaiK37P8mK6pZ6yGM/s1VY4mHCre4SI/h+uk=; b=qDzk9fny20uBp5VR9KMYd1Fac7VhmA3xZ0QbUkwiP80EbKY9RaCkA/4U4Qe7pi6TsI zDEsEtbKHF8GpyEsQPTtGod2U4zBxqctjrd4sOKYfMmeJXF6SAxWVZ16/wp4AKGS5xv6 3apcUl+LXf1XdM/yu/zw1Uw97EfZ9XGnzwGMCbc919wDt95/CpOPUnrVC9TbFVA3DgnX k826ZjdZJgOP0qVA9oleHpg4fFUebyz8hqjPBGPaHvhd7R/id1utbwGeNqZuwRQdicVO zyrcK+uCKeiCSFtqsitZuUVl82lvIty2M8HzrYh0u6W2pvLlVz29fB2DhcjV0n04fay/ 2OoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=isDPGCReaiK37P8mK6pZ6yGM/s1VY4mHCre4SI/h+uk=; b=VBniWdCQxLI67w1/Bb4aVW4slJFhd8UIotMf9lEYb2vZQ5gAimy6ODI1PiYBZDai49 jAx26IZCE2oaZs/F92f8qyCRd+BsKoOc4jV8j46bcXURLuInyyxtZLWMG2nMHKtrx+P8 ZA/LBA3YLfK53L8XmPugVNT3IBwsPXB+MIH3P0TecGPYpO4Zi4lRHnNllOzu2SdS4QZu Emt7izNi3PgVJX0UZNrCmqD61K/2XlbAypodsYPfdQ9xi7uNNO1LHI6D/oEqYdwOymTe FqcJ9cz3lhA8c6eQc0LrvrhPOmA/s0/KJYe94yRmy0kTKX59vcQeSGU69XqwIEhezRR9 wwTQ== X-Gm-Message-State: APjAAAUhz75WSct16FhbhDOaDGct78+ml8hcivGO/RdkCvDPdyOKMa+1 Kqo7LoGAYDSTmHODk0mB5cAZv/ysB30Yh9TONYsuIg== X-Google-Smtp-Source: APXvYqzAZY40Bk8ZksTVV+s3FcueJU0jeqVy/scpmyhn0c0F1MSet8HaXinRuhaCTO9u6YjIBS9thk00YJposzWuWaA= X-Received: by 2002:aca:eb09:: with SMTP id j9mr8863477oih.105.1569612785882; Fri, 27 Sep 2019 12:33:05 -0700 (PDT) MIME-Version: 1.0 References: <20190927161416.62293-1-pilgrimtao@gmail.com> In-Reply-To: <20190927161416.62293-1-pilgrimtao@gmail.com> From: Dan Williams Date: Fri, 27 Sep 2019 12:32:54 -0700 Message-ID: Subject: Re: [PATCH] mm, page_alloc: drop pointless static qualifier in build_zonelists() To: Kaitao Cheng Cc: Andrew Morton , Sasha Levin , Michal Hocko , Oscar Salvador , Mel Gorman , Mike Rapoport , Alexander Duyck , Pasha Tatashin , Alexander Potapenko , Linux MM , Linux Kernel Mailing List , Muchun Song Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 27, 2019 at 9:14 AM Kaitao Cheng wrote: > > There is no need to make the 'node_order' variable static > since new value always be assigned before use it. > > Signed-off-by: Kaitao Cheng > Signed-off-by: Muchun Song > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 3334a769eb91..c473c304d09f 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5597,7 +5597,7 @@ static void build_thisnode_zonelists(pg_data_t *pgdat) > > static void build_zonelists(pg_data_t *pgdat) > { > - static int node_order[MAX_NUMNODES]; > + int node_order[MAX_NUMNODES]; This isn't pointless. This prevents 4KB stack allocation which might overflow.