From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8356C3F2CD for ; Sat, 29 Feb 2020 22:37:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A7FE62467B for ; Sat, 29 Feb 2020 22:37:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="OsiUhUD4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A7FE62467B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 553426B0005; Sat, 29 Feb 2020 17:37:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 502E46B0006; Sat, 29 Feb 2020 17:37:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CA446B0007; Sat, 29 Feb 2020 17:37:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0044.hostedemail.com [216.40.44.44]) by kanga.kvack.org (Postfix) with ESMTP id 215236B0005 for ; Sat, 29 Feb 2020 17:37:44 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C4F56181AEF1F for ; Sat, 29 Feb 2020 22:37:43 +0000 (UTC) X-FDA: 76544628006.06.nose91_7da2e348bc035 X-HE-Tag: nose91_7da2e348bc035 X-Filterd-Recvd-Size: 4326 Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com [209.85.167.193]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Sat, 29 Feb 2020 22:37:43 +0000 (UTC) Received: by mail-oi1-f193.google.com with SMTP id 5so1044937oiy.4 for ; Sat, 29 Feb 2020 14:37:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vMgdrB1ihQCYAIbfFMzkiv3JHJetoGVM7PTi0q5ALmo=; b=OsiUhUD4bT1O7upbHwDuinmveawahmkCK+8PabYGyG4OgCvzVO2Y9gPARZOt8Q/czD +gKk4PjNad9Cr3uGC/89VvuVJcnJzMxJ6ySwmoXkUgS4Qbmfer8kAdJCtymsZ4N4Kisj xhsW4Trq+pLWIg+nu+GHlVmCRXyn51E/QSA0Axc54CrRDbWXQQuvdO5+eE5LbwM4gEdp uF4zuIbpl+wi5BquzuZ+DBrW3+oz59DM54WqcTU+Q4EjA/hE6ZkxGgQBfjmJzKNErQrc d4M1+ejrtFxlmMb9QI6A2Bvzid6CQiM91vKcAXrSOKEwClT+jdHfQPTQ7XCWj2cSd8Cg EVvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vMgdrB1ihQCYAIbfFMzkiv3JHJetoGVM7PTi0q5ALmo=; b=fcpyDXSyvGY9Tc2CaVp4/Q0F6vXIv0XXbrO+54i2uFbAFo32oJSp6NQGvx/VbEg3nm 7lhNk/DK+PJbGkzB1LrSZsolY5iZ3IAmCbM1Q+5tgpfUj7/1Fy7Qt4q0Cmr5/+1+iLO0 9ZQdvsW8W++MaQqHmuL+yMfYB9uBdOaHcM50tsYLfUtmz1rXCbNCv7Optg/BeHY5UwDa UwPpx2lKV8jpvbSAV3MsPJTOZ1lJgqiZHc210zWs7EhlQw+7Xkhq4qfiQk6PSmwfIYs5 CXgw+RN/o4R0epJX6tmGhqWEXeR66xFItWWly97ULRTGsj3s6jciZajG6d0IC5kvRCr5 efRQ== X-Gm-Message-State: APjAAAWtC0ANDuYH3cKj0kxMWMa6uoSV+NdPOuGxhSJyJ7yZpZqi+XEU vSkqYQJDCoXy4Hqxb1eXJB6LWy+Drss+fN4ykftdsw== X-Google-Smtp-Source: APXvYqzG75KD/D3fDhylY7WK/HGO2n1t1MkOMUt0WzVJixm4DCk6JJ0g5eYvnxnmvSeOxw028BqGSEKkK+YHNuO1FGI= X-Received: by 2002:a54:4098:: with SMTP id i24mr5511480oii.149.1583015862617; Sat, 29 Feb 2020 14:37:42 -0800 (PST) MIME-Version: 1.0 References: <20200221182503.28317-1-logang@deltatee.com> <20200221182503.28317-4-logang@deltatee.com> In-Reply-To: <20200221182503.28317-4-logang@deltatee.com> From: Dan Williams Date: Sat, 29 Feb 2020 14:37:31 -0800 Message-ID: Subject: Re: [PATCH v3 3/7] x86/mm: Thread pgprot_t through init_memory_mapping() To: Logan Gunthorpe Cc: Linux Kernel Mailing List , Linux ARM , linux-ia64@vger.kernel.org, linuxppc-dev , linux-s390 , Linux-sh , platform-driver-x86@vger.kernel.org, Linux MM , Michal Hocko , David Hildenbrand , Andrew Morton , Christoph Hellwig , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Eric Badger , "H. Peter Anvin" , X86 ML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 21, 2020 at 10:25 AM Logan Gunthorpe wrote: > > In prepartion to support a pgprot_t argument for arch_add_memory(). > > It's required to move the prototype of init_memory_mapping() seeing > the original location came before the definition of pgprot_t. > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: "H. Peter Anvin" > Cc: x86@kernel.org > Cc: Dave Hansen > Cc: Andy Lutomirski > Cc: Peter Zijlstra > Signed-off-by: Logan Gunthorpe Looks good, checked for argument confusion, passes the nvdimm unit tests. Reviewed-by: Dan Williams