From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84783C2D0EC for ; Sat, 28 Mar 2020 18:23:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2BE4E20714 for ; Sat, 28 Mar 2020 18:23:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="hypZZ56o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2BE4E20714 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9B6CB6B0010; Sat, 28 Mar 2020 14:23:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 967A36B0032; Sat, 28 Mar 2020 14:23:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 87C516B0036; Sat, 28 Mar 2020 14:23:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0110.hostedemail.com [216.40.44.110]) by kanga.kvack.org (Postfix) with ESMTP id 6E89D6B0010 for ; Sat, 28 Mar 2020 14:23:38 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 933268248D52 for ; Sat, 28 Mar 2020 18:23:37 +0000 (UTC) X-FDA: 76645594074.29.tiger39_76e583a68d400 X-HE-Tag: tiger39_76e583a68d400 X-Filterd-Recvd-Size: 4206 Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Sat, 28 Mar 2020 18:23:36 +0000 (UTC) Received: by mail-ed1-f68.google.com with SMTP id bd14so15650711edb.10 for ; Sat, 28 Mar 2020 11:23:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R436PKaf7Me7i9Q+u1EyxQhECXtmveD85TYjBFq47Tw=; b=hypZZ56oIK1R5yJZ8yM4evhkoSOKTKu4FO6ru0cfN+t1sEKakoBcMTsfznAy7BPK/I +7t6SVe7/KDB9k4WIQfKr8OaB09sWme6xjjK5DEhXfHYTkHO6O3ntWdtxPxxx0uFy5WB +plf1hd9cEYp7e590pGK6oO2PO2dZLXCMCIueB5ImbOsaznC4FfAtlPifo8t/O2mlh3I V60Y8qXBZ0fKEzCw2ye/Zk1vFq4fiIB7PTP6KBHPA1XJ1hfvJenzYblr64fEBRD8IPAc 1trh8RBfBe0nZN05Otm863olSui4NnCehOCbtJY5tAYRnGhsrp9cw6wMaM9A6ozdDoCe 7RSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R436PKaf7Me7i9Q+u1EyxQhECXtmveD85TYjBFq47Tw=; b=YitkV1edy9W3K7TYB7Mk9MnHGu9mIPQY758/718Mn/DuiscusJLuY/cabXcRDgWOhE V+msxAWG9OKlXacXU1PQLOHkXFvd+iMhK7oHJwkiP7PeAPj1NN60EiVZAcOYyD931vc1 w8A0C0GlNXkJOgJtzCaAEosPHDcvkd2a0Q568HWIzcta0dO5EXUIcANJHzqNqS3gitsr zmYZrBjFvcYz5zYEF9yzC84td0ZEC3VxroIwa3xcRRsxjmL0V1hg9n7VQcrN3ZyZ/OjI 5G2w6zJTCNwXkHy6YLK+GM5cA3DDZpxKdn3+5s5JpceNSo2Y0SgXLfCZrdHGLOD1DmQU T2Gw== X-Gm-Message-State: ANhLgQ1ViJgnVAM/JR3izNUKB+TqFGM2OR6j2R9TbZXHl+n2TZzIMtTk TcqHSdJogLgOY8v+ItGBk7vnv6G7SMymu9T0mSJtNw== X-Google-Smtp-Source: ADFU+vscrzeh0HZ8Xsmgb8y7RdjhEQ38CYXQnm+4bw2bkwwkKqV8qCwiP3mwv5aMWlSG9MkFix6hAs2Z+UCEta+SWK4= X-Received: by 2002:a05:6402:b17:: with SMTP id bm23mr4599093edb.165.1585419815840; Sat, 28 Mar 2020 11:23:35 -0700 (PDT) MIME-Version: 1.0 References: <202003281643.02SGhPmY017434@sdf.org> In-Reply-To: <202003281643.02SGhPmY017434@sdf.org> From: Dan Williams Date: Sat, 28 Mar 2020 11:23:24 -0700 Message-ID: Subject: Re: [RFC PATCH v1 46/50] mm/shuffle.c: use get_random_max() To: George Spelvin Cc: Linux Kernel Mailing List , Qian Cai , Kees Cook , Michal Hocko , Andrew Morton , Linux MM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Mar 28, 2020 at 9:43 AM George Spelvin wrote: > > Now that we have it, this is an example of where it helps. I didn't get copied on the cover and this series does not seem to be threaded in a way lore can find the cover either: https://lore.kernel.org/r/202003281643.02SGhPmY017434@sdf.org Mind including a short blurb about what it is and why it helps in the changelog? > > Signed-off-by: George Spelvin > Cc: Dan Williams > Cc: Qian Cai > Cc: Kees Cook > Cc: Michal Hocko > Cc: Andrew Morton > Cc: linux-mm@kvack.org > --- > mm/shuffle.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/shuffle.c b/mm/shuffle.c > index b3fe97fd66541..e0ed247f8d907 100644 > --- a/mm/shuffle.c > +++ b/mm/shuffle.c > @@ -135,7 +135,7 @@ void __meminit __shuffle_zone(struct zone *z) > * in the zone. > */ > j = z->zone_start_pfn + > - ALIGN_DOWN(get_random_long() % z->spanned_pages, > + ALIGN_DOWN(get_random_max(z->spanned_pages), > order_pages); > page_j = shuffle_valid_page(j, order); > if (page_j && page_j != page_i) > -- > 2.26.0 >