From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4293C3404D for ; Wed, 19 Feb 2020 03:25:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6FAFC2465A for ; Wed, 19 Feb 2020 03:25:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="R4Gfv6ih" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FAFC2465A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 237126B0008; Tue, 18 Feb 2020 22:25:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BFD06B000A; Tue, 18 Feb 2020 22:25:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AEE26B000C; Tue, 18 Feb 2020 22:25:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0247.hostedemail.com [216.40.44.247]) by kanga.kvack.org (Postfix) with ESMTP id E1F726B0008 for ; Tue, 18 Feb 2020 22:25:27 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6AD2F180AD811 for ; Wed, 19 Feb 2020 03:25:27 +0000 (UTC) X-FDA: 76505436294.27.drop21_69cea7f0f3435 X-HE-Tag: drop21_69cea7f0f3435 X-Filterd-Recvd-Size: 3331 Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Wed, 19 Feb 2020 03:25:26 +0000 (UTC) Received: by mail-ot1-f65.google.com with SMTP id j16so21800991otl.1 for ; Tue, 18 Feb 2020 19:25:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=V2GbWTOlmThm3aCwYqLI/qAi80/RcAs7bKNkpgMzjiE=; b=R4Gfv6ih2l/vi3D5/mozVD0HHAOX3r6KI/XFNMUpw0bZ0W883+qK/w+cHSNZRmq9N7 JuoiAilWanaaUxT77D5bsMnLiHRQqCQoF7NyVBLeMI7EwXZq8e/YfIKau9Z5YgFXIm7a P4Lc/74ls4lSDopzAY99ErwSKfeQPo49jUGJMsSwOPOFkKjas/d5asMsq5Q8h4joH/1J b0gcseW8Hooqn1O6MCzjmVJ8XLntAU1+3xYoCeiH6AKts9JJ8KOF83BhsOb0cmyn44fg 1XwJdja2GTdO4dsPhsgNe8ypsI3yKZ1zryNp0dY3Am942lx7gtfSO16d9JAR6J/Pp5jk bISA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=V2GbWTOlmThm3aCwYqLI/qAi80/RcAs7bKNkpgMzjiE=; b=lU8aIFMk3MxthbQoASEwzdPeCIkb1QwDkxWB0/ANDMeka2anKjwLLBcomJ2TQ1zhc7 VKMVv3OUBs0GbetWymwWySSUAKPuVUM3x/sWDHzdvyIZbVM9WFh07wTwvzDJ4Dmn5y4L S6QOqdOI9s7BFtHMZw85NVOHsrdt0/nw2J1UnFK8KfqqBaEvVJ2pSfriVB9foqZdr7Zk hBGqLjqZAE/50vSuYVzguCUFgwMqmxFFtQ88m64bO5bR/G5rg1cWOLLANc8a5bXVw2+i TcWpVeTf5l/Ytsiw5ZDtSR8zQmWWGeya/l5bSKylFYObq44si7jGTiiyqb/8PNmdITb1 QKVg== X-Gm-Message-State: APjAAAUPMACn4Aqt9saCMe/Ig8qC8zyyuDUIFMU0NcO1TeP9OKyN6mYk 2ZwaPGx91E3i4d6I5p3GYqVLa0kcnC+DfKVwcVYffQ== X-Google-Smtp-Source: APXvYqxXSWy2SmasG885K49J545wadvMY/Bw0ZwC4KFzZZKf9xeFBXtRDKTWqbnS3vMTz+LsCoBckH2Tw+1UPsrTmP4= X-Received: by 2002:a9d:5d09:: with SMTP id b9mr17818653oti.207.1582082726339; Tue, 18 Feb 2020 19:25:26 -0800 (PST) MIME-Version: 1.0 References: <20200219030454.4844-1-bhe@redhat.com> In-Reply-To: <20200219030454.4844-1-bhe@redhat.com> From: Dan Williams Date: Tue, 18 Feb 2020 19:25:15 -0800 Message-ID: Subject: Re: [PATCH v2 RESEND] mm/sparsemem: pfn_to_page is not valid yet on SPARSEMEM To: Baoquan He Cc: Linux Kernel Mailing List , Linux MM , Andrew Morton , Wei Yang , David Hildenbrand , Oscar Salvador , Michal Hocko Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 18, 2020 at 7:05 PM Baoquan He wrote: > > From: Wei Yang > > When we use SPARSEMEM instead of SPARSEMEM_VMEMMAP, pfn_to_page() > doesn't work before sparse_init_one_section() is called. This leads to a > crash when hotplug memory: I'd also add: "On x86 the impact is limited to x86_32 builds, or x86_64 configurations that override the default setting for SPARSEMEM_VMEMMAP". Other than that: Reviewed-by: Dan Williams