From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0482EC3A5A2 for ; Tue, 20 Aug 2019 01:44:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B296022CE8 for ; Tue, 20 Aug 2019 01:44:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="Ez1qSTYy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B296022CE8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5F5CC6B0007; Mon, 19 Aug 2019 21:44:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A5FB6B0008; Mon, 19 Aug 2019 21:44:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BBD26B000A; Mon, 19 Aug 2019 21:44:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0045.hostedemail.com [216.40.44.45]) by kanga.kvack.org (Postfix) with ESMTP id 299F26B0007 for ; Mon, 19 Aug 2019 21:44:16 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id D44A64425 for ; Tue, 20 Aug 2019 01:44:15 +0000 (UTC) X-FDA: 75841110870.17.value22_4222fbaf0ef3a X-HE-Tag: value22_4222fbaf0ef3a X-Filterd-Recvd-Size: 4197 Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Tue, 20 Aug 2019 01:44:14 +0000 (UTC) Received: by mail-oi1-f196.google.com with SMTP id g128so2885067oib.1 for ; Mon, 19 Aug 2019 18:44:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hiy2qLGFsI5yCOQjtGw2FlRnrKh/058pTpkwHbYjWn4=; b=Ez1qSTYyLQaCZn2QMhz67IzLc8/urEfYaskSA3mavaP51YH8ju0nHD9GTDngUpbjbP 1AiLAnxbvNCGyrPXwBVEu36Q3uaEuDEqiP2VJkxKTCexg2w+ZjewRqlRgykjbOFRlbTH 2fLPm9B7vaGcBl10TazsQUg322pErV5Xk4X538qIO8M5JcXIZvaCsR4gzqy01slpxyax 4G8CymZh5RFI/0K2keiFQUFWjyvgpPwfdc90TOWyfBZs4Eyt8GPcrfEYWBqURbl8VN06 FBPr/5UyLCA35gk26Ovlht9WPFWzb00trqxgpQVrfYqYIqgKxH+fYUvZyy+4n4tgykEC 7HdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hiy2qLGFsI5yCOQjtGw2FlRnrKh/058pTpkwHbYjWn4=; b=Cx5lzfFruSN+8qPc8+IkrV2HEnw+6s8AcdgqzkB5Wlm/zLuiDJRFaG4nsPGeUSZtjk BtYquP+6CmEcfd9dPsnaavgWA1HP/yWtThPstaU+YUsrj/45ddWgYqUuPVLNAzyuWZJF JAlMfOgaDNLTiXT5LSw+IC75Z40+pJzF3Rmr8RlzBmy3g7GpoRR4WfT4X0ibocAspy+K RB8Mdhg9HHxLv10iZ7BcLS9QvlE3O+dMVTBsB5+eNl2CJIQqSfbVl3LZKWigXmzSzs4H CmVEcclW0OUDTi3DEuoWSk6EL1f/B0Hn0avc1G+kV3ZYylhkJk0gTIezlG1NFht7r4Gb EF7w== X-Gm-Message-State: APjAAAUIOeFElBfF+pX8d+08Gz1oDAn1kVmNqRWzCmAwfM5BmZ9OiGG0 LHhvOieITyad688RMtwAiiKvCcxVz9hMU4/Q6jVNVA== X-Google-Smtp-Source: APXvYqxaNpMRYLbfGIBxgJOZMZpvJzzYO44wJfPyyGnlz73jF7wI7dbsRvMZy5tGKZb+Q0OELWHnimWe8R9UTMynpps= X-Received: by 2002:aca:be43:: with SMTP id o64mr15940919oif.149.1566265453559; Mon, 19 Aug 2019 18:44:13 -0700 (PDT) MIME-Version: 1.0 References: <20190818090557.17853-1-hch@lst.de> <20190818090557.17853-3-hch@lst.de> In-Reply-To: <20190818090557.17853-3-hch@lst.de> From: Dan Williams Date: Mon, 19 Aug 2019 18:44:02 -0700 Message-ID: Subject: Re: [PATCH 2/4] memremap: remove the dev field in struct dev_pagemap To: Christoph Hellwig Cc: Jason Gunthorpe , Bharata B Rao , Andrew Morton , Linux MM , Linux Kernel Mailing List , linux-nvdimm , Ira Weiny Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Aug 18, 2019 at 2:12 AM Christoph Hellwig wrote: > > The dev field in struct dev_pagemap is only used to print dev_name in > two places, which are at best nice to have. Just remove the field > and thus the name in those two messages. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Ira Weiny Needs the below as well. /me goes to check if he ever merged the fix to make the unit test stuff get built by default with COMPILE_TEST [1]. Argh! Nope, didn't submit it for 5.3-rc1, sorry for the thrash. You can otherwise add: Reviewed-by: Dan Williams [1]: https://lore.kernel.org/lkml/156097224232.1086847.9463861924683372741.stgit@dwillia2-desk3.amr.corp.intel.com/ --- diff --git a/tools/testing/nvdimm/test/iomap.c b/tools/testing/nvdimm/test/iomap.c index cd040b5abffe..3f55f2f99112 100644 --- a/tools/testing/nvdimm/test/iomap.c +++ b/tools/testing/nvdimm/test/iomap.c @@ -132,7 +132,6 @@ void *__wrap_devm_memremap_pages(struct device *dev, struct dev_pagemap *pgmap) if (!nfit_res) return devm_memremap_pages(dev, pgmap); - pgmap->dev = dev; if (!pgmap->ref) { if (pgmap->ops && (pgmap->ops->kill || pgmap->ops->cleanup)) return ERR_PTR(-EINVAL);