From: Dan Williams <dan.j.williams@intel.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: "Linux MM" <linux-mm@kvack.org>,
"Weiny, Ira" <ira.weiny@intel.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
ohall@gmail.com, "X86 ML" <x86@kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
"Anshuman Khandual" <anshuman.khandual@arm.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] mm/memremap: Rename and consolidate SECTION_SIZE
Date: Fri, 12 Apr 2019 12:12:49 -0700 [thread overview]
Message-ID: <CAPcyv4iYgwPJZpwUzM-ehc5F3gjO5TJ4AOz3f21ou8NrRCsEKA@mail.gmail.com> (raw)
In-Reply-To: <029d4af64642019a6d73c804d362d840f4eb0941.1555093412.git.robin.murphy@arm.com>
On Fri, Apr 12, 2019 at 11:57 AM Robin Murphy <robin.murphy@arm.com> wrote:
>
> Trying to activatee ZONE_DEVICE for arm64 reveals that memremap's
s/activatee/activate/
> internal helpers for sparsemem sections conflict with and arm64's
> definitions for hugepages, which inherit the name of "sections" from
> earlier versions of the ARM architecture.
>
> Disambiguate memremap (and now HMM too) by propagating sparsemem's PA_
> prefix, to clarify that these values are in terms of addresses rather
> than PFNs (and because it's a heck of a lot easier than changing all the
> arch code). SECTION_MASK is unused, so it can just go.
Looks good to me. So good that it collides with a similar change in
the "sub-section" support series.
Acked-by: Dan Williams <dan.j.williams@intel.com>
next prev parent reply other threads:[~2019-04-12 19:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 18:55 [PATCH 0/3] Device-memory-related cleanups Robin Murphy
2019-04-12 18:56 ` [PATCH 1/3] mm/memremap: Rename and consolidate SECTION_SIZE Robin Murphy
2019-04-12 19:01 ` [PATCH RESEND " Robin Murphy
2019-04-12 19:12 ` Dan Williams [this message]
2019-04-12 18:56 ` [PATCH 2/3] mm: clean up is_device_*_page() definitions Robin Murphy
2019-04-12 19:01 ` [PATCH RESEND " Robin Murphy
2019-04-15 11:25 ` Anshuman Khandual
2019-04-12 18:56 ` [PATCH 3/3] mm: introduce ARCH_HAS_PTE_DEVMAP Robin Murphy
2019-04-12 19:01 ` [PATCH RESEND " Robin Murphy
2019-04-12 19:37 ` Dan Williams
2019-04-12 20:09 ` [PATCH " Ira Weiny
2019-04-15 0:58 ` Oliver
2019-04-15 11:30 ` [PATCH RESEND " Anshuman Khandual
2019-04-12 19:01 ` [PATCH RESEND 0/3] Device-memory-related cleanups Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4iYgwPJZpwUzM-ehc5F3gjO5TJ4AOz3f21ou8NrRCsEKA@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=anshuman.khandual@arm.com \
--cc=ira.weiny@intel.com \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ohall@gmail.com \
--cc=robin.murphy@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox