From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 061AEC47257 for ; Fri, 1 May 2020 17:39:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A6A292495E for ; Fri, 1 May 2020 17:39:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="ZFbBfzs2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6A292495E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3E2378E0005; Fri, 1 May 2020 13:39:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 393068E0001; Fri, 1 May 2020 13:39:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 280FD8E0005; Fri, 1 May 2020 13:39:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0104.hostedemail.com [216.40.44.104]) by kanga.kvack.org (Postfix) with ESMTP id 10D7D8E0001 for ; Fri, 1 May 2020 13:39:42 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C22732470 for ; Fri, 1 May 2020 17:39:41 +0000 (UTC) X-FDA: 76768862562.10.milk10_71b76ac13091d X-HE-Tag: milk10_71b76ac13091d X-Filterd-Recvd-Size: 8560 Received: from mail-ej1-f65.google.com (mail-ej1-f65.google.com [209.85.218.65]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Fri, 1 May 2020 17:39:41 +0000 (UTC) Received: by mail-ej1-f65.google.com with SMTP id s3so8070658eji.6 for ; Fri, 01 May 2020 10:39:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dy1QO3v2TmcaobStg64BpwnTJR5lVFKTuFOSCo8GmkA=; b=ZFbBfzs2QE4xxYrnFXEMSgV7VomZkqIDLnKCbwZuLXE2bdQRRKnDJ2f4J0afAZ5AGo rP9kuD2G28NH74yg1IkNEaGUxilA8vimracGEKo4jJDRlhwm0FMsADHlSBvQrzOuq0ZK CZBlpTbtqNsQtcEwMe9p4/JuUqyXanSoZOH1zmdbc+9MNweeD6uoRH0cl0RKU1zhcEwi KVK/UkwuhvXWFad3q9M9sXR1q1XB/5wW5F4/UrTA0mWQDlwW4wqfNJ4uHouclRWwP8aF YHpwqQqOd2mOX5F09RWu9qYoNn6ux/9GamnFIvyqW4sbCL/HFriqsV+cTfO6VBepp8ym UREw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dy1QO3v2TmcaobStg64BpwnTJR5lVFKTuFOSCo8GmkA=; b=Oh9nXzwSuvdZ5mN+C9VVuXdplWELidIZYwrJUIXTuE/m3+fzNjFE8EHPmN74W8L88M Hy43ujbItHc5V4+y27q6RnS7EosX8so+geiLef4Q3em9dOvuK0wNXpKwXC3M8T6ZlGs4 hGxxPqLfKwxp2Crbqtu8/pg07bWQdCv+5VTRWTKlGNXQxFNZbRyxU+syek55SYpzc0w+ ckxjfztAsLi7aAPpzX3ldhLaHwN7nL2tb69lYHqueHgd5mDycY25URoZ0ORS1h6QaaF5 PKRb4ynpc6/wX1LVUJOqHSmE/AD5cXrAM9sSUgfQTJ8RXmBTlcvSO3rlAteg9Gq+IncI 4Vtg== X-Gm-Message-State: AGi0PuZAlGzCVnAUd4XQmzaOO0vtuKkCenAI3g8n5yYgl/F1GiS+PCk4 WgPhRaKmhCX1bcgqtPNsC1PowMzXYz6AmGKSySOcmw== X-Google-Smtp-Source: APiQypKykdi+282JilRe16+6KKLcB6tg9cgSEAjlHPf89wAO5Cv3AtR5Wk0ydTXi3sTqOc+y0w//0y1mp0EsvfqmPHo= X-Received: by 2002:a17:906:90cc:: with SMTP id v12mr4384205ejw.211.1588354779963; Fri, 01 May 2020 10:39:39 -0700 (PDT) MIME-Version: 1.0 References: <20200430102908.10107-1-david@redhat.com> <20200430102908.10107-3-david@redhat.com> <87pnbp2dcz.fsf@x220.int.ebiederm.org> <1b49c3be-6e2f-57cb-96f7-f66a8f8a9380@redhat.com> <871ro52ary.fsf@x220.int.ebiederm.org> <373a6898-4020-4af1-5b3d-f827d705dd77@redhat.com> <875zdg26hp.fsf@x220.int.ebiederm.org> <20200430152403.e0d6da5eb1cad06411ac6d46@linux-foundation.org> <5c908ec3-9495-531e-9291-cbab24f292d6@redhat.com> <2d019c11-a478-9d70-abd5-4fd2ebf4bc1d@redhat.com> In-Reply-To: <2d019c11-a478-9d70-abd5-4fd2ebf4bc1d@redhat.com> From: Dan Williams Date: Fri, 1 May 2020 10:39:28 -0700 Message-ID: Subject: Re: [PATCH v2 2/3] mm/memory_hotplug: Introduce MHP_NO_FIRMWARE_MEMMAP To: David Hildenbrand Cc: Andrew Morton , "Eric W. Biederman" , Linux Kernel Mailing List , Linux MM , virtio-dev@lists.oasis-open.org, virtualization@lists.linux-foundation.org, linuxppc-dev , Linux ACPI , linux-nvdimm , linux-hyperv@vger.kernel.org, linux-s390 , xen-devel , Michal Hocko , "Michael S . Tsirkin" , Michal Hocko , Pankaj Gupta , Wei Yang , Baoquan He Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 1, 2020 at 10:21 AM David Hildenbrand wrote: > > On 01.05.20 18:56, Dan Williams wrote: > > On Fri, May 1, 2020 at 2:34 AM David Hildenbrand wrote: > >> > >> On 01.05.20 00:24, Andrew Morton wrote: > >>> On Thu, 30 Apr 2020 20:43:39 +0200 David Hildenbrand wrote: > >>> > >>>>> > >>>>> Why does the firmware map support hotplug entries? > >>>> > >>>> I assume: > >>>> > >>>> The firmware memmap was added primarily for x86-64 kexec (and still, is > >>>> mostly used on x86-64 only IIRC). There, we had ACPI hotplug. When DIMMs > >>>> get hotplugged on real HW, they get added to e820. Same applies to > >>>> memory added via HyperV balloon (unless memory is unplugged via > >>>> ballooning and you reboot ... the the e820 is changed as well). I assume > >>>> we wanted to be able to reflect that, to make kexec look like a real reboot. > >>>> > >>>> This worked for a while. Then came dax/kmem. Now comes virtio-mem. > >>>> > >>>> > >>>> But I assume only Andrew can enlighten us. > >>>> > >>>> @Andrew, any guidance here? Should we really add all memory to the > >>>> firmware memmap, even if this contradicts with the existing > >>>> documentation? (especially, if the actual firmware memmap will *not* > >>>> contain that memory after a reboot) > >>> > >>> For some reason that patch is misattributed - it was authored by > >>> Shaohui Zheng , who hasn't been heard from in > >>> a decade. I looked through the email discussion from that time and I'm > >>> not seeing anything useful. But I wasn't able to locate Dave Hansen's > >>> review comments. > >> > >> Okay, thanks for checking. I think the documentation from 2008 is pretty > >> clear what has to be done here. I will add some of these details to the > >> patch description. > >> > >> Also, now that I know that esp. kexec-tools already don't consider > >> dax/kmem memory properly (memory will not get dumped via kdump) and > >> won't really suffer from a name change in /proc/iomem, I will go back to > >> the MHP_DRIVER_MANAGED approach and > >> 1. Don't create firmware memmap entries > >> 2. Name the resource "System RAM (driver managed)" > >> 3. Flag the resource via something like IORESOURCE_MEM_DRIVER_MANAGED. > >> > >> This way, kernel users and user space can figure out that this memory > >> has different semantics and handle it accordingly - I think that was > >> what Eric was asking for. > >> > >> Of course, open for suggestions. > > > > I'm still more of a fan of this being communicated by "System RAM" > > I was mentioning somewhere in this thread that "System RAM" inside a > hierarchy (like dax/kmem) will already be basically ignored by > kexec-tools. So, placing it inside a hierarchy already makes it look > special already. > > But after all, as we have to change kexec-tools either way, we can > directly go ahead and flag it properly as special (in case there will > ever be other cases where we could no longer distinguish it). > > > being parented especially because that tells you something about how > > the memory is driver-managed and which mechanism might be in play. > > The could be communicated to some degree via the resource hierarchy. > > E.g., > > [root@localhost ~]# cat /proc/iomem > ... > 140000000-33fffffff : Persistent Memory > 140000000-1481fffff : namespace0.0 > 150000000-33fffffff : dax0.0 > 150000000-33fffffff : System RAM (driver managed) > > vs. > > :/# cat /proc/iomem > [...] > 140000000-333ffffff : virtio-mem (virtio0) > 140000000-147ffffff : System RAM (driver managed) > 148000000-14fffffff : System RAM (driver managed) > 150000000-157ffffff : System RAM (driver managed) > > Good enough for my taste. > > > What about adding an optional /sys/firmware/memmap/X/parent attribute. > > I really don't want any firmware memmap entries for something that is > not part of the firmware provided memmap. In addition, > /sys/firmware/memmap/ is still a fairly x86_64 specific thing. Only mips > and two arm configs enable it at all. > > So, IMHO, /sys/firmware/memmap/ is definitely not the way to go. I think that's a policy decision and policy decisions do not belong in the kernel. Give the tooling the opportunity to decide whether System RAM stays that way over a kexec. The parenthetical reference otherwise looks out of place to me in the /proc/iomem output. What makes it "driver managed" is how the kernel handles it, not how the kernel names it.