From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20B8FC433DB for ; Mon, 22 Mar 2021 16:11:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B06366192B for ; Mon, 22 Mar 2021 16:11:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B06366192B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4CC5A6B00ED; Mon, 22 Mar 2021 11:52:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 47C926B00EE; Mon, 22 Mar 2021 11:52:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CF0A6B00EF; Mon, 22 Mar 2021 11:52:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0217.hostedemail.com [216.40.44.217]) by kanga.kvack.org (Postfix) with ESMTP id 0E5C06B00ED for ; Mon, 22 Mar 2021 11:52:26 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 5B1791802914C for ; Mon, 22 Mar 2021 16:11:16 +0000 (UTC) X-FDA: 77947999752.15.31B48B2 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf10.hostedemail.com (Postfix) with ESMTP id 1636A40F8C13 for ; Mon, 22 Mar 2021 16:11:00 +0000 (UTC) Received: by mail-ej1-f54.google.com with SMTP id u21so4246492ejo.13 for ; Mon, 22 Mar 2021 09:10:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0RjSQM4DgkK7m/ekOUT02sK+WqopVxraVt2b40+KaBU=; b=xlR34CXli2xQbahXQ3WiajunYFVNHrhO61oNhpR4/BYX6TPJtgYJmbdPpdF/A31M4B 66ycQ1WNrd8yikq99kH9YnVaeub+aRLakcZm8YWnKtJEeLTzvKIu1Q6UP9LpOuwd6Kbf 8raqj1HQG/Fba/NR16M++LWd4Am3B75WUTIrp9MCif8o7dY04WWvBWkxG19AHnJnnuND NkxL6drrSy20vU5G1f5clhkItXup1oA4BMEKFzO5oSK3LHoAIRBcBBW3DvFW70AoTOv9 i6dx6E1lKit1YwP+2xfk8Q4ThhFXZFhd6KWgJK+7q9iefjxr0QR9WupVABR7Hy0gFNxN CUOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0RjSQM4DgkK7m/ekOUT02sK+WqopVxraVt2b40+KaBU=; b=gqxHGzuiLY99Vyd2I/f2UrMrZJZvHQ6BlJRg9tTYs5CsvEn5z6vBp1X5S9EgqKQW47 U2oVxW19f7n7k+1tX/piy0x7Vnt6Ew2m+HOuA5IjGprzdGJGdR+pSSyyZmTVtkg5GJTw wdu7gKxekYpwERl9uY5zdSAhn8XQ8EAVbGW/mw9b9C3gAEyoMdMec7wlZRr0deqXlbVJ 3NaRZUJ0k78Cg2taM0/k9BCIVul7QYQEoBEcUZ8mTH+Irl82pDiysuBQTd9O+8OgYX9J tvkpLGTz1chWaQrxNHBIWO237ciSBgE9MvcC6Yx3+YIvAvRyLoHPv0xSEDg69Cnqf2yY XJ0Q== X-Gm-Message-State: AOAM531r5pYQUeObgSbO7kSw7mNvwNwp7tV3qvnXePRbL63b1ILgd2Kd VxWn8vN4FjlqHFcB9cPp3xc3YxUbj6hXMyvG4/Wckg== X-Google-Smtp-Source: ABdhPJw2cwpwcIFF+4fCD52TNaNhNj6xZuvy8zO0W6QKI4z8VrkzNaMSL98WR0e/SxJx41J9zwBSutz9BqE/L1Bveo0= X-Received: by 2002:a17:906:2ac1:: with SMTP id m1mr539193eje.472.1616429457645; Mon, 22 Mar 2021 09:10:57 -0700 (PDT) MIME-Version: 1.0 References: <20210322160200.19633-1-david@redhat.com> <20210322160200.19633-2-david@redhat.com> In-Reply-To: <20210322160200.19633-2-david@redhat.com> From: Dan Williams Date: Mon, 22 Mar 2021 09:10:48 -0700 Message-ID: Subject: Re: [PATCH v1 1/3] kernel/resource: make walk_system_ram_res() find all busy IORESOURCE_SYSTEM_RAM resources To: David Hildenbrand Cc: Linux Kernel Mailing List , Linux MM , Andrew Morton , Greg Kroah-Hartman , Daniel Vetter , Andy Shevchenko , Mauro Carvalho Chehab , Dave Young , Baoquan He , Vivek Goyal , Dave Hansen , Keith Busch , Michal Hocko , Qian Cai , Oscar Salvador , Eric Biederman , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Tom Lendacky , Brijesh Singh , X86 ML , Kexec Mailing List Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: f9784au4da1qxkj8jt6r1d8ijhbbeb59 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1636A40F8C13 Received-SPF: none (intel.com>: No applicable sender policy available) receiver=imf10; identity=mailfrom; envelope-from=""; helo=mail-ej1-f54.google.com; client-ip=209.85.218.54 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616429460-382762 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 22, 2021 at 9:02 AM David Hildenbrand wrote: > > It used to be true that we can have busy system RAM only on the first level > in the resourc tree. However, this is no longer holds for driver-managed > system RAM (i.e., added via dax/kmem and virtio-mem), which gets added on > lower levels. > > We have two users of walk_system_ram_res(), which currently only > consideres the first level: > a) kernel/kexec_file.c:kexec_walk_resources() -- We properly skip > IORESOURCE_SYSRAM_DRIVER_MANAGED resources via > locate_mem_hole_callback(), so even after this change, we won't be > placing kexec images onto dax/kmem and virtio-mem added memory. No > change. > b) arch/x86/kernel/crash.c:fill_up_crash_elf_data() -- we're currently > not adding relevant ranges to the crash elf info, resulting in them > not getting dumped via kdump. > > This change fixes loading a crashkernel via kexec_file_load() and including > dax/kmem and virtio-mem added System RAM in the crashdump on x86-64. Note > that e.g,, arm64 relies on memblock data and, therefore, always considers > all added System RAM already. > > Let's find all busy IORESOURCE_SYSTEM_RAM resources, making the function > behave like walk_system_ram_range(). > > Cc: Andrew Morton > Cc: Greg Kroah-Hartman > Cc: Dan Williams > Cc: Daniel Vetter > Cc: Andy Shevchenko > Cc: Mauro Carvalho Chehab > Cc: Signed-off-by: David Hildenbrand > Cc: Dave Young > Cc: Baoquan He > Cc: Vivek Goyal > Cc: Dave Hansen > Cc: Keith Busch > Cc: Michal Hocko > Cc: Qian Cai > Cc: Oscar Salvador > Cc: Eric Biederman > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: "H. Peter Anvin" > Cc: Tom Lendacky > Cc: Brijesh Singh > Cc: x86@kernel.org > Cc: kexec@lists.infradead.org > Signed-off-by: David Hildenbrand > --- > kernel/resource.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/resource.c b/kernel/resource.c > index 627e61b0c124..4efd6e912279 100644 > --- a/kernel/resource.c > +++ b/kernel/resource.c > @@ -457,7 +457,7 @@ int walk_system_ram_res(u64 start, u64 end, void *arg, > { > unsigned long flags = IORESOURCE_SYSTEM_RAM | IORESOURCE_BUSY; > > - return __walk_iomem_res_desc(start, end, flags, IORES_DESC_NONE, true, > + return __walk_iomem_res_desc(start, end, flags, IORES_DESC_NONE, false, > arg, func); Looks good, Reviewed-by: Dan Williams