From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 956D6C433EF for ; Thu, 21 Apr 2022 02:20:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4DD26B0071; Wed, 20 Apr 2022 22:20:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FDDA6B0073; Wed, 20 Apr 2022 22:20:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 876666B0074; Wed, 20 Apr 2022 22:20:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 70F5F6B0071 for ; Wed, 20 Apr 2022 22:20:20 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 28372263B4 for ; Thu, 21 Apr 2022 02:20:20 +0000 (UTC) X-FDA: 79379281800.20.89148B1 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf26.hostedemail.com (Postfix) with ESMTP id 17DBD140016 for ; Thu, 21 Apr 2022 02:20:17 +0000 (UTC) Received: by mail-pj1-f43.google.com with SMTP id e62-20020a17090a6fc400b001d2cd8e9b0aso3794544pjk.5 for ; Wed, 20 Apr 2022 19:20:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=kQqxPFkBgwTTXmjwogf+rVXv18PbhFLAuuZBC/yrNE8=; b=gAbcEDXLXf1cJAOuQcMz7KFmTi65M0OI1L+R+LrFk1NUI5eLmqLTlOn4vgPrp6nUY/ dQ8EWp0H2qkMBdjvMBYO2wzIIvsjpy1iaePWXigztNdFtdY4LjushgcYLJ6wLueUQzot +RTTlMBVrTFQaSuWyKg+rIkYVajru6hHk0/PWkn6Rwqdm6vMiEKgtp+6Fz8196U+b17H fLrovoP/NJEM3D+FfmWiLY9b98NXC3/IQGMrd8WFDXu+foGy5FbJiYgmZGYgDlw9+TBZ J2IJXxjM35dgR6Lar9GJuiBhtnJAlH2enb2vdZWofi4fdk+FwKypjUep97zBA+AIoRjN +R+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=kQqxPFkBgwTTXmjwogf+rVXv18PbhFLAuuZBC/yrNE8=; b=fRzYOUI5RT4jkAsYbHPpXgh8LEsRaL15w0sqsFbbpyWT0ZPjmuVD7iEeduQZ1Sc7UN nzRS3zVFdkwKCq/ny38g4kgNFfxR0Qc5ETixH/a1V1xG2fYGO/Gh+EYaaZRkHACjooYk CosTpIQV++hgsFb4WQRJCsThT0S/g30zpchPJzkC7gSaX3xBfrvJ6j3F6ZH9D6oVO0FO o/Ma5N/MSUBLLjNV8n1sG6erNfPJzIWWvGlNmdSR+stUma1lwgxf/4Hk2iP3Sj3hMkNk jGy6ehZut2k6mFzDM6N0FX5dEKLuzGRkfWW9hjtnP9rR9/ItjhBkIWlat33r2mE3/xdE GlvA== X-Gm-Message-State: AOAM533y51Dk1reAYKGNnLU6GSY4FABoC25qsPf3iy+6EqIe+cN2IQVn 1Y1Pdl/IDCvL4G44K9FzU/WFNgwRp1C4C8sgih7gfQ== X-Google-Smtp-Source: ABdhPJxALQ7XKx0NqGhsKF79EfC7DnemDTaSi9ZA4BMtPhmpe2U+v+sShPr+O2cHd+WfhRLhxANO+I6PBVY9QBU08gY= X-Received: by 2002:a17:902:ea57:b0:15a:6173:87dd with SMTP id r23-20020a170902ea5700b0015a617387ddmr1322664plg.147.1650507618157; Wed, 20 Apr 2022 19:20:18 -0700 (PDT) MIME-Version: 1.0 References: <20220419045045.1664996-1-ruansy.fnst@fujitsu.com> <20220421012045.GR1544202@dread.disaster.area> <86cb0ada-208c-02de-dbc9-53c6014892c3@fujitsu.com> In-Reply-To: <86cb0ada-208c-02de-dbc9-53c6014892c3@fujitsu.com> From: Dan Williams Date: Wed, 20 Apr 2022 19:20:07 -0700 Message-ID: Subject: Re: [PATCH v13 0/7] fsdax: introduce fs query to support reflink To: Shiyang Ruan Cc: Dave Chinner , Linux Kernel Mailing List , linux-xfs , Linux NVDIMM , Linux MM , linux-fsdevel , "Darrick J. Wong" , Christoph Hellwig , Jane Chu , Andrew Morton , Naoya Horiguchi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: hjfeq9oy6q83uhkgzb7jydge5c393gu6 X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=intel-com.20210112.gappssmtp.com header.s=20210112 header.b=gAbcEDXL; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=none (imf26.hostedemail.com: domain of dan.j.williams@intel.com has no SPF policy when checking 209.85.216.43) smtp.mailfrom=dan.j.williams@intel.com X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 17DBD140016 X-HE-Tag: 1650507617-15792 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: [ add Andrew and Naoya ] On Wed, Apr 20, 2022 at 6:48 PM Shiyang Ruan wrot= e: > > Hi Dave, > > =E5=9C=A8 2022/4/21 9:20, Dave Chinner =E5=86=99=E9=81=93: > > Hi Ruan, > > > > On Tue, Apr 19, 2022 at 12:50:38PM +0800, Shiyang Ruan wrote: > >> This patchset is aimed to support shared pages tracking for fsdax. > > > > Now that this is largely reviewed, it's time to work out the > > logistics of merging it. > > Thanks! > > > > >> Changes since V12: > >> - Rebased onto next-20220414 > > > > What does this depend on that is in the linux-next kernel? > > > > i.e. can this be applied successfully to a v5.18-rc2 kernel without > > needing to drag in any other patchsets/commits/trees? > > Firstly, I tried to apply to v5.18-rc2 but it failed. > > There are some changes in memory-failure.c, which besides my Patch-02 > "mm/hwpoison: fix race between hugetlb free/demotion and > memory_failure_hugetlb()" > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi= t/?id=3D423228ce93c6a283132be38d442120c8e4cdb061 > > Then, why it is on linux-next is: I was told[1] there is a better fix > about "pgoff_address()" in linux-next: > "mm: rmap: introduce pfn_mkclean_range() to cleans PTEs" > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi= t/?id=3D65c9605009f8317bb3983519874d755a0b2ca746 > so I rebased my patches to it and dropped one of mine. > > [1] https://lore.kernel.org/linux-xfs/YkPuooGD139Wpg1v@infradead.org/ >From my perspective, once something has -mm dependencies it needs to go through Andrew's tree, and if it's going through Andrew's tree I think that means the reflink side of this needs to wait a cycle as there is no stable point that the XFS tree could merge to build on top of. The last reviewed-by this wants before going through there is Naoya's on the memory-failure.c changes.