From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 843FFC432BE for ; Wed, 28 Jul 2021 07:29:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0793B60EB9 for ; Wed, 28 Jul 2021 07:29:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0793B60EB9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 8F2816B0036; Wed, 28 Jul 2021 03:29:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A2476B005D; Wed, 28 Jul 2021 03:29:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 790D86B006C; Wed, 28 Jul 2021 03:29:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6042A6B0036 for ; Wed, 28 Jul 2021 03:29:55 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0407F18034A7B for ; Wed, 28 Jul 2021 07:29:54 +0000 (UTC) X-FDA: 78411172350.33.35E3BCF Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf29.hostedemail.com (Postfix) with ESMTP id 76F5490223D6 for ; Wed, 28 Jul 2021 07:29:54 +0000 (UTC) Received: by mail-pj1-f42.google.com with SMTP id o44-20020a17090a0a2fb0290176ca3e5a2fso2939164pjo.1 for ; Wed, 28 Jul 2021 00:29:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2S8+P9Er5rx8OhndztunXCa9ZYXKz6ZFsurjIyFPNKI=; b=gqdezsRO/p2YBoDmobyxqSuAOW3vRt4ku2SPejRpps4UMPun0YUJDOhjEzr7HDCaSo WBVu1lOOcsXy1mD+ZjzjRsM7RVnXGnYN9Sp78lblD0zfLD+qTXmNSxEwIKmpGcrngGaz SdO6vKep8ASVg8Jnj96pBB2ZX6AutIZ+h+Wkj019/6st0j0C41zTdD6Bp2Xfw6cZWz1x /0Daiodp/h9zwTK2C6KGbQdYJpW5Lry8tvK5hKcvMWueVFOXJ6tQ4CSmKIONcoaaQpSW IqFc3SPLhIEJveSRWwNC6ohwHyyZL/+Ag4W6YPNUg6UXGPnXN0jqKKXTHtubRZ/YqxcK uT2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2S8+P9Er5rx8OhndztunXCa9ZYXKz6ZFsurjIyFPNKI=; b=p1nZrHIPtaS7jAmDAOZBe748/AvfxMtQKJAACpDOPhhp2EYpkZx2ObZuK25x35ASe/ G+2UmogMtWHnBoaNcSnTkavD/LUSHMK37OktIGRBC1F2a5BxkIeQXCKLqIu72jTuJTWx OoJ+KF+zG91/qhFwZeOnkZYQ2zt2TadT00Lj8xqASapy8PLgY5v9BfEoCJRqCn5OmosO jvOXu622IDzdjGSJ49eyT3pyY72SoE+kPRR3kRmquc3dAJ/0kMCjfRClc4rtzAcKRozU 8G/sGCnpXIirBcmPADbC03meSjA7Ugl0MyNyHHW3yzQrIkJcsB37A52Hq8cSvxFXDvmq 3hug== X-Gm-Message-State: AOAM533tZlX0qP2fuXVxXPV6/tjXMH+/1SEKUr2tEW2pXKmUwv2TGUQF /sYDVxUoRRfnwmDQICvwzZyPXY8TGgGoLkmKCMbHPw== X-Google-Smtp-Source: ABdhPJwCSgiiXe9Ln9i8qGaBPIqEBi67YnKEKmT/EGWvvMj1Z25AvGEZqAAFUqQq71dxAlqNK2jmc743sCGmsO5Gn+M= X-Received: by 2002:a17:902:ab91:b029:12b:8dae:b1ff with SMTP id f17-20020a170902ab91b029012b8daeb1ffmr22005774plr.52.1627457393556; Wed, 28 Jul 2021 00:29:53 -0700 (PDT) MIME-Version: 1.0 References: <20210714193542.21857-1-joao.m.martins@oracle.com> <20210714193542.21857-11-joao.m.martins@oracle.com> In-Reply-To: <20210714193542.21857-11-joao.m.martins@oracle.com> From: Dan Williams Date: Wed, 28 Jul 2021 00:29:42 -0700 Message-ID: Subject: Re: [PATCH v3 10/14] device-dax: use ALIGN() for determining pgoff To: Joao Martins Cc: Linux MM , Vishal Verma , Dave Jiang , Naoya Horiguchi , Matthew Wilcox , Jason Gunthorpe , John Hubbard , Jane Chu , Muchun Song , Mike Kravetz , Andrew Morton , Jonathan Corbet , Linux NVDIMM , Linux Doc Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 76F5490223D6 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=intel-com.20150623.gappssmtp.com header.s=20150623 header.b=gqdezsRO; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=none (imf29.hostedemail.com: domain of dan.j.williams@intel.com has no SPF policy when checking 209.85.216.42) smtp.mailfrom=dan.j.williams@intel.com X-Stat-Signature: q69wm5cxxo7hb48djcmfpujz5ox1k3wm X-HE-Tag: 1627457394-430521 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 14, 2021 at 12:36 PM Joao Martins wrote: > > Rather than calculating @pgoff manually, switch to ALIGN() instead. Looks good, Reviewed-by: Dan Williams > > Suggested-by: Dan Williams > Signed-off-by: Joao Martins > --- > drivers/dax/device.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dax/device.c b/drivers/dax/device.c > index dd8222a42808..0b82159b3564 100644 > --- a/drivers/dax/device.c > +++ b/drivers/dax/device.c > @@ -234,8 +234,8 @@ static vm_fault_t dev_dax_huge_fault(struct vm_fault *vmf, > * mapped. No need to consider the zero page, or racing > * conflicting mappings. > */ > - pgoff = linear_page_index(vmf->vma, vmf->address > - & ~(fault_size - 1)); > + pgoff = linear_page_index(vmf->vma, > + ALIGN(vmf->address, fault_size)); > for (i = 0; i < fault_size / PAGE_SIZE; i++) { > struct page *page; > > -- > 2.17.1 >