From: Dan Williams <dan.j.williams@intel.com>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
david <david@fromorbit.com>,
kasan-dev@googlegroups.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>, Dmitry Vyukov <dvyukov@google.com>,
Alexander Potapenko <glider@google.com>
Subject: Re: [PATCH v2] kernel/memremap, kasan: Make ZONE_DEVICE with work with KASAN
Date: Fri, 29 Jun 2018 10:13:31 -0700 [thread overview]
Message-ID: <CAPcyv4hwgLS+=UWyORqs_dHFu2LSX6pheWVt=zyrby2wneixBA@mail.gmail.com> (raw)
In-Reply-To: <20180629164932.740-1-aryabinin@virtuozzo.com>
On Fri, Jun 29, 2018 at 9:49 AM, Andrey Ryabinin
<aryabinin@virtuozzo.com> wrote:
> KASAN learns about hot added memory via the memory hotplug notifier.
> The devm_memremap_pages() intentionally skips calling memory hotplug
> notifiers. So KASAN doesn't know anything about new memory added
> by devm_memremap_pages(). This causes to crash when KASAN tries to
> access non-existent shadow memory:
>
> BUG: unable to handle kernel paging request at ffffed0078000000
> RIP: 0010:check_memory_region+0x82/0x1e0
> Call Trace:
> memcpy+0x1f/0x50
> pmem_do_bvec+0x163/0x720
> pmem_make_request+0x305/0xac0
> generic_make_request+0x54f/0xcf0
> submit_bio+0x9c/0x370
> submit_bh_wbc+0x4c7/0x700
> block_read_full_page+0x5ef/0x870
> do_read_cache_page+0x2b8/0xb30
> read_dev_sector+0xbd/0x3f0
> read_lba.isra.0+0x277/0x670
> efi_partition+0x41a/0x18f0
> check_partition+0x30d/0x5e9
> rescan_partitions+0x18c/0x840
> __blkdev_get+0x859/0x1060
> blkdev_get+0x23f/0x810
> __device_add_disk+0x9c8/0xde0
> pmem_attach_disk+0x9a8/0xf50
> nvdimm_bus_probe+0xf3/0x3c0
> driver_probe_device+0x493/0xbd0
> bus_for_each_drv+0x118/0x1b0
> __device_attach+0x1cd/0x2b0
> bus_probe_device+0x1ac/0x260
> device_add+0x90d/0x1380
> nd_async_device_register+0xe/0x50
> async_run_entry_fn+0xc3/0x5d0
> process_one_work+0xa0a/0x1810
> worker_thread+0x87/0xe80
> kthread+0x2d7/0x390
> ret_from_fork+0x3a/0x50
>
> Add kasan_add_zero_shadow()/kasan_remove_zero_shadow() - post mm_init()
> interface to map/unmap kasan_zero_page at requested virtual addresses.
> And use it to add/remove the shadow memory for hotpluged/unpluged
> device memory.
>
> Reported-by: Dave Chinner <david@fromorbit.com>
> Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Dmitry Vyukov <dvyukov@google.com>
> Cc: Alexander Potapenko <glider@google.com>
Reviewed-and-tested-by: Dan Williams <dan.j.williams@intel.com>
next prev parent reply other threads:[~2018-06-29 17:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 17:02 [PATCH] " Andrey Ryabinin
2018-06-25 19:51 ` kbuild test robot
2018-06-25 20:15 ` kbuild test robot
2018-06-29 16:49 ` [PATCH v2] " Andrey Ryabinin
2018-06-29 17:13 ` Dan Williams [this message]
2018-06-30 2:33 ` Andrew Morton
2018-06-30 3:19 ` Dan Williams
2018-07-02 17:22 ` Andrey Ryabinin
2018-07-02 17:28 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4hwgLS+=UWyORqs_dHFu2LSX6pheWVt=zyrby2wneixBA@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=david@fromorbit.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox