From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94FC4C4338F for ; Wed, 28 Jul 2021 07:30:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 11A7560F93 for ; Wed, 28 Jul 2021 07:30:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 11A7560F93 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B13A86B005D; Wed, 28 Jul 2021 03:30:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC4016B006C; Wed, 28 Jul 2021 03:30:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B2FC6B0070; Wed, 28 Jul 2021 03:30:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0250.hostedemail.com [216.40.44.250]) by kanga.kvack.org (Postfix) with ESMTP id C60FF6B005D for ; Wed, 28 Jul 2021 03:30:45 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id BC5601803F93D for ; Wed, 28 Jul 2021 07:30:42 +0000 (UTC) X-FDA: 78411174324.33.E1FF63A Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf10.hostedemail.com (Postfix) with ESMTP id 7216B60059AE for ; Wed, 28 Jul 2021 07:30:42 +0000 (UTC) Received: by mail-pj1-f46.google.com with SMTP id k4-20020a17090a5144b02901731c776526so8628220pjm.4 for ; Wed, 28 Jul 2021 00:30:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NqBINzippdeAi2AUoM8Hkgi2WKFqvanJBMGmS1p+Xcs=; b=m8+KioYWU5HcHAf03pb9llrLo1TzP76HPELHuGb/Etbo8asLxCQSh9F/oGXlIiB6GM uVA47IXLQRBJzElI3CMtSS1swD/F+dIDTZ8/is84Qigm0BbQ4liDCW3YVcKcsVgr7zjn iX0HWTmyCyWrhOCD1vL3tGmfwhK7AkTk2hV4qb2uLNNECKf6bVqEE57aiZ/7xxRIhf0G BBQz3JKlXxxq1w4iR4D5R0LsuqZNQbMyo+T8Uk4IA/9f45q0PeMX2NRuQVmP2StJ7n3z q3TOMEMGnt8skKjG6IFHe8HSqt7oe+TD5+xshm5BYIe45oIl+ZYRLPbjqX4mkQTyGSWW y2Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NqBINzippdeAi2AUoM8Hkgi2WKFqvanJBMGmS1p+Xcs=; b=NeHJLXK1aIPZUkEUabArn3vIctNq566rqaH0zneEeV3+BDyobhvKQTmADchs57Myxx VT+FCkbJy3u+JyPtvbsEbqTfRO7Uo5o5YhbLdue4jItSiUFYl+WqNr92K69Zk1S/aiFt qFoWT5C9ZVmuo0d16egTS0Li9F5G/dBXRhdBxuV9ZWu0D/1DAdCIqLxRuwBP5hNTzvZb +ybg24qqY1HB4Iu24TFFrQaPWVd+rXGSFUk9Q2huz7pLNAQPtoAJ7wHihwgkrhVjB53o gNkWGSZwlfEwHTuKVofkzyzOIkjW51kapTR2kx7RGyczYcPuWTLrDR1fHjE33E6mmNko P5pA== X-Gm-Message-State: AOAM530qeGQHasylfYAa4QzuqM8Vzg97I7MrJ+OOGhWijaquDCPFySEW u5sOdvfeuUeAyEkWJ7Y120qFkfcWPWJCDMEYs1a26Q== X-Google-Smtp-Source: ABdhPJxyIIHHl86lkJ8BKYd8Sr40+PFPjq08zj2oGDSc7bXZBce3xcsJXqCNSwrIRSxqXD0wTgM3ITFht3olLzROjE4= X-Received: by 2002:a65:5544:: with SMTP id t4mr27532425pgr.240.1627457441692; Wed, 28 Jul 2021 00:30:41 -0700 (PDT) MIME-Version: 1.0 References: <20210714193542.21857-1-joao.m.martins@oracle.com> <20210714193542.21857-12-joao.m.martins@oracle.com> In-Reply-To: <20210714193542.21857-12-joao.m.martins@oracle.com> From: Dan Williams Date: Wed, 28 Jul 2021 00:30:30 -0700 Message-ID: Subject: Re: [PATCH v3 11/14] device-dax: ensure dev_dax->pgmap is valid for dynamic devices To: Joao Martins Cc: Linux MM , Vishal Verma , Dave Jiang , Naoya Horiguchi , Matthew Wilcox , Jason Gunthorpe , John Hubbard , Jane Chu , Muchun Song , Mike Kravetz , Andrew Morton , Jonathan Corbet , Linux NVDIMM , Linux Doc Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7216B60059AE Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=intel-com.20150623.gappssmtp.com header.s=20150623 header.b=m8+KioYW; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=none (imf10.hostedemail.com: domain of dan.j.williams@intel.com has no SPF policy when checking 209.85.216.46) smtp.mailfrom=dan.j.williams@intel.com X-Stat-Signature: 7ocka5ecm9efqayjgqdkiw3hqsyb47hb X-HE-Tag: 1627457442-257342 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 14, 2021 at 12:36 PM Joao Martins wrote: > > Right now, only static dax regions have a valid @pgmap pointer in its > struct dev_dax. Dynamic dax case however, do not. > > In preparation for device-dax compound pagemap support, make sure that > dev_dax pgmap field is set after it has been allocated and initialized. I think this is ok to fold into the patch that needs it. > > Suggested-by: Dan Williams > Signed-off-by: Joao Martins > --- > drivers/dax/device.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/dax/device.c b/drivers/dax/device.c > index 0b82159b3564..6e348b5f9d45 100644 > --- a/drivers/dax/device.c > +++ b/drivers/dax/device.c > @@ -426,6 +426,8 @@ int dev_dax_probe(struct dev_dax *dev_dax) > } > > pgmap->type = MEMORY_DEVICE_GENERIC; > + dev_dax->pgmap = pgmap; > + > addr = devm_memremap_pages(dev, pgmap); > if (IS_ERR(addr)) > return PTR_ERR(addr); > -- > 2.17.1 >