From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DC56C433E0 for ; Tue, 16 Jun 2020 17:00:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4A9C2208E4 for ; Tue, 16 Jun 2020 17:00:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="eaKMvZWe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A9C2208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E254D8D0022; Tue, 16 Jun 2020 13:00:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DAE3D8D0006; Tue, 16 Jun 2020 13:00:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC3B58D0022; Tue, 16 Jun 2020 13:00:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B2A028D0006 for ; Tue, 16 Jun 2020 13:00:57 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 6799D829662C for ; Tue, 16 Jun 2020 17:00:57 +0000 (UTC) X-FDA: 76935689754.08.match19_2f03f2026e00 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id A775C183F0900 for ; Tue, 16 Jun 2020 17:00:52 +0000 (UTC) X-HE-Tag: match19_2f03f2026e00 X-Filterd-Recvd-Size: 4524 Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Tue, 16 Jun 2020 17:00:51 +0000 (UTC) Received: by mail-ed1-f65.google.com with SMTP id p18so14823438eds.7 for ; Tue, 16 Jun 2020 10:00:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dPeuMd1WEvJ1ma7aQCw6zXV4QVdt7ZfI0Cfl/8xUDIM=; b=eaKMvZWei9R2XyacgUoysVdJc068IXP0NNd/XrABL5Fs96V0/mUo0avQdjYOlpxSFd e9b1R8aS7VarUTJHJSzN3qb1YGADscXGqARaOV3vmLZwRq0OzpklWLOuWFTgnhGSi2mE XGQyPt2OX112Xs45OsWmyUUmnceiRdwaIqNB53Q4Z/fz+eP5lTK3V6j6ScJRiC0VUz5P 3iCL506atUQ329qDSBG5dw0RHxyv6QZauGlfgpNqu9IGSf3hm5/rqM462W+Yapt1TEud tAzCYJ+D5SrOkPgEgljnTmTikMdu2EKN1cYTbm/V02lyTZwYevLgbpejj2xgMRj0BvOd tYaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dPeuMd1WEvJ1ma7aQCw6zXV4QVdt7ZfI0Cfl/8xUDIM=; b=diQAMtMyoO6MCz59IwoVHorrtarBj8W5vjpK/dmPwysNuIeJy9SbiMGK/cgIpjH0vh v01nwai2xHX4Sh5Nk1TV04tmIvP1U8svE8FMLu3LGGzb0F5vbKFSCvciI6V38a9Sj2NM SOJ/lsCfgEZwyY9nC4HRVl38olFLU+ZSIkEt2SFEIQ4a5PmmJG+GJw6pPZe/OnINmTJI 9KvLaqBmqOyPpPwMPuObyuM7SkiBsUon8Q5DD1+8/ovhsqq7wTTJfScCIBY8RLSbMDwE C83kRpXEiFY54kFp6S7HL/lHXi3yq1pVmIN1repyCc6rZSTn6/1V6KV9RAEDTK0sEjPO s6hA== X-Gm-Message-State: AOAM530fIV+D+kQ45K2kFZq2tnlEkFOClNSARKOhbQcqle9SHcm564XT KX2hpnWXL0La9qC7FxfvteB2jpTgKvwW1Yub0XMsdg== X-Google-Smtp-Source: ABdhPJyfIkb+AkO/SqC7bmIMe89rUqNRgupadojlXmAms/5ZoR75qQ7LiyI9oncPtq8Ui1V9UYIwxYqtwmFDhUUuWek= X-Received: by 2002:a05:6402:459:: with SMTP id p25mr1572935edw.383.1592326850286; Tue, 16 Jun 2020 10:00:50 -0700 (PDT) MIME-Version: 1.0 References: <20200616115213.13109-1-david@redhat.com> <20200616115213.13109-3-david@redhat.com> <20200616125051.GH9499@dhcp22.suse.cz> In-Reply-To: <20200616125051.GH9499@dhcp22.suse.cz> From: Dan Williams Date: Tue, 16 Jun 2020 10:00:39 -0700 Message-ID: Subject: Re: [PATCH v1 2/3] mm/memory_hotplug: don't shuffle complete zone when onlining memory To: Michal Hocko Cc: David Hildenbrand , Linux Kernel Mailing List , Linux MM , Andrew Morton , Alexander Duyck , Dave Hansen , Kees Cook , Mel Gorman Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: A775C183F0900 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 16, 2020 at 5:51 AM Michal Hocko wrote: > > On Tue 16-06-20 13:52:12, David Hildenbrand wrote: > > Commit e900a918b098 ("mm: shuffle initial free memory to improve > > memory-side-cache utilization") introduced shuffling of free pages > > during system boot and whenever we online memory blocks. > > > > However, whenever we online memory blocks, all pages that will be > > exposed to the buddy end up getting freed via __free_one_page(). In the > > general case, we free these pages in MAX_ORDER - 1 chunks, which > > corresponds to the shuffle order. > > > > Inside __free_one_page(), we will already shuffle the newly onlined pages > > using "to_tail = shuffle_pick_tail();". Drop explicit zone shuffling on > > memory hotplug. > > > > Note: When hotplugging a DIMM, each memory block (e.g., 128MB .. 2G on > > x86-64) will get onlined individually, resulting in a shuffle_zone() for > > every memory block getting onlined. > > > > Cc: Andrew Morton > > Cc: Alexander Duyck > > Cc: Dan Williams > > Cc: Michal Hocko > > Cc: Dave Hansen > > Cc: Kees Cook > > Cc: Mel Gorman > > Signed-off-by: David Hildenbrand > > Acked-by: Michal Hocko Nacked-by: Dan Williams As explained in another thread this is in active use.