From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 540B3C46477 for ; Fri, 14 Jun 2019 18:57:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 107A12168B for ; Fri, 14 Jun 2019 18:57:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="F85MjR0g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 107A12168B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8555F6B0006; Fri, 14 Jun 2019 14:57:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 805966B0007; Fri, 14 Jun 2019 14:57:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F48E6B000C; Fri, 14 Jun 2019 14:57:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) by kanga.kvack.org (Postfix) with ESMTP id 42DFB6B0006 for ; Fri, 14 Jun 2019 14:57:58 -0400 (EDT) Received: by mail-oi1-f199.google.com with SMTP id r6so1257521oib.6 for ; Fri, 14 Jun 2019 11:57:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:mime-version:references :in-reply-to:from:date:message-id:subject:to:cc; bh=oY348vpCG95iTNSMF3TDF4pbwXas3ck/kElwYiwrsvw=; b=AEe0LUsafccBcXJCwqaKm9h1TxHew1KE2ABlX5dvI5obbLzLH5i5awMAFsOq4TGhIO OE2eEaqVKM5ZR/Mcppa0iqMGyNfMCE7hkRr1UQZlduex9NRsuEkVmUw8Li+ZGc3iqcJ1 61M02ARDARMr/r++PQ+k4gV0jA0qVapeMPzQutt2MTZ6SyYMY/YuqtkBN8ynwVVQi+gK jMvRG82qp8Jg6U2v0vjnuKDvdPl/SLod+ooSbGJljYAZbVK2MwwO67nNCWsBd1HmcYlG 3iw3zU4e7duwQuR8G1R+5hs+E/JDk9x5HRjWTFVOVR+CMI8uiTTbXgb0emglqlc8mS5s Mevw== X-Gm-Message-State: APjAAAXQf5V88TescZvcvJyd1rgu9Nad6v97TCGGebN01Ul7St+a+RHO L+Y8laDt/IkJRr6Czka+dMX8PfWTWT75/APIrMVRo628my3w1mCO7WZ/E0I0w53z0eibbRm5Cse 2hyvfs9E8qk0JZEPRpBKGm/xHdN7jrYQqzchdN15u4eoZoJI6Pbgg7FYvrtBx9fSYVw== X-Received: by 2002:aca:330b:: with SMTP id z11mr2664170oiz.148.1560538677806; Fri, 14 Jun 2019 11:57:57 -0700 (PDT) X-Received: by 2002:aca:330b:: with SMTP id z11mr2664135oiz.148.1560538677059; Fri, 14 Jun 2019 11:57:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560538677; cv=none; d=google.com; s=arc-20160816; b=e0x3qg2cSOBLxx+Us72UNyv693AhMY8vj1L1GnMjCRDFewYmyDcgQ0OfwMgrxcw90/ vhvvG+7rUFQHdFMdvgGc0dvWB0/CuTvEC9bpe0qBLli28HtNysFr7CibeK/N90+Ip05M E+fbti09mAGemNgXPsRCHuIaKFojkOccl96UusLv7hjRevKEKdY5WPl9jZ54o7x3k4h0 6QVMhXC3hGsjTJWofhRJXgNlUWt9iF1PBBCi1y46FI++/xSYuT036r9KO83BcjCPc0oS 6g62sWtXJp0lEif5zVTOJ/C7QVM3lV/VIIs2VxSXPkXOtG6qLeEZJrPeGdoKrAxRz3aI M70w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=oY348vpCG95iTNSMF3TDF4pbwXas3ck/kElwYiwrsvw=; b=O1ketPrxG8ITz6/zf/sjkd9VLqnHFPj2xduy68lqtZ47oDnRpm+ntWPohhttkxzL6i 58a/J3FZHh617bGygkPclxil1u8/V6UniZYJc5UYGTVuTjoaPWKZGgi1uiCTvNuKi6gD 4PBDVcrwtL3yTsERmnaC60B24gYeQGsJxkahuDjW9QU60Ff0jPdcidbBj3aMUYxQ+eTF Kgvyu0W/ZURloQfo5KchUDmVs3PoBT/Epwkvsdo+7hC1hhA0JrCVwoCUqr+k3t2EzkZR K/9rcdX0m1qRBXH7WPp+Ed5bsahSsiio3aB3qOqdY6JCbjlSoQeKj84fgcgspXvw1Uwm HCoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=F85MjR0g; spf=pass (google.com: domain of dan.j.williams@intel.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id p5sor1541024oia.156.2019.06.14.11.57.56 for (Google Transport Security); Fri, 14 Jun 2019 11:57:56 -0700 (PDT) Received-SPF: pass (google.com: domain of dan.j.williams@intel.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=F85MjR0g; spf=pass (google.com: domain of dan.j.williams@intel.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oY348vpCG95iTNSMF3TDF4pbwXas3ck/kElwYiwrsvw=; b=F85MjR0gN90YTSSPhCUn9lf3+gAUAMWR5V9MYVfBOrCJQ1H3hiLjul2ugj7VnpOTBa i9Sp+K18uEQofN4tumrHUXaqcMNxTu6cGGZm6yttT/JpXMgr1xATwuYNtg+gZXBCVGhv +mT01bZVNXo9pF/l9GffY/mlArCMf2aa3APCyIJWkZmcBddGaH8yofAJhPmyebNaOItK N8sIZN8LJ3WJtxM2h/reyObc1JIGEWlLWAB5zVkxh/YE/W9nGbnxAAcfvDIFMf4k5Cqq x5e4uXA4P1jBGWyObYdHmdFkNCTlR8nUiUTvIRg4KrDsp+lPH7/kprCmsmkBnMQBnyoi M7KQ== X-Google-Smtp-Source: APXvYqzdJjEMIV2pl920MqFFLoWETfGaqo1sZN3VwAO8LaYfKv/sIYkMWWbQLkGsWPRjVz6yQawZkMZ47z54qwd7laI= X-Received: by 2002:aca:4208:: with SMTP id p8mr2892814oia.105.1560538675845; Fri, 14 Jun 2019 11:57:55 -0700 (PDT) MIME-Version: 1.0 References: <1560366952-10660-1-git-send-email-cai@lca.pw> <1560376072.5154.6.camel@lca.pw> <87lfy4ilvj.fsf@linux.ibm.com> <1560524365.5154.21.camel@lca.pw> In-Reply-To: From: Dan Williams Date: Fri, 14 Jun 2019 11:57:44 -0700 Message-ID: Subject: Re: [PATCH -next] mm/hotplug: skip bad PFNs from pfn_to_online_page() To: Qian Cai Cc: "Aneesh Kumar K.V" , Andrew Morton , Oscar Salvador , Linux MM , Linux Kernel Mailing List Content-Type: multipart/mixed; boundary="0000000000006edde2058b4d3902" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --0000000000006edde2058b4d3902 Content-Type: text/plain; charset="UTF-8" On Fri, Jun 14, 2019 at 11:03 AM Dan Williams wrote: > > On Fri, Jun 14, 2019 at 7:59 AM Qian Cai wrote: > > > > On Fri, 2019-06-14 at 14:28 +0530, Aneesh Kumar K.V wrote: > > > Qian Cai writes: > > > > > > > > > > 1) offline is busted [1]. It looks like test_pages_in_a_zone() missed the > > > > same > > > > pfn_section_valid() check. > > > > > > > > 2) powerpc booting is generating endless warnings [2]. In > > > > vmemmap_populated() at > > > > arch/powerpc/mm/init_64.c, I tried to change PAGES_PER_SECTION to > > > > PAGES_PER_SUBSECTION, but it alone seems not enough. > > > > > > > > > > Can you check with this change on ppc64. I haven't reviewed this series yet. > > > I did limited testing with change . Before merging this I need to go > > > through the full series again. The vmemmap poplulate on ppc64 needs to > > > handle two translation mode (hash and radix). With respect to vmemap > > > hash doesn't setup a translation in the linux page table. Hence we need > > > to make sure we don't try to setup a mapping for a range which is > > > arleady convered by an existing mapping. > > > > It works fine. > > Strange... it would only change behavior if valid_section() is true > when pfn_valid() is not or vice versa. They "should" be identical > because subsection-size == section-size on PowerPC, at least with the > current definition of SUBSECTION_SHIFT. I suspect maybe > free_area_init_nodes() is too late to call subsection_map_init() for > PowerPC. Can you give the attached incremental patch a try? This will break support for doing sub-section hot-add in a section that was only partially populated early at init, but that can be repaired later in the series. First things first, don't regress. diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 874eb22d22e4..520c83aa0fec 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -7286,12 +7286,10 @@ void __init free_area_init_nodes(unsigned long *max_zone_pfn) /* Print out the early node map */ pr_info("Early memory node ranges\n"); - for_each_mem_pfn_range(i, MAX_NUMNODES, &start_pfn, &end_pfn, &nid) { + for_each_mem_pfn_range(i, MAX_NUMNODES, &start_pfn, &end_pfn, &nid) pr_info(" node %3d: [mem %#018Lx-%#018Lx]\n", nid, (u64)start_pfn << PAGE_SHIFT, ((u64)end_pfn << PAGE_SHIFT) - 1); - subsection_map_init(start_pfn, end_pfn - start_pfn); - } /* Initialise every node */ mminit_verify_pageflags_layout(); diff --git a/mm/sparse.c b/mm/sparse.c index 0baa2e55cfdd..bca8e6fa72d2 100644 --- a/mm/sparse.c +++ b/mm/sparse.c @@ -533,6 +533,7 @@ static void __init sparse_init_nid(int nid, unsigned long pnum_begin, } check_usemap_section_nr(nid, usage); sparse_init_one_section(__nr_to_section(pnum), pnum, map, usage); + subsection_map_init(section_nr_to_pfn(pnum), PAGES_PER_SECTION); usage = (void *) usage + mem_section_usage_size(); } sparse_buffer_fini(); --0000000000006edde2058b4d3902 Content-Type: text/x-patch; charset="US-ASCII"; name="fix.patch" Content-Disposition: attachment; filename="fix.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jwwgclts0 ZGlmZiAtLWdpdCBhL21tL3BhZ2VfYWxsb2MuYyBiL21tL3BhZ2VfYWxsb2MuYwppbmRleCA4NzRl YjIyZDIyZTQuLjUyMGM4M2FhMGZlYyAxMDA2NDQKLS0tIGEvbW0vcGFnZV9hbGxvYy5jCisrKyBi L21tL3BhZ2VfYWxsb2MuYwpAQCAtNzI4NiwxMiArNzI4NiwxMCBAQCB2b2lkIF9faW5pdCBmcmVl X2FyZWFfaW5pdF9ub2Rlcyh1bnNpZ25lZCBsb25nICptYXhfem9uZV9wZm4pCiAKIAkvKiBQcmlu dCBvdXQgdGhlIGVhcmx5IG5vZGUgbWFwICovCiAJcHJfaW5mbygiRWFybHkgbWVtb3J5IG5vZGUg cmFuZ2VzXG4iKTsKLQlmb3JfZWFjaF9tZW1fcGZuX3JhbmdlKGksIE1BWF9OVU1OT0RFUywgJnN0 YXJ0X3BmbiwgJmVuZF9wZm4sICZuaWQpIHsKKwlmb3JfZWFjaF9tZW1fcGZuX3JhbmdlKGksIE1B WF9OVU1OT0RFUywgJnN0YXJ0X3BmbiwgJmVuZF9wZm4sICZuaWQpCiAJCXByX2luZm8oIiAgbm9k ZSAlM2Q6IFttZW0gJSMwMThMeC0lIzAxOEx4XVxuIiwgbmlkLAogCQkJKHU2NClzdGFydF9wZm4g PDwgUEFHRV9TSElGVCwKIAkJCSgodTY0KWVuZF9wZm4gPDwgUEFHRV9TSElGVCkgLSAxKTsKLQkJ c3Vic2VjdGlvbl9tYXBfaW5pdChzdGFydF9wZm4sIGVuZF9wZm4gLSBzdGFydF9wZm4pOwotCX0K IAogCS8qIEluaXRpYWxpc2UgZXZlcnkgbm9kZSAqLwogCW1taW5pdF92ZXJpZnlfcGFnZWZsYWdz X2xheW91dCgpOwpkaWZmIC0tZ2l0IGEvbW0vc3BhcnNlLmMgYi9tbS9zcGFyc2UuYwppbmRleCAw YmFhMmU1NWNmZGQuLmJjYThlNmZhNzJkMiAxMDA2NDQKLS0tIGEvbW0vc3BhcnNlLmMKKysrIGIv bW0vc3BhcnNlLmMKQEAgLTUzMyw2ICs1MzMsNyBAQCBzdGF0aWMgdm9pZCBfX2luaXQgc3BhcnNl X2luaXRfbmlkKGludCBuaWQsIHVuc2lnbmVkIGxvbmcgcG51bV9iZWdpbiwKIAkJfQogCQljaGVj a191c2VtYXBfc2VjdGlvbl9ucihuaWQsIHVzYWdlKTsKIAkJc3BhcnNlX2luaXRfb25lX3NlY3Rp b24oX19ucl90b19zZWN0aW9uKHBudW0pLCBwbnVtLCBtYXAsIHVzYWdlKTsKKwkJc3Vic2VjdGlv bl9tYXBfaW5pdChzZWN0aW9uX25yX3RvX3BmbihwbnVtKSwgUEFHRVNfUEVSX1NFQ1RJT04pOwog CQl1c2FnZSA9ICh2b2lkICopIHVzYWdlICsgbWVtX3NlY3Rpb25fdXNhZ2Vfc2l6ZSgpOwogCX0K IAlzcGFyc2VfYnVmZmVyX2ZpbmkoKTsK --0000000000006edde2058b4d3902--