From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f71.google.com (mail-oi0-f71.google.com [209.85.218.71]) by kanga.kvack.org (Postfix) with ESMTP id 410356B0253 for ; Mon, 6 Feb 2017 12:30:24 -0500 (EST) Received: by mail-oi0-f71.google.com with SMTP id j82so84218086oih.6 for ; Mon, 06 Feb 2017 09:30:24 -0800 (PST) Received: from mail-oi0-x235.google.com (mail-oi0-x235.google.com. [2607:f8b0:4003:c06::235]) by mx.google.com with ESMTPS id n187si530440oih.239.2017.02.06.09.30.23 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Feb 2017 09:30:23 -0800 (PST) Received: by mail-oi0-x235.google.com with SMTP id u143so50713182oif.3 for ; Mon, 06 Feb 2017 09:30:23 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20170206172731.GA17515@infradead.org> References: <148615748258.43180.1690152053774975329.stgit@djiang5-desk3.ch.intel.com> <20170206143648.GA461@infradead.org> <20170206172731.GA17515@infradead.org> From: Dan Williams Date: Mon, 6 Feb 2017 09:30:22 -0800 Message-ID: Subject: Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Hellwig Cc: Matthew Wilcox , "linux-nvdimm@lists.01.org" , Dave Hansen , linux-xfs@vger.kernel.org, Linux MM , Vlastimil Babka , Jan Kara , Andrew Morton , linux-ext4 , "Kirill A. Shutemov" On Mon, Feb 6, 2017 at 9:27 AM, Christoph Hellwig wrote: > On Mon, Feb 06, 2017 at 08:24:48AM -0800, Dan Williams wrote: >> > Also can be use this opportunity >> > to fold ->huge_fault into ->fault? >> >> Hmm, yes, just need a scheme to not attempt huge_faults on pte-only handlers. > > Do we need anything more than checking vma->vm_flags for VM_HUGETLB? s/VM_HUGETLB/VM_HUGEPAGE/ ...but yes as long as we specify that a VM_HUGEPAGE handler must minimally handle pud and pmd. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org