linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Toshi Kani <toshi.kani@hp.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	travis@sgi.com, roland@purestorage.com,
	Luis Rodriguez <mcgrof@suse.com>, X86 ML <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH RESEND 0/3] mm, x86: Fix ioremap RAM check interfaces
Date: Fri, 17 Jul 2015 18:23:35 -0700	[thread overview]
Message-ID: <CAPcyv4hgKmd2V_7FeDLi4cb2EQOPtX4QWhKU1bZBGcKXFFVfDw@mail.gmail.com> (raw)
In-Reply-To: <1437088996-28511-1-git-send-email-toshi.kani@hp.com>

On Thu, Jul 16, 2015 at 4:23 PM, Toshi Kani <toshi.kani@hp.com> wrote:
> ioremap() checks if a target range is in RAM and fails the request
> if true.  There are multiple issues in the iormap RAM check interfaces.
>
>  1. region_is_ram() always fails with -1.
>  2. The check calls two functions, region_is_ram() and
>     walk_system_ram_range(), which are redundant as both walk the
>     same iomem_resource table.
>  3. walk_system_ram_range() requires RAM ranges be page-aligned in
>     the iomem_resource table to work properly.  This restriction
>     has allowed multiple ioremaps to RAM which are page-unaligned.
>
> This patchset solves issue 1 and 2.  It does not address issue 3,
> but continues to allow the existing ioremaps to work until it is
> addressed.
>
> ---
> resend:
>  - Rebased to 4.2-rc2 (no change needed). Modified change logs.
>
> ---
> Toshi Kani (3):
>   1/3 mm, x86: Fix warning in ioremap RAM check
>   2/3 mm, x86: Remove region_is_ram() call from ioremap
>   3/3 mm: Fix bugs in region_is_ram()
>

For the series...

Reviewed-by: Dan Williams <dan.j.williams@intel.com>

I'm going to base my ioremap + memremap series on top of these fixes.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      parent reply	other threads:[~2015-07-18  1:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16 23:23 Toshi Kani
2015-07-16 23:23 ` [PATCH RESEND 1/3] mm, x86: Fix warning in ioremap RAM check Toshi Kani
2015-07-16 23:23 ` [PATCH RESEND 2/3] mm, x86: Remove region_is_ram() call from ioremap Toshi Kani
2015-07-21 14:31   ` Thomas Gleixner
2015-07-21 15:07     ` Toshi Kani
2015-07-16 23:23 ` [PATCH RESEND 3/3] mm: Fix bugs in region_is_ram() Toshi Kani
2015-07-18  1:23 ` Dan Williams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPcyv4hgKmd2V_7FeDLi4cb2EQOPtX4QWhKU1bZBGcKXFFVfDw@mail.gmail.com \
    --to=dan.j.williams@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mcgrof@suse.com \
    --cc=mingo@redhat.com \
    --cc=roland@purestorage.com \
    --cc=tglx@linutronix.de \
    --cc=toshi.kani@hp.com \
    --cc=travis@sgi.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox