From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C596CC282DD for ; Wed, 8 Jan 2020 19:00:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6C39020678 for ; Wed, 8 Jan 2020 19:00:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="s9NJQtCq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C39020678 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C54048E0005; Wed, 8 Jan 2020 14:00:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C03EF8E0001; Wed, 8 Jan 2020 14:00:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF1EF8E0005; Wed, 8 Jan 2020 14:00:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0131.hostedemail.com [216.40.44.131]) by kanga.kvack.org (Postfix) with ESMTP id 96BDE8E0001 for ; Wed, 8 Jan 2020 14:00:04 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 2D9C7282B for ; Wed, 8 Jan 2020 19:00:04 +0000 (UTC) X-FDA: 76355381928.08.floor31_7710319ce5b X-HE-Tag: floor31_7710319ce5b X-Filterd-Recvd-Size: 4438 Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Wed, 8 Jan 2020 19:00:02 +0000 (UTC) Received: by mail-ot1-f68.google.com with SMTP id k14so4637581otn.4 for ; Wed, 08 Jan 2020 11:00:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XKG1nbVwzj/tRpstff6fH6LSUuwV4sjHhIFUgWIlV+U=; b=s9NJQtCqnectin8Ti+6PJbbfj1iVC29kijEEVzBm9eYM0xqovEdSIvUBRa5QV+2Qzf uMjhO+nADZCdf/v+dinki4tHGe/eBYjmY78A0B9gngLOIJZSvsYSGQUcFghNBkzajBm+ 002VIJLs2HYb6/7/565YtsSdwQ7BoFsW7F2g/8JhRZm5aaupLnZ+WjxKHOUtdugZXa+v M5Cfg0EYtVYHOoLi8prNlcRFGlvf0CrScWNFvhySDu/GUL/m4BLe/M+OqS31fpVqrUm6 /h5oOCVTEniuxvpSTmawQh4xsO4jXbtbwJSxpi9ba8XLCoKCbuSjDDKpfn0F41JYkU5K 2q8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XKG1nbVwzj/tRpstff6fH6LSUuwV4sjHhIFUgWIlV+U=; b=tVsGHh7q3bmjtPNKgf/m7xOeIzWEWW1+ijk2PSWlx6Dj3kBQFQo7dbtXEHwu6/THDA us2p9ht6z0ntoOkpf3tt6+Dk7FNNIJn3ywNgVyXS01vHR1eZLYB+zzOT3JGX0efFLkAa sLnqoxijEE6VxebRUsiuAVzJaTLZ+lEPqH2We+7QLYKDnoJtTrQl7AvG49Hf//d/FdZt Z/O46x1/J3HoKoDdQN29pol3i1DYplk8usMc9l54C0mU/aeAG4gBeRckVf/4pymFs5/Q YAMz0KbYPEZ2G3ryXcooJl4u0fFumrWK9kGVCmB3CtGQVL6cgAphkP1kxrg2IKHa5iM5 /4bg== X-Gm-Message-State: APjAAAW5iyePe7KKZCvlknyHKCugXveR7O6QcDsKQog3Ju0rCJKGL37O dyT62dbnQMjm4cEDcl+Z3jfMITEtSUcSRcPN2aG1sw== X-Google-Smtp-Source: APXvYqxCuOUFRmTIFvW4iH38UfBo5T8KUr6T2q9RXS3eopOSB7fDf5LWtiL93/r45iWPoVq/UfuDWeRs67v8mZX9sdI= X-Received: by 2002:a9d:68d3:: with SMTP id i19mr4939869oto.71.1578510001998; Wed, 08 Jan 2020 11:00:01 -0800 (PST) MIME-Version: 1.0 References: <20200107205959.7575-1-logang@deltatee.com> <20200107205959.7575-3-logang@deltatee.com> <3e432695-e3a9-2aae-e9f5-1b6454886c06@redhat.com> In-Reply-To: From: Dan Williams Date: Wed, 8 Jan 2020 10:59:51 -0800 Message-ID: Subject: Re: [PATCH v2 2/8] mm/memory_hotplug: Rename mhp_restrictions to mhp_modifiers To: Logan Gunthorpe Cc: David Hildenbrand , Linux Kernel Mailing List , Linux ARM , linux-ia64@vger.kernel.org, linuxppc-dev , linux-s390 , Linux-sh , platform-driver-x86@vger.kernel.org, Linux MM , Michal Hocko , Andrew Morton , Christoph Hellwig , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Eric Badger Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 8, 2020 at 9:17 AM Logan Gunthorpe wrote: > > > > On 2020-01-08 5:28 a.m., David Hildenbrand wrote: > > On 07.01.20 21:59, Logan Gunthorpe wrote: > >> The mhp_restrictions struct really doesn't specify anything resembling > >> a restriction anymore so rename it to be mhp_modifiers. > > > > I wonder if something like "mhp_params" would be even better. It's > > essentially just a way to avoid changing call chains rough-out all archs > > whenever we want to add a new parameter. > > Sure, that does sound a bit nicer to me. I can change it for v3. Oh, I was just about to chime in to support "modifiers" because I would expect all parameters to folded into a "params" struct. The modifiers seem to be limited to the set of items that are only considered in a non-default / expert memory hotplug use cases.