From: Dan Williams <dan.j.williams@intel.com>
To: Murphy Zhou <jencce.kernel@gmail.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>,
Jia He <justin.he@arm.com>, Linux MM <linux-mm@kvack.org>,
"Shutemov, Kirill" <kirill.shutemov@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: get rid of WARN if failed to cow user pages
Date: Tue, 14 Jan 2020 22:02:34 -0800 [thread overview]
Message-ID: <CAPcyv4hMPh0C+_OV+vuiYQikb8ZvRanna4vXfKN=10yrAyCjDA@mail.gmail.com> (raw)
In-Reply-To: <20191225054227.gii6ctjkuddjnprs@xzhoux.usersys.redhat.com>
[ drop Ross, add Kirill, linux-mm, and lkml ]
On Tue, Dec 24, 2019 at 9:42 PM Murphy Zhou <jencce.kernel@gmail.com> wrote:
>
> By running xfstests with fsdax enabled, generic/437 always hits this
> warning[1] since this commit:
>
> commit 83d116c53058d505ddef051e90ab27f57015b025
> Author: Jia He <justin.he@arm.com>
> Date: Fri Oct 11 22:09:39 2019 +0800
>
> mm: fix double page fault on arm64 if PTE_AF is cleared
>
> Looking at the test program[2] generic/437 uses, it's pretty easy
> to hit this warning. Remove this WARN as it seems not necessary.
This is not sufficient justification. Does this same test fail without
DAX? If not, why not? At a minimum you need to explain why this is not
indicating a problem.
next parent reply other threads:[~2020-01-15 6:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191225054227.gii6ctjkuddjnprs@xzhoux.usersys.redhat.com>
2020-01-15 6:02 ` Dan Williams [this message]
2020-02-18 21:09 ` Jeff Moyer
2020-02-19 1:58 ` Murphy Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4hMPh0C+_OV+vuiYQikb8ZvRanna4vXfKN=10yrAyCjDA@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=jencce.kernel@gmail.com \
--cc=justin.he@arm.com \
--cc=kirill.shutemov@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox