Re: [PATCH 1/2] vfs: add flags parameter to ->mmap() in 'struct file_operations'

[Dan Williams <dan.j.williams@intel.com>]

On Thu, Aug 31, 2017 at 3:02 AM, Christoph Hellwig <hch@lst.de> wrote:
>> -static int ecryptfs_mmap(struct file *file, struct vm_area_struct *vma)
>> +static int ecryptfs_mmap(struct file *file, struct vm_area_struct *vma,
>> +                      unsigned long map_flags)
>>  {
>>       struct file *lower_file = ecryptfs_file_to_lower(file);
>>       /*
>> @@ -179,7 +180,7 @@ static int ecryptfs_mmap(struct file *file, struct vm_area_struct *vma)
>>        */
>>       if (!lower_file->f_op->mmap)
>>               return -ENODEV;
>> -     return generic_file_mmap(file, vma);
>> +     return generic_file_mmap(file, vma, 0);
>
> Shouldn't ecryptfs pass on the flags?  Same for coda_file_mmap and
> shm_mmap.

Yes, I'll get those fixed up.

>
>> -static inline int call_mmap(struct file *file, struct vm_area_struct *vma)
>> +static inline int call_mmap(struct file *file, struct vm_area_struct *vma,
>> +                         unsigned long flags)
>>  {
>> -     return file->f_op->mmap(file, vma);
>> +     return file->f_op->mmap(file, vma, flags);
>>  }
>
> It would be great to kill this pointless wrapper while we're at it.

Will do.

Thanks for taking a look!

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>