From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1840FC10F13 for ; Tue, 16 Apr 2019 18:54:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B5F9120674 for ; Tue, 16 Apr 2019 18:54:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="yD+EKeum" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5F9120674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 52FD06B0007; Tue, 16 Apr 2019 14:54:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E0BF6B0008; Tue, 16 Apr 2019 14:54:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D0D86B000D; Tue, 16 Apr 2019 14:54:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) by kanga.kvack.org (Postfix) with ESMTP id 0F30F6B0007 for ; Tue, 16 Apr 2019 14:54:27 -0400 (EDT) Received: by mail-ot1-f72.google.com with SMTP id n2so11329718otk.19 for ; Tue, 16 Apr 2019 11:54:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:mime-version:references :in-reply-to:from:date:message-id:subject:to:cc; bh=EeNUxDh1Z4rgIbmhy0YqlnrE8GEGGuf75X3wDbU1tvQ=; b=Tn6f6QU+mChvqM4X8mCbvY5ODKErv97M85/g29DTuyu07YPs6j2kTO6QVYIAmitHzD HjtlSxBp0KiX+sp4dCuYrWCo4/iKIReapPyvzktyITrukU1zLTR/5hm3rqprRsKAlfMd riFJt3XQsH4rD9q5Xuyz6rQCNSWaAX1lIG0JK2CNmNKWImblMfDdq7DMm7wiQy3CuREa DLN3ZfQEoCEemMtGgdFuokQ3QNvSF/Pb0zQqJ9G01gvBqzMCQIZp2aLsOZxjYoYM0//M d/on7Ty8SQe+8S3ta+btfXAkz9CzUF49K0RckUcPy4cnSrl3SglkT+otWdEIMMiZvLEg U5Mw== X-Gm-Message-State: APjAAAW2gS3dzP6ctpT0eLC5eZ8TuqvWe20b7kEdOi+4WHOjl/2FjOer FlB6fYVfnF6JHkFwUSPYvrVip67UrYMlrz3Zzucvh/ibG2hHYzxo6nobnIhd8ZqALHabRfVQne1 0dspVN/WH2XkirWyID6cMTKpDfJCqZXg/59FvZozDEa1EArbORX4Kj7QiGqmE5dnnlQ== X-Received: by 2002:a9d:5e90:: with SMTP id f16mr48940233otl.86.1555440866700; Tue, 16 Apr 2019 11:54:26 -0700 (PDT) X-Received: by 2002:a9d:5e90:: with SMTP id f16mr48940206otl.86.1555440865856; Tue, 16 Apr 2019 11:54:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555440865; cv=none; d=google.com; s=arc-20160816; b=YuGZO49pXWcCBBKwBa6ad9jfc9LhtOXkMIvb3RzLb+ISAez9NPgzCldPg+DF4CpQyv NKcfD6KtrLArXbQZBlTkzk13B5Sq/Hw37c67ID1uCNJfT8FqBlGmOC5/APFjx005H/Et XUAyDLeHKEUsbBwWbLX8QfPPs+xQl0CdgyrkMhJ+ceGufLanM0hZo72LQFiuGrrL+D1q irkMz3alKsp++XbNtpHe2EpTb37GZBkvIgIeERVUwG5Woeq/OaUmXiqxdSEhhufdhavB eqA1GqS5cFFq6SYOVGEEn/xXX8VCfTeWyIIKq7zIJLolZWvDgzwPv5iG9ajRqWznllVb IZ9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=EeNUxDh1Z4rgIbmhy0YqlnrE8GEGGuf75X3wDbU1tvQ=; b=oz2HVZXvyzQIVvlWKFeec20UJ/Sz6N7MB57EJ5BqKKLwVTfBXH6iEUkYVJ1CS7GDRo fZR3KZrkIOWReVvztktahMbyBtpBiPSeQaRHyfFoDhjXO8XsQYkRz6LVYaKevoYtniUU J29WK23DGQ9pjBb2RXWpfZ0MYtKQ6o3+FMasdF0S7pZ6CXuW3czuXj1WkRADLKUo+CZn yCND15fX9y3Z16uS5JTyFgxvRx01OHCoJSDbeCG+896lwsMgT7s8L0GNQBX3A7rjMM1x Vqk5kenJE+dSnCMDc6v204nNegBCvFjTVobmj2A8UTDM73ByhMu1ivj6QkAUtc00PdMD OFQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=yD+EKeum; spf=pass (google.com: domain of dan.j.williams@intel.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id f14sor30262997oto.41.2019.04.16.11.54.25 for (Google Transport Security); Tue, 16 Apr 2019 11:54:25 -0700 (PDT) Received-SPF: pass (google.com: domain of dan.j.williams@intel.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=yD+EKeum; spf=pass (google.com: domain of dan.j.williams@intel.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EeNUxDh1Z4rgIbmhy0YqlnrE8GEGGuf75X3wDbU1tvQ=; b=yD+EKeummZuJ3ulm8hxQNqIv952geApEoWYVLRDROeswjTTEbF2K3l1WdBip8af3UM NPU4jzaL9mJM/tVXIXTvxS84bb0PYN2WJm0yhhhrW1C8It4YSTtIJcLmV2aR9gvRQlES Vmh6fwAp/TlYOS9LESqWFuNYAusP22lYLbzf1q9oEirXt1+yJCxGG2bNoq9IK1gBPUcg nHxzU++uglu/GpJLAkWF3Qvc3tJmyfbVzwIMH/ELYp/eXoVEHwr189RYFR/G+cT0G60d IkBlTfJWH5po9JZVLEF3zJFpThfssX+0JjnqKAXeG99djeL3lP6RkZJbkAjyeyRo5eGo pXag== X-Google-Smtp-Source: APXvYqxdmRQ0ZvCP7MGDxhdMGMXmtkdJ6R5e0tpU8HYYWcp0IhZ1Ml7pjyyCljd55voTnY5zNBZluQC99HrPjptTfF4= X-Received: by 2002:a9d:5c86:: with SMTP id a6mr50230698oti.118.1555440865341; Tue, 16 Apr 2019 11:54:25 -0700 (PDT) MIME-Version: 1.0 References: <20190215185151.GG7897@sirena.org.uk> <20190226155948.299aa894a5576e61dda3e5aa@linux-foundation.org> <20190228151438.fc44921e66f2f5d393c8d7b4@linux-foundation.org> <026b5082-32f2-e813-5396-e4a148c813ea@collabora.com> <20190301124100.62a02e2f622ff6b5f178a7c3@linux-foundation.org> <3fafb552-ae75-6f63-453c-0d0e57d818f3@collabora.com> <36faea07-139c-b97d-3585-f7d6d362abc3@collabora.com> <20190306140529.GG3549@rapoport-lnx> <21d138a5-13e4-9e83-d7fe-e0639a8d180a@collabora.com> In-Reply-To: From: Dan Williams Date: Tue, 16 Apr 2019 11:54:13 -0700 Message-ID: Subject: Re: next/master boot bisection: next-20190215 on beaglebone-black To: Guenter Roeck Cc: Kees Cook , kernelci@groups.io, Guillaume Tucker , Mike Rapoport , Andrew Morton , Michal Hocko , Mark Brown , Tomeu Vizoso , Matt Hart , Stephen Rothwell , Kevin Hilman , Enric Balletbo i Serra , Nicholas Piggin , Dominik Brodowski , Masahiro Yamada , Adrian Reber , Linux Kernel Mailing List , Johannes Weiner , Linux MM , Mathieu Desnoyers , Richard Guy Briggs , "Peter Zijlstra (Intel)" , info@kernelci.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 11, 2019 at 1:54 PM Guenter Roeck wrote: [..] > > > Boot tests report > > > > > > Qemu test results: > > > total: 345 pass: 345 fail: 0 > > > > > > This is on top of next-20190410 with CONFIG_SHUFFLE_PAGE_ALLOCATOR=y > > > and the known crashes fixed. > > > > In addition to CONFIG_SHUFFLE_PAGE_ALLOCATOR=y you also need the > > kernel command line option "page_alloc.shuffle=1" > > > > ...so I doubt you are running with shuffling enabled. Another way to > > double check is: > > > > cat /sys/module/page_alloc/parameters/shuffle > > Yes, you are right. Because, with it enabled, I see: > > Kernel command line: rdinit=/sbin/init page_alloc.shuffle=1 panic=-1 > console=ttyAMA0,115200 page_alloc.shuffle=1 > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 0 at ./include/linux/jump_label.h:303 > page_alloc_shuffle+0x12c/0x1ac > static_key_enable(): static key 'page_alloc_shuffle_key+0x0/0x4' used > before call to jump_label_init() This looks to be specific to ARM never having had to deal with DEFINE_STATIC_KEY_TRUE in the past. I am able to avoid this warning by simply not enabling JUMP_LABEL support in my build. > Modules linked in: > CPU: 0 PID: 0 Comm: swapper Not tainted > 5.1.0-rc4-next-20190410-00003-g3367c36ce744 #1 > Hardware name: ARM Integrator/CP (Device Tree) > [] (unwind_backtrace) from [] (show_stack+0x10/0x18) > [] (show_stack) from [] (dump_stack+0x18/0x24) > [] (dump_stack) from [] (__warn+0xe0/0x108) > [] (__warn) from [] (warn_slowpath_fmt+0x44/0x6c) > [] (warn_slowpath_fmt) from [] > (page_alloc_shuffle+0x12c/0x1ac) > [] (page_alloc_shuffle) from [] (shuffle_store+0x28/0x48) > [] (shuffle_store) from [] (parse_args+0x1f4/0x350) > [] (parse_args) from [] (start_kernel+0x1c0/0x488) > [] (start_kernel) from [<00000000>] ( (null)) > > I'll re-run the test, but I suspect it will drown in warnings. I slogged through getting a Beagle Bone Black up and running with a Yocto build and it is not failing. I have tried apply the patches on top of v5.1-rc5 as well as re-testing next-20190215 label, no reproduction. The shuffle appears to avoid anything sensitive by default, below are the shuffle actions that were taken relative to iomem. Can someone with a failure reproduction please send me more details about their configuration? It would also help to get a failing boot log with the pr_debug() statements in mm/shuffle.c enabled to see if the failure is correlated with any unexpected shuffle actions. 80000000-9fffffff : System RAM 80008000-809fffff : Kernel code 80b00000-812be523 : Kernel data [ 0.086469] __shuffle_zone: swap: 0x81800 -> 0x99800 [ 0.086558] __shuffle_zone: swap: 0x82000 -> 0x88800 [ 0.086575] __shuffle_zone: swap: 0x82800 -> 0x89800 [ 0.086591] __shuffle_zone: swap: 0x83000 -> 0x89000 [ 0.086606] __shuffle_zone: swap: 0x83800 -> 0x8a800 [ 0.086621] __shuffle_zone: swap: 0x84000 -> 0x93800 [ 0.086636] __shuffle_zone: swap: 0x84800 -> 0x83000 [ 0.086651] __shuffle_zone: swap: 0x85000 -> 0x8f000 [ 0.086666] __shuffle_zone: swap: 0x85800 -> 0x88000 [ 0.086689] __shuffle_zone: swap: 0x86000 -> 0x84000 [ 0.086704] __shuffle_zone: swap: 0x86800 -> 0x8c800 [ 0.086719] __shuffle_zone: swap: 0x87000 -> 0x93000 [ 0.086735] __shuffle_zone: swap: 0x87800 -> 0x94000 [ 0.086751] __shuffle_zone: swap: 0x88000 -> 0x90800 [ 0.086766] __shuffle_zone: swap: 0x88800 -> 0x9d000 [ 0.086781] __shuffle_zone: swap: 0x89000 -> 0x82800 [ 0.086796] __shuffle_zone: swap: 0x89800 -> 0x95800 [ 0.086811] __shuffle_zone: swap: 0x8a000 -> 0x98000 [ 0.086826] __shuffle_zone: swap: 0x8a800 -> 0x89000 [ 0.086842] __shuffle_zone: swap: 0x8b000 -> 0x81800 [ 0.086857] __shuffle_zone: swap: 0x8b800 -> 0x88800 [ 0.086872] __shuffle_zone: swap: 0x8c000 -> 0x8a000 [ 0.086891] __shuffle_zone: swap: 0x8c800 -> 0x84800 [ 0.086906] __shuffle_zone: swap: 0x8d000 -> 0x95000 [ 0.086921] __shuffle_zone: swap: 0x8d800 -> 0x8d000 [ 0.086935] __shuffle_zone: swap: 0x8e000 -> 0x8e800 [ 0.086950] __shuffle_zone: swap: 0x8e800 -> 0x99000 [ 0.086964] __shuffle_zone: swap: 0x8f000 -> 0x8d000 [ 0.086979] __shuffle_zone: swap: 0x90000 -> 0x91000 [ 0.086994] __shuffle_zone: swap: 0x90800 -> 0x83000 [ 0.087009] __shuffle_zone: swap: 0x91000 -> 0x91800 [ 0.087025] __shuffle_zone: swap: 0x91800 -> 0x8d800 [ 0.087040] __shuffle_zone: swap: 0x92000 -> 0x86800 [ 0.087054] __shuffle_zone: swap: 0x92800 -> 0x92000 [ 0.087070] __shuffle_zone: swap: 0x93000 -> 0x91000 [ 0.087088] __shuffle_zone: swap: 0x93800 -> 0x85000 [ 0.087103] __shuffle_zone: swap: 0x94000 -> 0x8b800 [ 0.087117] __shuffle_zone: swap: 0x94800 -> 0x96000 [ 0.087132] __shuffle_zone: swap: 0x95000 -> 0x91000 [ 0.087147] __shuffle_zone: swap: 0x95800 -> 0x8e000 [ 0.087161] __shuffle_zone: swap: 0x96000 -> 0x95800 [ 0.087179] __shuffle_zone: swap: 0x96800 -> 0x8c800 [ 0.087193] __shuffle_zone: swap: 0x97000 -> 0x89000 [ 0.087208] __shuffle_zone: swap: 0x97800 -> 0x85000 [ 0.087224] __shuffle_zone: swap: 0x98000 -> 0x85000 [ 0.087239] __shuffle_zone: swap: 0x98800 -> 0x93000 [ 0.087255] __shuffle_zone: swap: 0x99000 -> 0x94800 [ 0.087269] __shuffle_zone: swap: 0x99800 -> 0x94000