From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E649C433F5 for ; Thu, 10 Mar 2022 01:02:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A9F38D0002; Wed, 9 Mar 2022 20:02:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8583D8D0001; Wed, 9 Mar 2022 20:02:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 746AF8D0002; Wed, 9 Mar 2022 20:02:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0110.hostedemail.com [216.40.44.110]) by kanga.kvack.org (Postfix) with ESMTP id 64F2B8D0001 for ; Wed, 9 Mar 2022 20:02:18 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 25E749F85C for ; Thu, 10 Mar 2022 01:02:18 +0000 (UTC) X-FDA: 79226675556.27.A8B7308 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf21.hostedemail.com (Postfix) with ESMTP id 9E27C1C0019 for ; Thu, 10 Mar 2022 01:02:17 +0000 (UTC) Received: by mail-pj1-f42.google.com with SMTP id mr24-20020a17090b239800b001bf0a375440so6831164pjb.4 for ; Wed, 09 Mar 2022 17:02:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IhfcqA5j4A8+cMHFR/NtiJjgNVB+qOjhOgFLJgToPWQ=; b=NdlCgpyR4b6VJWwPwqOC1MX6c6jvcptN0j9px6P5gSJixNo6VOfOmyZRxxRxE+VcE+ 3nEGij+QWTIieZfJjhT4HEQ3r8HlS19ooIBYayhvUymBhIQ9hyFgxtJgI8pCRkAg+1pQ wZsyJA2tqg/k12oz9Zx1hzeXs53PX/Kj85fAbo2oA10eW2hvyuDPgEUBhgXI6pkk7Y4r 4/vjzDmA4LTjsDjSdL3djqJkFB/CcFZI7eYmB7zcVbZW/JYEKjHk2esCGc2dbDEPdE6T FFVi6RCbUv4X+dMgyidWvaHx1H1e/ThhA9xh9EmPmn8MxL3p8c6rsvYdZ7ZqiLAGwoMG 82mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IhfcqA5j4A8+cMHFR/NtiJjgNVB+qOjhOgFLJgToPWQ=; b=RugxPh4gPOobNOd0E/BORFBbqmEWXSwG5DdBSW7Vh2JliDNIkV4RUp8FE3MfXWb5IW 1jBy+k6PA+YW94fLSj0Zzub6XbnMD3q0Vnh+g2EmWPBo9z33i0Hy7AUqCwWMt5W/7Dlp +8IDDkLMzFi9j7lVT9TvykUyh1muGkOh3hXWtQPDEcRocklOSgxjU1AHuawbACBl9faF 98ulXqEKHIq8FQqsCz5DyZK97MFCBDi6x+CxBO5UDcO24dBSXZ29EWMOLm5HdO+M+wKQ 11SBE1d6FxDZ0PRKgpCmaCjnTyFhTCR6BXpDj3MhlneC0dK3oP+UDA7E3+0AvNVwD1P9 4jtQ== X-Gm-Message-State: AOAM531JKpDfwYVXAVZWgP6I7SgMx4fQOplyYjbdPkr/fmW1U6GdydBy awgguZ5p2Mxo15qYXc/UBS2CwVq5EXVeVTlozpCPkA== X-Google-Smtp-Source: ABdhPJwgZUATGKxceYX9Kl5KUvMdd8JlCChq4tHFBS02sVXYJrllv/gFImd7TLQzyeaZBA7iP0auoWsyQWoxXaoDMk0= X-Received: by 2002:a17:902:d506:b0:151:ced2:3cf with SMTP id b6-20020a170902d50600b00151ced203cfmr2284734plg.147.1646874136625; Wed, 09 Mar 2022 17:02:16 -0800 (PST) MIME-Version: 1.0 References: <20220302082718.32268-1-songmuchun@bytedance.com> <20220302082718.32268-7-songmuchun@bytedance.com> In-Reply-To: <20220302082718.32268-7-songmuchun@bytedance.com> From: Dan Williams Date: Wed, 9 Mar 2022 17:02:05 -0800 Message-ID: Subject: Re: [PATCH v4 6/6] mm: remove range parameter from follow_invalidate_pte() To: Muchun Song Cc: Matthew Wilcox , Jan Kara , Al Viro , Andrew Morton , Alistair Popple , Yang Shi , Ralph Campbell , Hugh Dickins , xiyuyang19@fudan.edu.cn, "Kirill A. Shutemov" , Ross Zwisler , Christoph Hellwig , linux-fsdevel , Linux NVDIMM , Linux Kernel Mailing List , Linux MM , duanxiongchun@bytedance.com, Muchun Song Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9E27C1C0019 X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel-com.20210112.gappssmtp.com header.s=20210112 header.b=NdlCgpyR; spf=none (imf21.hostedemail.com: domain of dan.j.williams@intel.com has no SPF policy when checking 209.85.216.42) smtp.mailfrom=dan.j.williams@intel.com; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=intel.com (policy=none) X-Stat-Signature: hea6wpu758zz6xbigzcffu6kzbdcn1sa X-HE-Tag: 1646874137-591235 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 2, 2022 at 12:30 AM Muchun Song wrote: > > The only user (DAX) of range parameter of follow_invalidate_pte() > is gone, it safe to remove the range paramter and make it static > to simlify the code. > Looks good, I suspect this savings is still valid if the "just use page_mkclean_one" directly feedback is workable. Otherwise you can add: Reviewed-by: Dan Williams