From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59A55C4BA09 for ; Wed, 26 Feb 2020 00:32:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1717A20732 for ; Wed, 26 Feb 2020 00:32:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="1rFC1q7e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1717A20732 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A6B356B000A; Tue, 25 Feb 2020 19:32:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A1C946B000C; Tue, 25 Feb 2020 19:32:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90A976B000D; Tue, 25 Feb 2020 19:32:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0113.hostedemail.com [216.40.44.113]) by kanga.kvack.org (Postfix) with ESMTP id 7A0FA6B000A for ; Tue, 25 Feb 2020 19:32:44 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 469B92C8A for ; Wed, 26 Feb 2020 00:32:44 +0000 (UTC) X-FDA: 76530402648.03.edge26_17d0263b7ec43 X-HE-Tag: edge26_17d0263b7ec43 X-Filterd-Recvd-Size: 7206 Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Wed, 26 Feb 2020 00:32:43 +0000 (UTC) Received: by mail-ot1-f67.google.com with SMTP id p8so1315597oth.10 for ; Tue, 25 Feb 2020 16:32:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=f70455Z6ta/EJCB61dHVpdnNh4osTmAbssLK2ZDouI8=; b=1rFC1q7eiqEoo/Ct8CLTc8uB6k3LoZ19oRJxA++l0zQgLc/UuThtXzQMgIWfj0sABp Tu/rBPamdN1eVJvSLzs32HeQA4BVe2YUCQ1Tn2metD9qEWM0OzwmfiMBaESZbeWmVueY 31XvzUzGzkYQ+M5LGVFUZzc+9QGaHPlVPsaxO62G1PTIwMacG1h2AXJ7RsfUhr9pAPYS pAFjp6krJgYzuaxPTz+vUaSvelbdMaNAu5U4sM+5GFJ8T583/KnVxZ7l59pGq8Zx1N55 /0KS/3htbv5/xl4ByvCEOahacZfCCi1uloIgUD+0kK2IgnIpjShkvcodpT/EheCpFi3J eEMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=f70455Z6ta/EJCB61dHVpdnNh4osTmAbssLK2ZDouI8=; b=NFnhxsZvfctGKrhB0J/ptNGxUDNag/PDqhvLL779Uy6onmaRn9ysGVGZIx3505cvXr atOxqwO9aVa3q+e1trHLmfdvnh+E2xzKDNhiKg3cqO93IXv0olD5j25IeR0rP4a9Pe/w upb+uG6vmFBlO1Huf+Bm3Fy+q/JdEuDZmuyaw5sYs/z9mysSMkveca/m7ihtqkuhTRt0 4eCEAx2WP90q17IunNkbh5serJ7Xuqvj548txM+hokTuZkdpgNUavSGBb2rN5fKYp1DV R4iN1MYMFERj4grfDqK7lJXedrBpN7HqaI18zon/HCbRkls9R4t+J4DNN5ZmQJ1FfPp2 yYMw== X-Gm-Message-State: APjAAAXnVapgt1GLVuWyGEkzDitZ8oMKPpm1qS2Ue0wV0iW40ZFNrknn f0gzsKwsgiVIQOmhnASWWGu//fGc2M0kN7b/XWE6Cw== X-Google-Smtp-Source: APXvYqyAsJnZlWJOpclJB6h8LyKxIkm6H51Qk8MIk/UhPC9KtK1RQif8usKO+skdYm0o9lQhxq1Hc5Wd2TvdmbQAZxU= X-Received: by 2002:a9d:64d8:: with SMTP id n24mr886741otl.71.1582677162325; Tue, 25 Feb 2020 16:32:42 -0800 (PST) MIME-Version: 1.0 References: <20200221032720.33893-1-alastair@au1.ibm.com> <240fbefc6275ac0a6f2aa68715b3b73b0e7a8310.camel@au1.ibm.com> <20200224043750.GM24185@bombadil.infradead.org> <83034494d5c3da1fa63b172e844f85d0fec7910a.camel@au1.ibm.com> In-Reply-To: From: Dan Williams Date: Tue, 25 Feb 2020 16:32:31 -0800 Message-ID: Subject: Re: [PATCH v3 00/27] Add support for OpenCAPI Persistent Memory devices To: "Alastair D'Silva" Cc: "Oliver O'Halloran" , Matthew Wilcox , "Aneesh Kumar K . V" , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Frederic Barrat , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , Vishal Verma , Dave Jiang , Ira Weiny , Andrew Morton , Mauro Carvalho Chehab , "David S. Miller" , Rob Herring , Anton Blanchard , Krzysztof Kozlowski , Mahesh Salgaonkar , Madhavan Srinivasan , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Anju T Sudhakar , Hari Bathini , Thomas Gleixner , Greg Kurz , Nicholas Piggin , Masahiro Yamada , Alexey Kardashevskiy , Linux Kernel Mailing List , linuxppc-dev , linux-nvdimm , Linux MM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 25, 2020 at 4:14 PM Alastair D'Silva wrote: > > On Mon, 2020-02-24 at 17:51 +1100, Oliver O'Halloran wrote: > > On Mon, Feb 24, 2020 at 3:43 PM Alastair D'Silva < > > alastair@au1.ibm.com> wrote: > > > On Sun, 2020-02-23 at 20:37 -0800, Matthew Wilcox wrote: > > > > On Mon, Feb 24, 2020 at 03:34:07PM +1100, Alastair D'Silva wrote: > > > > > V3: > > > > > - Rebase against next/next-20200220 > > > > > - Move driver to arch/powerpc/platforms/powernv, we now > > > > > expect > > > > > this > > > > > driver to go upstream via the powerpc tree > > > > > > > > That's rather the opposite direction of normal; mostly drivers > > > > live > > > > under > > > > drivers/ and not in arch/. It's easier for drivers to get > > > > overlooked > > > > when doing tree-wide changes if they're hiding. > > > > > > This is true, however, given that it was not all that desirable to > > > have > > > it under drivers/nvdimm, it's sister driver (for the same hardware) > > > is > > > also under arch, and that we don't expect this driver to be used on > > > any > > > platform other than powernv, we think this was the most reasonable > > > place to put it. > > > > Historically powernv specific platform drivers go in their respective > > subsystem trees rather than in arch/ and I'd prefer we kept it that > > way. When I added the papr_scm driver I put it in the pseries > > platform > > directory because most of the pseries paravirt code lives there for > > some reason; I don't know why. Luckily for me that followed the same > > model that Dan used when he put the NFIT driver in drivers/acpi/ and > > the libnvdimm core in drivers/nvdimm/ so we didn't have anything to > > argue about. However, as Matthew pointed out, it is at odds with how > > most subsystems operate. Is there any particular reason we're doing > > things this way or should we think about moving libnvdimm users to > > drivers/nvdimm/? > > > > Oliver > > > I'm not too fussed where it ends up, as long as it ends up somewhere :) > > From what I can tell, the issue is that we have both "infrastructure" > drivers, and end-device drivers. To me, it feels like drivers/nvdimm > should contain both, and I think this feels like the right approach. > > I could move it back to drivers/nvdimm/ocxl, but I felt that it was > only tolerated there, not desired. This could be cleared up with a > response from Dan Williams, and if it is indeed dersired, this is my > preferred location. Apologies if I gave the impression it was only tolerated. I'm ok with drivers/nvdimm/ocxl/, and to the larger point I'd also be ok with a drivers/{acpi => nvdimm}/nfit and {arch/powerpc/platforms/pseries => drivers/nvdimm}/papr_scm.c move as well to keep all the consumers of the nvdimm related code together with the core.