From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62D5DC3279D for ; Wed, 7 Oct 2020 02:40:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D95DA207EA for ; Wed, 7 Oct 2020 02:40:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="EPjdVqDe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D95DA207EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F09576B005C; Tue, 6 Oct 2020 22:40:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EBAFE6B0062; Tue, 6 Oct 2020 22:40:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA7E6900002; Tue, 6 Oct 2020 22:40:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0045.hostedemail.com [216.40.44.45]) by kanga.kvack.org (Postfix) with ESMTP id A258C6B005C for ; Tue, 6 Oct 2020 22:40:19 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 21A2B824999B for ; Wed, 7 Oct 2020 02:40:19 +0000 (UTC) X-FDA: 77343575358.15.actor79_3e0d2c2271cb Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id F27261814B0C1 for ; Wed, 7 Oct 2020 02:40:18 +0000 (UTC) X-HE-Tag: actor79_3e0d2c2271cb X-Filterd-Recvd-Size: 4286 Received: from mail-ej1-f66.google.com (mail-ej1-f66.google.com [209.85.218.66]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Wed, 7 Oct 2020 02:40:17 +0000 (UTC) Received: by mail-ej1-f66.google.com with SMTP id dt13so722570ejb.12 for ; Tue, 06 Oct 2020 19:40:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=afZ2ku0615X/vbgIsq8uZABQa+HrZmef3/cMOPPeXPE=; b=EPjdVqDeTinUn3xle7QkZRs1c1I777r6WwVNCzmQvuelLMEIhN7D3byY1DbMWiHRAd QgHw7nunbi78JiFNVYPaj+vzDaQToh84mycymDqg79odab44O2bFpy0hTFRZMk6Gq88h gdm22jg2FmT9PYcFKiksCpHH97YYjHNLfkRJqB+XyuOtAK7X6n9Ol7Qc3aWxyX/ubcf1 1Dj3nT3ueZ1gSrXVBd01SuIcMxMF+W8KjeuouHZbfkVWg3QUD53z+H8ypZQCYHGiMbYk lCoLazlQUecuVDEtHUfRDwSsCvcaF59aNbsh9HWw6NNgsgGSQloXWj+DnfN5l7npN3En PmkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=afZ2ku0615X/vbgIsq8uZABQa+HrZmef3/cMOPPeXPE=; b=RWsg6/8iJL0R9GfNndeFkJmyKIh7SgAxmzCR/yiR9NLEUeJPCgK1WHryCGS2o+W7Li 1XKnzj0bXxJnfO56dP/YktaNVcYglHzDnXUdr0MnVvuFggueGstDRMOKpzVOv3jx3NwS 2nQQf0932r71y5hbn12rZgn2WjJ/djxwMJrxxvOBRmZo+XnRSwCK1NPu/LaPNkyjuJuG bXwKGUsHo/Yy3IfMfkzlxJa8XnsdCaGM/yMHRdKD9ROkObpfZRyBB1pTqMiM9es+vbZm PCH1aiRJD6gScUM4DanRLkkIBO7iXD2QsYKW77fRYjDnNju4keVHz2Lc22qkaW//ATex ZY3A== X-Gm-Message-State: AOAM532EjGXfBaN5VXR5Y71cAKAzz5V1oXJIr4BLkiOKp4+Ta0aU7Gdo Ej2SnrxMLvg9UqyCKYMs8v3+8px84Is3RxsUNt+MTg== X-Google-Smtp-Source: ABdhPJyzhK0w2iAz2iCMzOOn/0AFV3bEvaxuBmF2mBxx+C4IpyFlFHdfkT/qw+BQgpUSKwf1wNdFiTZy1ImFQ33Wm94= X-Received: by 2002:a17:906:1a0b:: with SMTP id i11mr1116582ejf.472.1602038416463; Tue, 06 Oct 2020 19:40:16 -0700 (PDT) MIME-Version: 1.0 References: <20201006230930.3908-1-rcampbell@nvidia.com> In-Reply-To: <20201006230930.3908-1-rcampbell@nvidia.com> From: Dan Williams Date: Tue, 6 Oct 2020 19:40:05 -0700 Message-ID: Subject: Re: [PATCH] ext4/xfs: add page refcount helper To: Ralph Campbell Cc: Linux MM , linux-xfs , linux-fsdevel , linux-nvdimm , Linux Kernel Mailing List , linux-ext4 , Matthew Wilcox , Jan Kara , Alexander Viro , "Theodore Ts'o" , Christoph Hellwig , Andreas Dilger , "Darrick J. Wong" , Andrew Morton Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 6, 2020 at 4:09 PM Ralph Campbell wrote: > > There are several places where ZONE_DEVICE struct pages assume a reference > count == 1 means the page is idle and free. Instead of open coding this, > add a helper function to hide this detail. > > Signed-off-by: Ralph Campbell > Reviewed-by: Christoph Hellwig > --- > > I'm resending this as a separate patch since I think it is ready to > merge. Originally, this was part of an RFC and is unchanged from v3: > https://lore.kernel.org/linux-mm/20201001181715.17416-1-rcampbell@nvidia.com > > It applies cleanly to linux-5.9.0-rc7-mm1 but doesn't really > depend on anything, just simple merge conflicts when applied to > other trees. > I'll let the various maintainers decide which tree and when to merge. > It isn't urgent since it is a clean up patch. Thanks Ralph, it looks good to me. Jan, or Ted care to ack? I don't have much else pending for dax at the moment as Andrew is carrying my dax updates for this cycle. Andrew please take this into -mm if you get a chance. Otherwise I'll cycle back to it when some other dax updates arrive in my queue.