From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95A9DC433E3 for ; Mon, 13 Jul 2020 16:55:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2D5172067D for ; Mon, 13 Jul 2020 16:55:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="gtc+M+tW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D5172067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 98B4D8D0005; Mon, 13 Jul 2020 12:55:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 914AC8D0001; Mon, 13 Jul 2020 12:55:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DC5A8D0005; Mon, 13 Jul 2020 12:55:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0069.hostedemail.com [216.40.44.69]) by kanga.kvack.org (Postfix) with ESMTP id 632118D0001 for ; Mon, 13 Jul 2020 12:55:03 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id DAB4A180AD822 for ; Mon, 13 Jul 2020 16:55:02 +0000 (UTC) X-FDA: 77033652444.26.dust41_540f58c26ee9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id B07CB1804B669 for ; Mon, 13 Jul 2020 16:55:02 +0000 (UTC) X-HE-Tag: dust41_540f58c26ee9 X-Filterd-Recvd-Size: 6441 Received: from mail-ed1-f67.google.com (mail-ed1-f67.google.com [209.85.208.67]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Mon, 13 Jul 2020 16:55:01 +0000 (UTC) Received: by mail-ed1-f67.google.com with SMTP id a1so8832740edt.10 for ; Mon, 13 Jul 2020 09:55:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HgOXhDZaQ0Vm8QAO9SEojO+HqYa4R2CkQWkXTg5E7NY=; b=gtc+M+tWYcQvh1sK797pkjo7WfNXIE8olCSzxehn9iEfDXPy4UnYyp2+rSeemkOHd9 3YCD1bGiwRH6cQssBiZxingdGDUwZDouqVsreN1+gJuIGG6p5wdMSWJUxTsfZgJsaSP/ EKUruPSgSi5imDehnJ0OoKNYarRo4grmHiicSB3YKJASTXyGDOGVaFs1Xtu7/0rRGn5l W9+vrC+x0eOE026JlZDzAPRS9I7c7ZrINzB0baTS0Fv4LSjRTfPGrURIPHkOUcVtnaEy 84Ykd5bPtW/7cJhsDtttHYS1i4aFielTGd+j2sm60fnPvc5Fai51ccDG/VbXOrStWecV ncaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HgOXhDZaQ0Vm8QAO9SEojO+HqYa4R2CkQWkXTg5E7NY=; b=CbQF0bJ/9vITwJAPOn3iOzVFXEpV0udYCgaZWIZdsvHqiNSvYaxYoi3r7/+HsWwMZm AXyR5YY+54wU/KL6lrn1jlOD7qtViUqaThcAI5BjyReIL2Olpm55yKujVxdcLLTYVi1Y JAz0/m9LwBmmsuM3IjSFFFL6bb0tLDvf/0+R12IulNWFVVAk0Sb/pSciC9y7TPbwzhJU ju6jJaa+J5gyVt4TERSrFToQesgqthhHsvB596Y7Sx7XwoZumTXyAa2NI1icPu0xQZQl Kkk2Nb1e9KijUP3Q120tdDxNs5ohtMzyF3LrdZsbN6eCvY3ud9Ogmiv39ACTOI42xP2D JdbA== X-Gm-Message-State: AOAM530zu/Z4/qg5cPLR3bydwViJlWl/CV/hdMzokFJ1ec74n2aHs3rB uxXtJX38YTx8WlfFwwyPtviEWYF8DOL6SqZsxgjgWg== X-Google-Smtp-Source: ABdhPJy2i/ttAyiKjR1qbX0QvV/QhWFNtJPFDiAHrxVvIXYFYUkb5Tgr0e/mIqA9cSxtejueFDTinGXoBIyHGcdsgj8= X-Received: by 2002:a50:d9cb:: with SMTP id x11mr299675edj.93.1594659300586; Mon, 13 Jul 2020 09:55:00 -0700 (PDT) MIME-Version: 1.0 References: <159457116473.754248.7879464730875147365.stgit@dwillia2-desk3.amr.corp.intel.com> <159457126779.754248.3575056680831729751.stgit@dwillia2-desk3.amr.corp.intel.com> <52e00a67-b686-8554-8b92-a172ba9f34b6@nvidia.com> In-Reply-To: <52e00a67-b686-8554-8b92-a172ba9f34b6@nvidia.com> From: Dan Williams Date: Mon, 13 Jul 2020 09:54:49 -0700 Message-ID: Subject: Re: [PATCH v2 19/22] mm/memremap_pages: Convert to 'struct range' To: Ralph Campbell Cc: linux-nvdimm , Paul Mackerras , Michael Ellerman , Benjamin Herrenschmidt , Vishal Verma , Dave Jiang , Ben Skeggs , David Airlie , Daniel Vetter , Ira Weiny , Jason Gunthorpe , Peter Zijlstra , Dave Hansen , Ard Biesheuvel , Linux MM , Linux Kernel Mailing List , Linux ACPI , Christoph Hellwig , Joao Martins Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: B07CB1804B669 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 13, 2020 at 9:36 AM Ralph Campbell wrote: > > > On 7/12/20 9:27 AM, Dan Williams wrote: > > The 'struct resource' in 'struct dev_pagemap' is only used for holding > > resource span information. The other fields, 'name', 'flags', 'desc', > > 'parent', 'sibling', and 'child' are all unused wasted space. > > > > This is in preparation for introducing a multi-range extension of > > devm_memremap_pages(). > > > > The bulk of this change is unwinding all the places internal to > > libnvdimm that used 'struct resource' unnecessarily. > > > > P2PDMA had a minor usage of the flags field, but only to report failures > > with "%pR". That is replaced with an open coded print of the range. > > > > Cc: Paul Mackerras > > Cc: Michael Ellerman > > Cc: Benjamin Herrenschmidt > > Cc: Dan Williams > > Cc: Vishal Verma > > Cc: Dave Jiang > > Cc: Ben Skeggs > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: Ira Weiny > > Cc: Jason Gunthorpe > > Signed-off-by: Dan Williams > > --- > > arch/powerpc/kvm/book3s_hv_uvmem.c | 13 +++-- > > drivers/dax/bus.c | 10 ++-- > > drivers/dax/bus.h | 2 - > > drivers/dax/dax-private.h | 5 -- > > drivers/dax/device.c | 3 - > > drivers/dax/hmem/hmem.c | 5 ++ > > drivers/dax/pmem/core.c | 12 ++--- > > drivers/gpu/drm/nouveau/nouveau_dmem.c | 3 + > > drivers/nvdimm/badrange.c | 26 +++++------ > > drivers/nvdimm/claim.c | 13 +++-- > > drivers/nvdimm/nd.h | 3 + > > drivers/nvdimm/pfn_devs.c | 12 ++--- > > drivers/nvdimm/pmem.c | 26 ++++++----- > > drivers/nvdimm/region.c | 21 +++++---- > > drivers/pci/p2pdma.c | 11 ++--- > > include/linux/memremap.h | 5 +- > > include/linux/range.h | 6 ++ > > mm/memremap.c | 77 ++++++++++++++++---------------- > > tools/testing/nvdimm/test/iomap.c | 2 - > > 19 files changed, 135 insertions(+), 120 deletions(-) > > I think you are missing a call to memremap_pages() in lib/test_hmm.c > and a call to release_mem_region() that need to be converted too. > Try setting CONFIG_TEST_HMM=m. Thanks Ralph, looks like I overlooked these changes since the rebase. > Also, what about the call to release_mem_region() in > drivers/gpu/drm/nouveau/nouveau_dmem.c? Doesn't that need a small change too? I'll double check my config, that one should have been flagged at build time.